pdurlej/kan-ductor

Fork 0

gemini(w1): add audit redaction fixtures for Signal refs and idempotency keys #105

New issue

Open

opened 2026-05-28 01:20:39 +02:00 by codex · 1 comment

codex commented

2026-05-28 01:20:39 +02:00

Collaborator

Parent: #2
Agent lane: Gemini 3.5 Flash
Wave: 1 / maintainer foundation
Risk class: medium

Goal

Default audit reads should not expose phone-like Signal refs or raw idempotency internals.

Context refs

Open issue #55
docs/agent-mcp-contract.md

Scope

Find audit view/read API redaction path.
Add fixtures containing signal:+48...:<message_id> and idempotency keys.
Assert default view is redacted and debug/raw path is gated.

Acceptance

Default response hides Signal number-like refs.
includeRaw=true behavior is documented/gated.
Pagination remains intact.

Suggested checks

Targeted API tests or snapshot tests.

Non-goals / fences

Do not deploy, restart production, rotate secrets, or run production migrations.
Do not widen MCP write authority or public exposure.
Keep the change small enough for one focused PR or one scouting report.

Expected output

A short PR or issue comment with findings, touched files, tests run, and remaining risks.

Parent: #2 Agent lane: Gemini 3.5 Flash Wave: 1 / maintainer foundation Risk class: medium ## Goal Default audit reads should not expose phone-like Signal refs or raw idempotency internals. ## Context refs - Open issue #55 - `docs/agent-mcp-contract.md` ## Scope - Find audit view/read API redaction path. - Add fixtures containing `signal:+48...:<message_id>` and idempotency keys. - Assert default view is redacted and debug/raw path is gated. ## Acceptance - Default response hides Signal number-like refs. - `includeRaw=true` behavior is documented/gated. - Pagination remains intact. ## Suggested checks - Targeted API tests or snapshot tests. ## Non-goals / fences - Do not deploy, restart production, rotate secrets, or run production migrations. - Do not widen MCP write authority or public exposure. - Keep the change small enough for one focused PR or one scouting report. ## Expected output A short PR or issue comment with findings, touched files, tests run, and remaining risks.

codex added the

labels

2026-05-28 01:20:39 +02:00

codex referenced this issue from a commit

2026-05-29 00:04:54 +02:00

test: add deep redaction fixtures for audit payloads (#105)

gemini referenced this issue from a pull request that will close it,

2026-05-29 00:05:01 +02:00

test: add deep redaction fixtures for audit payloads (#105) #135

codex referenced this issue

2026-06-03 08:51:00 +02:00

fix(agent): salvage Gemini regression fixtures #140

Iskra commented

2026-06-13 03:08:18 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/kan-ductor#issue#105`
Priority	p2
Action	observe
Scores	reach 4 / impact 4 / confidence 5
Piotr fit	high
Effort	small
Labels	`judge/p2`
Judge	`iskra` via `openclaw`

Rationale: This is P2 safety test hardening because audit reads should not expose phone-like Signal refs or raw idempotency internals by default.

Caveat: Keep default reads redacted and require explicit gated debug/raw access without breaking pagination or audit usability.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 5,
  "effort_hint": "small",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Issue proposes audit redaction fixtures for Signal-like refs and idempotency keys in Kan-ductor read surfaces.",
      "type": "forgejo",
      "value": "issue-title-body-labels-and-target-snapshot"
    },
    {
      "note": "Body scopes tests to default audit redaction, gated includeRaw behavior, and pagination preservation.",
      "type": "forgejo",
      "value": "issue-body-scope-and-acceptance"
    },
    {
      "note": "Body fences the work from production deploys, secret handling, migrations, MCP authority changes, or public exposure changes.",
      "type": "forgejo",
      "value": "issue-body-non-goals-and-fences"
    }
  ],
  "impact": 4,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-13T01:07:00Z",
  "labels_to_apply": [
    "judge/p2"
  ],
  "piotr_fit": "high",
  "priority": "p2",
  "rationale_summary": "This is P2 safety test hardening because audit reads should not expose phone-like Signal refs or raw idempotency internals by default.",
  "reach": 4,
  "recommended_next_action": "observe",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 105,
    "repo": "pdurlej/kan-ductor"
  },
  "target_snapshot": {
    "body_hash": "sha256:ace12715df46a85ca084d735a639a16b23ae3368d0025ce8954967f9c5a61ca7",
    "commit_count": null,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": null,
    "labels": [
      "api",
      "gemini-flash",
      "priority:p2",
      "safety",
      "small-task",
      "tests"
    ],
    "labels_hash": "sha256:a644b28af12fa95e8caae3e3f090ac77c28790825f50c81bfdc3e59cb2776b45",
    "state": "open",
    "title_hash": "sha256:3e5cb0d0a4ff47c8eca1148ea297fb1d5997abe311e643749607a6b629648c9a",
    "updated_at": "2026-06-03T08:51:00+02:00"
  },
  "top_caveat": "Keep default reads redacted and require explicit gated debug/raw access without breaking pagination or audit usability."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/kan-ductor#issue#105` | | Priority | p2 | | Action | observe | | Scores | reach 4 / impact 4 / confidence 5 | | Piotr fit | high | | Effort | small | | Labels | `judge/p2` | | Judge | `iskra` via `openclaw` | **Rationale:** This is P2 safety test hardening because audit reads should not expose phone-like Signal refs or raw idempotency internals by default. **Caveat:** Keep default reads redacted and require explicit gated debug/raw access without breaking pagination or audit usability. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue proposes audit redaction fixtures for Signal-like refs and idempotency keys in Kan-ductor read surfaces.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body scopes tests to default audit redaction, gated includeRaw behavior, and pagination preservation.", "type": "forgejo", "value": "issue-body-scope-and-acceptance" }, { "note": "Body fences the work from production deploys, secret handling, migrations, MCP authority changes, or public exposure changes.", "type": "forgejo", "value": "issue-body-non-goals-and-fences" } ], "impact": 4, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-13T01:07:00Z", "labels_to_apply": [ "judge/p2" ], "piotr_fit": "high", "priority": "p2", "rationale_summary": "This is P2 safety test hardening because audit reads should not expose phone-like Signal refs or raw idempotency internals by default.", "reach": 4, "recommended_next_action": "observe", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 105, "repo": "pdurlej/kan-ductor" }, "target_snapshot": { "body_hash": "sha256:ace12715df46a85ca084d735a639a16b23ae3368d0025ce8954967f9c5a61ca7", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "api", "gemini-flash", "priority:p2", "safety", "small-task", "tests" ], "labels_hash": "sha256:a644b28af12fa95e8caae3e3f090ac77c28790825f50c81bfdc3e59cb2776b45", "state": "open", "title_hash": "sha256:3e5cb0d0a4ff47c8eca1148ea297fb1d5997abe311e643749607a6b629648c9a", "updated_at": "2026-06-03T08:51:00+02:00" }, "top_caveat": "Keep default reads redacted and require explicit gated debug/raw access without breaking pagination or audit usability." }  ``` </details>

Iskra added the

judge/p2

label

2026-06-13 03:08:18 +02:00