pdurlej/kan-ductor

Fork 0

gemini(w2): relation idempotency mismatch regression #108

New issue

Open

opened 2026-05-28 01:20:40 +02:00 by codex · 1 comment

codex commented

2026-05-28 01:20:40 +02:00

Collaborator

Parent: #2
Agent lane: Gemini 3.5 Flash
Wave: 2 / board maturity
Risk class: low

Goal

Prevent relation writes from replaying one idempotency key with different inputs.

Context refs

_bmad-output/project-context.md follow-up fixes
docs/agent-mcp-contract.md

Scope

Find link/unlink relation idempotency handling.
Add test: same key + different relation/card input fails as conflict.
Keep exact same input replay idempotent.

Acceptance

Mismatch replay fails closed.
Same replay does not duplicate relation/audit.
Audit remains product-critical.

Suggested checks

Targeted relation API/MCP tests.

Non-goals / fences

Do not deploy, restart production, rotate secrets, or run production migrations.
Do not widen MCP write authority or public exposure.
Keep the change small enough for one focused PR or one scouting report.

Expected output

A short PR or issue comment with findings, touched files, tests run, and remaining risks.

Parent: #2 Agent lane: Gemini 3.5 Flash Wave: 2 / board maturity Risk class: low ## Goal Prevent relation writes from replaying one idempotency key with different inputs. ## Context refs - `_bmad-output/project-context.md` follow-up fixes - `docs/agent-mcp-contract.md` ## Scope - Find link/unlink relation idempotency handling. - Add test: same key + different relation/card input fails as conflict. - Keep exact same input replay idempotent. ## Acceptance - Mismatch replay fails closed. - Same replay does not duplicate relation/audit. - Audit remains product-critical. ## Suggested checks - Targeted relation API/MCP tests. ## Non-goals / fences - Do not deploy, restart production, rotate secrets, or run production migrations. - Do not widen MCP write authority or public exposure. - Keep the change small enough for one focused PR or one scouting report. ## Expected output A short PR or issue comment with findings, touched files, tests run, and remaining risks.

codex added the

labels

2026-05-28 01:20:40 +02:00

codex referenced this issue from a commit

2026-05-29 00:20:46 +02:00

test: add idempotency mismatch conflict tests (#108)

gemini referenced this issue from a pull request that will close it,

2026-05-29 00:20:50 +02:00

test: add idempotency mismatch conflict tests (#108) #137

codex referenced this issue

2026-06-03 08:51:00 +02:00

fix(agent): salvage Gemini regression fixtures #140

Iskra commented

2026-06-14 03:09:17 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/kan-ductor#issue#108`
Priority	p2
Action	observe
Scores	reach 4 / impact 4 / confidence 5
Piotr fit	high
Effort	small
Labels	`judge/p2`
Judge	`iskra` via `openclaw`

Rationale: This is P2 safety test hardening because relation writes must fail closed on idempotency-key reuse with different inputs while preserving exact replay behavior.

Caveat: Keep the fix test-first and preserve exact same-input replay without duplicating relations or audit entries.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 5,
  "effort_hint": "small",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Issue proposes regression coverage for relation write idempotency mismatch handling.",
      "type": "forgejo",
      "value": "issue-title-body-labels-and-target-snapshot"
    },
    {
      "note": "Body requires same idempotency key with different relation or card input to fail as conflict while exact replay remains idempotent.",
      "type": "forgejo",
      "value": "issue-body-scope-and-acceptance"
    },
    {
      "note": "Body frames audit preservation as product-critical and fences the task to targeted relation API/MCP tests.",
      "type": "forgejo",
      "value": "issue-body-acceptance-and-checks"
    }
  ],
  "impact": 4,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-14T01:07:00Z",
  "labels_to_apply": [
    "judge/p2"
  ],
  "piotr_fit": "high",
  "priority": "p2",
  "rationale_summary": "This is P2 safety test hardening because relation writes must fail closed on idempotency-key reuse with different inputs while preserving exact replay behavior.",
  "reach": 4,
  "recommended_next_action": "observe",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 108,
    "repo": "pdurlej/kan-ductor"
  },
  "target_snapshot": {
    "body_hash": "sha256:3b5de1824f9d02a49ae1ab3e95e2c08e9b8feae840b67b280ad96fffb42f1ea8",
    "commit_count": null,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": null,
    "labels": [
      "api",
      "gemini-flash",
      "priority:p2",
      "safety",
      "small-task",
      "tests"
    ],
    "labels_hash": "sha256:a644b28af12fa95e8caae3e3f090ac77c28790825f50c81bfdc3e59cb2776b45",
    "state": "open",
    "title_hash": "sha256:33479ca2aaad185fd483f62ac7cbdb34720ff240e30004f054e44ce185ea1f43",
    "updated_at": "2026-06-03T08:51:00+02:00"
  },
  "top_caveat": "Keep the fix test-first and preserve exact same-input replay without duplicating relations or audit entries."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/kan-ductor#issue#108` | | Priority | p2 | | Action | observe | | Scores | reach 4 / impact 4 / confidence 5 | | Piotr fit | high | | Effort | small | | Labels | `judge/p2` | | Judge | `iskra` via `openclaw` | **Rationale:** This is P2 safety test hardening because relation writes must fail closed on idempotency-key reuse with different inputs while preserving exact replay behavior. **Caveat:** Keep the fix test-first and preserve exact same-input replay without duplicating relations or audit entries. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue proposes regression coverage for relation write idempotency mismatch handling.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body requires same idempotency key with different relation or card input to fail as conflict while exact replay remains idempotent.", "type": "forgejo", "value": "issue-body-scope-and-acceptance" }, { "note": "Body frames audit preservation as product-critical and fences the task to targeted relation API/MCP tests.", "type": "forgejo", "value": "issue-body-acceptance-and-checks" } ], "impact": 4, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-14T01:07:00Z", "labels_to_apply": [ "judge/p2" ], "piotr_fit": "high", "priority": "p2", "rationale_summary": "This is P2 safety test hardening because relation writes must fail closed on idempotency-key reuse with different inputs while preserving exact replay behavior.", "reach": 4, "recommended_next_action": "observe", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 108, "repo": "pdurlej/kan-ductor" }, "target_snapshot": { "body_hash": "sha256:3b5de1824f9d02a49ae1ab3e95e2c08e9b8feae840b67b280ad96fffb42f1ea8", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "api", "gemini-flash", "priority:p2", "safety", "small-task", "tests" ], "labels_hash": "sha256:a644b28af12fa95e8caae3e3f090ac77c28790825f50c81bfdc3e59cb2776b45", "state": "open", "title_hash": "sha256:33479ca2aaad185fd483f62ac7cbdb34720ff240e30004f054e44ce185ea1f43", "updated_at": "2026-06-03T08:51:00+02:00" }, "top_caveat": "Keep the fix test-first and preserve exact same-input replay without duplicating relations or audit entries." }  ``` </details>

Iskra added the

judge/p2

label

2026-06-14 03:09:17 +02:00