feat: add MCP ops health and smoke modes #41

Merged

pdurlej merged 1 commit from codex/mcp-ops-smoke-health into codex/ai-inbox-conventions-hardening

2026-05-10 13:47:06 +02:00

codex commented

2026-05-10 01:25:34 +02:00

Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Makes the Kan-ductor MCP operationally checkable without exposing secrets. /health now reports version/build/action/upstream status, the smoke script has independent read/write modes with explicit exit codes, and docs call out owner approval before production write smoke.

Closes #17.

Scope

Adds buildHealthPayload() and unit coverage for redaction/shape.
Extends /health with version, build SHA, transport, action status, upstream base URL, and timestamp.
Adds KAN_MCP_VERSION / KAN_MCP_BUILD_SHA support.
Adds KAN_SMOKE_MODE=read|write, KAN_MCP_HEALTH_URL, KAN_SMOKE_SKIP_HEALTH, bearer-header support, and clear smoke exit codes.
Documents read/write smoke and health checks.

Non-goals

No production smoke execution.
No production deploy automation.
No secret printing.
No monitoring stack.

Spec sources read

Issue #17 acceptance criteria
docs/agent-mcp-contract.md
docs/openclaw-kan-mcp.md
Existing scripts/kan-mcp-loop-smoke.mjs
Existing MCP /health implementation

Tests / smoke

pnpm install
pnpm --filter @kan/mcp typecheck
pnpm --filter @kan/mcp build
pnpm --filter @kan/mcp test -- src/health.test.ts
node --check scripts/kan-mcp-loop-smoke.mjs
KAN_SMOKE_MODE=nope node scripts/kan-mcp-loop-smoke.mjs; test $? -eq 2
pnpm exec prettier --check packages/mcp/src/health.ts packages/mcp/src/health.test.ts packages/mcp/src/index.ts packages/mcp/package.json scripts/kan-mcp-loop-smoke.mjs docs/openclaw-kan-mcp.md docs/agent-mcp-contract.md docs/deploy/rs2000-kan.md
git diff --check

Rollback

Revert the health payload helper and smoke script changes. No database or persistent state is involved.

Owner gates

Production write smoke remains owner-gated. This PR did not run write smoke against production.

Canary status: missing — fire 3+3 review before merge ## Summary Makes the Kan-ductor MCP operationally checkable without exposing secrets. `/health` now reports version/build/action/upstream status, the smoke script has independent read/write modes with explicit exit codes, and docs call out owner approval before production write smoke. Closes #17. ## Scope - Adds `buildHealthPayload()` and unit coverage for redaction/shape. - Extends `/health` with version, build SHA, transport, action status, upstream base URL, and timestamp. - Adds `KAN_MCP_VERSION` / `KAN_MCP_BUILD_SHA` support. - Adds `KAN_SMOKE_MODE=read|write`, `KAN_MCP_HEALTH_URL`, `KAN_SMOKE_SKIP_HEALTH`, bearer-header support, and clear smoke exit codes. - Documents read/write smoke and health checks. ## Non-goals - No production smoke execution. - No production deploy automation. - No secret printing. - No monitoring stack. ## Spec sources read - Issue #17 acceptance criteria - `docs/agent-mcp-contract.md` - `docs/openclaw-kan-mcp.md` - Existing `scripts/kan-mcp-loop-smoke.mjs` - Existing MCP `/health` implementation ## Tests / smoke - `pnpm install` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/mcp build` - `pnpm --filter @kan/mcp test -- src/health.test.ts` - `node --check scripts/kan-mcp-loop-smoke.mjs` - `KAN_SMOKE_MODE=nope node scripts/kan-mcp-loop-smoke.mjs; test $? -eq 2` - `pnpm exec prettier --check packages/mcp/src/health.ts packages/mcp/src/health.test.ts packages/mcp/src/index.ts packages/mcp/package.json scripts/kan-mcp-loop-smoke.mjs docs/openclaw-kan-mcp.md docs/agent-mcp-contract.md docs/deploy/rs2000-kan.md` - `git diff --check` ## Rollback Revert the health payload helper and smoke script changes. No database or persistent state is involved. ## Owner gates Production write smoke remains owner-gated. This PR did not run write smoke against production.

codex added 1 commit

2026-05-10 01:25:34 +02:00

feat(mcp): add ops health and smoke modes d451bf6bb2

codex commented

2026-05-10 08:48:14 +02:00

Author

Collaborator

3+3 Review Result

Status: NOT READY

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

PASS: @kan/db typecheck/build
PASS: @kan/shared typecheck/build
PASS: @kan/mcp typecheck/build
PASS: @kan/api typecheck/build and focused agent tests: 28/28
FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

Product/ops blocker: /health is positioned as ops health but can report ok without verifying upstream usability. Either make readiness honest or label endpoint as config/liveness only.

## 3+3 Review Result Status: **NOT READY** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - Product/ops blocker: /health is positioned as ops health but can report ok without verifying upstream usability. Either make readiness honest or label endpoint as config/liveness only.