feat(web): add machine activity audit view #43

Merged

pdurlej merged 1 commit from codex/web-machine-activity-audit-view into codex/openclaw-mcporter-registration

2026-05-10 13:47:25 +02:00

codex commented

2026-05-10 01:36:32 +02:00

Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Adds a protected agent.listAuditEvents read path for immutable machine/agent audit review.
Adds Settings → Agent audit with filters for identity/actor, action, source, and time range.
Shows audit ID, actor/machine identity, idempotency key, source/sourceRef, linked card, mode, input, and result without exposing internal DB IDs.

Scope

API/router read-only audit listing for human UI.
Workspace permission gate uses board:edit, matching agent proposal review.
Quiet operational UI in settings; no write controls.

Non-goals

No audit mutation, deletion, export, analytics dashboard, or production config changes.
No machine identity issuance/rotation UI in this PR.

Spec sources read

Existing agent audit repository contract in packages/db/src/repository/agent.repo.ts.
Existing proposal settings UI pattern in apps/web/src/views/settings/AgentProposalsSettings.tsx.
Kan-ductor maturity wave issue #19.

Tests / smoke

pnpm --filter @kan/api test -- agent.test.ts
pnpm --filter @kan/api typecheck
pnpm --filter @kan/api build
pnpm --filter @kan/web exec eslint src/components/SettingsLayout.tsx src/pages/settings/audit.tsx src/views/settings/AgentAuditSettings.tsx
pnpm exec prettier --check packages/api/src/routers/agent.ts packages/api/src/routers/agent.test.ts apps/web/src/components/SettingsLayout.tsx apps/web/src/pages/settings/audit.tsx apps/web/src/views/settings/AgentAuditSettings.tsx
git diff --check
Browser smoke: http://localhost:3000/settings/audit rendered the settings tab and permission state. Local API calls were blocked by missing local Postgres/pg_trgm and dev-only auth env, not by this UI.
Known baseline: pnpm --filter @kan/web typecheck still fails on existing bootstrap.cjs, public/__ENV.js, and workspace cardPrefix/role issues; no new listAuditEvents typing errors after API build.

Rollback

Revert commit cfb15e4 to remove the settings route/tab and the read-only audit API procedure.

Owner gates

Owner review before exposing audit UI broadly in production.
No production deploy or secrets touched.

Canary status: missing — fire 3+3 review before merge ## Summary - Adds a protected `agent.listAuditEvents` read path for immutable machine/agent audit review. - Adds Settings → Agent audit with filters for identity/actor, action, source, and time range. - Shows audit ID, actor/machine identity, idempotency key, source/sourceRef, linked card, mode, input, and result without exposing internal DB IDs. ## Scope - API/router read-only audit listing for human UI. - Workspace permission gate uses `board:edit`, matching agent proposal review. - Quiet operational UI in settings; no write controls. ## Non-goals - No audit mutation, deletion, export, analytics dashboard, or production config changes. - No machine identity issuance/rotation UI in this PR. ## Spec sources read - Existing agent audit repository contract in `packages/db/src/repository/agent.repo.ts`. - Existing proposal settings UI pattern in `apps/web/src/views/settings/AgentProposalsSettings.tsx`. - Kan-ductor maturity wave issue #19. ## Tests / smoke - `pnpm --filter @kan/api test -- agent.test.ts` - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/api build` - `pnpm --filter @kan/web exec eslint src/components/SettingsLayout.tsx src/pages/settings/audit.tsx src/views/settings/AgentAuditSettings.tsx` - `pnpm exec prettier --check packages/api/src/routers/agent.ts packages/api/src/routers/agent.test.ts apps/web/src/components/SettingsLayout.tsx apps/web/src/pages/settings/audit.tsx apps/web/src/views/settings/AgentAuditSettings.tsx` - `git diff --check` - Browser smoke: `http://localhost:3000/settings/audit` rendered the settings tab and permission state. Local API calls were blocked by missing local Postgres/pg_trgm and dev-only auth env, not by this UI. - Known baseline: `pnpm --filter @kan/web typecheck` still fails on existing `bootstrap.cjs`, `public/__ENV.js`, and workspace `cardPrefix/role` issues; no new `listAuditEvents` typing errors after API build. ## Rollback - Revert commit `cfb15e4` to remove the settings route/tab and the read-only audit API procedure. ## Owner gates - Owner review before exposing audit UI broadly in production. - No production deploy or secrets touched.

codex added 1 commit

2026-05-10 01:36:32 +02:00

feat(web): add agent audit settings view cfb15e41d7

codex commented

2026-05-10 08:48:14 +02:00

Author

Collaborator

3+3 Review Result

Status: NOT READY / OWNER CHECKPOINT

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

PASS: @kan/db typecheck/build
PASS: @kan/shared typecheck/build
PASS: @kan/mcp typecheck/build
PASS: @kan/api typecheck/build and focused agent tests: 28/28
FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

Product/security blocker: audit view is developer-useful but exposes raw input/result JSON and lacks incident-grade summaries/copy/export/pagination. Either improve it or explicitly gate/label as maintainer debug view.

## 3+3 Review Result Status: **NOT READY / OWNER CHECKPOINT** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - Product/security blocker: audit view is developer-useful but exposes raw input/result JSON and lacks incident-grade summaries/copy/export/pagination. Either improve it or explicitly gate/label as maintainer debug view.