bug(analytics): flow metrics ignore since/window when retrieving transitions (transitionLimit exhaustion) #57

New issue

Open

opened 2026-05-10 14:20:01 +02:00 by pdurlej · 1 comment

pdurlej commented

2026-05-10 14:20:01 +02:00

Owner

Source

3+3 review on PR #46 (feat(analytics): add flow metrics v0), merged 2026-05-10 via chain drain #52.

"flow metrics ignore the requested since/window while retrieving transitions; old ascending history can exhaust transitionLimit and omit current-window completions. Fetch/window transitions correctly before computing metrics."

Problem

Flow metrics computation (lead time, cycle time, throughput) currently fetches transition history without applying the since/window filter at fetch time. Instead it fetches up to transitionLimit ascending and only filters in memory.

For boards with long history:

transitionLimit is exhausted by old transitions
Current-window completions are missing from input
Metrics return wrong/empty values for recent windows

Scope

Apply since/until filters at the database/repository fetch layer, not in-memory
Confirm behavior with fixture: long history + recent window → metrics see only recent transitions
Add edge-case tests: empty window, window straddling old + recent, transitionLimit exceeded

Acceptance criteria

Flow metrics for "last 7 days" return correct numbers regardless of total board history
transitionLimit no longer affects window correctness, only acts as safety cap
Test asserts metrics for fixture board with 1000+ historic transitions + 5 recent

Refs

PR #46 (chain drain via #52)
Issue #22 (closed as resolved-by-#46)
3+3 review comment id 3194

## Source 3+3 review on PR #46 (`feat(analytics): add flow metrics v0`), merged 2026-05-10 via chain drain #52. > "flow metrics ignore the requested since/window while retrieving transitions; old ascending history can exhaust transitionLimit and omit current-window completions. Fetch/window transitions correctly before computing metrics." ## Problem Flow metrics computation (lead time, cycle time, throughput) currently fetches transition history **without** applying the `since`/`window` filter at fetch time. Instead it fetches up to `transitionLimit` ascending and only filters in memory. For boards with long history: - `transitionLimit` is exhausted by old transitions - Current-window completions are missing from input - Metrics return wrong/empty values for recent windows ## Scope - Apply `since`/`until` filters at the database/repository fetch layer, not in-memory - Confirm behavior with fixture: long history + recent window → metrics see only recent transitions - Add edge-case tests: empty window, window straddling old + recent, `transitionLimit` exceeded ## Acceptance criteria - Flow metrics for "last 7 days" return correct numbers regardless of total board history - `transitionLimit` no longer affects window correctness, only acts as safety cap - Test asserts metrics for fixture board with 1000+ historic transitions + 5 recent ## Refs - PR #46 (chain drain via #52) - Issue #22 (closed as resolved-by-#46) - 3+3 review comment id 3194

pdurlej added the

priority:p1

3plus3-followup

labels

2026-05-10 14:20:01 +02:00

codex referenced this issue

2026-05-28 01:20:42 +02:00

gemini(w4): long-history flow metrics window fixture #122

Iskra commented

2026-06-09 03:10:11 +02:00

Collaborator

{
"confidence": 5,
"effort_hint": "medium",
"escalation": {
"kind": "none",
"reason": ""
},
"evidence_refs": [
{
"note": "Issue reports flow metrics ignoring since or window filters when retrieving transitions.",
"type": "forgejo",
"value": "issue-title-body-labels-and-target-snapshot"
},
{
"note": "Body states old ascending history can exhaust transitionLimit and omit current-window completions.",
"type": "forgejo",
"value": "issue-body-problem"
},
{
"note": "Scope applies since and until filters at the database fetch layer and adds long-history recent-window fixtures.",
"type": "forgejo",
"value": "issue-body-scope"
}
],
"impact": 4,
"judge_actor": {
"name": "iskra",
"runtime": "openclaw"
},
"judged_at": "2026-06-09T01:08:00Z",
"labels_to_apply": [
"judge/p1",
"judge/codex-candidate"
],
"piotr_fit": "high",
"priority": "p1",
"rationale_summary": "This is P1 Codex-ready analytics correctness work because recent-window flow metrics can be silently wrong when old history exhausts the transition limit.",
"reach": 4,
"recommended_next_action": "codex_candidate",
"rerun_reason": "no_prior_judgment",
"schema": "openclaw.judge.v0",
"target": {
"kind": "issue",
"number": 57,
"repo": "pdurlej/kan-ductor"
},
"target_snapshot": {
"body_hash": "sha256:35f96e36ca2f745b190c2e3af45a09571e3b5b4b3ceebbd32d3aa3d41b0c4a60",
"commit_count": null,
"evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
"head_sha": null,
"labels": [
"3plus3-followup",
"priority:p1"
],
"labels_hash": "sha256:eae246ad0747d73dd2fb96aea169d7d74574e5b2de03312edce7ec9f6d87a8f0",
"state": "open",
"title_hash": "sha256:6d6c3c12ad1180e459ab42457bfe6799a55ca904297825203d83c5dc1aef574f",
"updated_at": "2026-05-28T01:20:42+02:00"
},
"top_caveat": "Keep the fix focused on fetch-window correctness and regression coverage, not broader analytics redesign."
}

{ "confidence": 5, "effort_hint": "medium", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue reports flow metrics ignoring since or window filters when retrieving transitions.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body states old ascending history can exhaust transitionLimit and omit current-window completions.", "type": "forgejo", "value": "issue-body-problem" }, { "note": "Scope applies since and until filters at the database fetch layer and adds long-history recent-window fixtures.", "type": "forgejo", "value": "issue-body-scope" } ], "impact": 4, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-09T01:08:00Z", "labels_to_apply": [ "judge/p1", "judge/codex-candidate" ], "piotr_fit": "high", "priority": "p1", "rationale_summary": "This is P1 Codex-ready analytics correctness work because recent-window flow metrics can be silently wrong when old history exhausts the transition limit.", "reach": 4, "recommended_next_action": "codex_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 57, "repo": "pdurlej/kan-ductor" }, "target_snapshot": { "body_hash": "sha256:35f96e36ca2f745b190c2e3af45a09571e3b5b4b3ceebbd32d3aa3d41b0c4a60", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "3plus3-followup", "priority:p1" ], "labels_hash": "sha256:eae246ad0747d73dd2fb96aea169d7d74574e5b2de03312edce7ec9f6d87a8f0", "state": "open", "title_hash": "sha256:6d6c3c12ad1180e459ab42457bfe6799a55ca904297825203d83c5dc1aef574f", "updated_at": "2026-05-28T01:20:42+02:00" }, "top_caveat": "Keep the fix focused on fetch-window correctness and regression coverage, not broader analytics redesign." }

Iskra added the

judge/codex-candidate

judge/p1

labels

2026-06-09 03:10:12 +02:00

Iskra referenced this issue from pdurlej/judging-claw

2026-06-09 03:10:12 +02:00

[Judging Claw] codex_candidate for pdurlej/kan-ductor#57 (p1) #76