agent/proposal-review-api-complete #8

New issue

Closed

opened 2026-05-09 23:23:33 +02:00 by codex · 1 comment

codex commented

2026-05-09 23:23:33 +02:00

Collaborator

Parent: #2
Wave: 1 Maintainer Foundation

Summary

Make proposal-first complete and reliable at API level.

Scope

Add or verify list/get proposal endpoints.
Add audit events for approve/reject decisions.
Ensure apply_approved_update is idempotent.
Prevent applying rejected or already applied proposals.
Preserve action preview for UI.

Non-goals

No proposal UI in this PR; see #9.
No broad bulk mutation.
No archive/delete proposals until separately approved.

Acceptance

Iskra can propose a board update.
Piotr can approve/reject through API.
Approved proposal applies semantically once.
All transitions are audited.

Tests / smoke

Router tests for create/list/get/approve/reject/apply.
Idempotency tests for apply.

Rollback

git revert <PR-commit>; migration-specific rollback if schema changes.

Owner gates

DB migration approval if schema changes.

Parent: #2 Wave: 1 Maintainer Foundation ## Summary Make proposal-first complete and reliable at API level. ## Scope - Add or verify list/get proposal endpoints. - Add audit events for approve/reject decisions. - Ensure `apply_approved_update` is idempotent. - Prevent applying rejected or already applied proposals. - Preserve action preview for UI. ## Non-goals - No proposal UI in this PR; see #9. - No broad bulk mutation. - No archive/delete proposals until separately approved. ## Acceptance - Iskra can propose a board update. - Piotr can approve/reject through API. - Approved proposal applies semantically once. - All transitions are audited. ## Tests / smoke - Router tests for create/list/get/approve/reject/apply. - Idempotency tests for apply. ## Rollback - `git revert <PR-commit>`; migration-specific rollback if schema changes. ## Owner gates - DB migration approval if schema changes.

codex referenced this issue

2026-05-09 23:24:41 +02:00

web/agent-proposals-inbox #9

codex referenced this issue

2026-05-09 23:27:13 +02:00

[meta] Kan-ductor maturity waves #2

codex referenced this issue from a pull request that will close it,

2026-05-10 00:11:36 +02:00

feat(agent): complete proposal review api #32

codex commented

2026-05-10 00:11:52 +02:00

Author

Collaborator

Opened PR #32: #32

Implemented the proposal review API slice:

listProposals and getProposal for human-authenticated review
proposal-mode audit events for approve/reject
idempotent replay for applyApprovedUpdate
scope checks before idempotency replay
repository proposal listing
contract docs update

Validation run:

pnpm --filter @kan/db build
pnpm --filter @kan/db typecheck
pnpm --filter @kan/api typecheck
pnpm --filter @kan/mcp typecheck
pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts
pnpm exec prettier --check packages/db/src/repository/agent.repo.ts packages/api/src/routers/agent.ts packages/api/src/routers/agent.test.ts packages/api/integration-tests/agent.integration.test.ts docs/agent-mcp-contract.md
git diff --check

No schema migration, no production deploy.

Opened PR #32: https://git.pdurlej.com/pdurlej/kan-ductor/pulls/32 Implemented the proposal review API slice: - `listProposals` and `getProposal` for human-authenticated review - proposal-mode audit events for approve/reject - idempotent replay for `applyApprovedUpdate` - scope checks before idempotency replay - repository proposal listing - contract docs update Validation run: - `pnpm --filter @kan/db build` - `pnpm --filter @kan/db typecheck` - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts` - `pnpm exec prettier --check packages/db/src/repository/agent.repo.ts packages/api/src/routers/agent.ts packages/api/src/routers/agent.test.ts packages/api/integration-tests/agent.integration.test.ts docs/agent-mcp-contract.md` - `git diff --check` No schema migration, no production deploy.