fix(modules): align mirotalk-admin health with container check #259

Merged

pdurlej merged 1 commit from codex/cutover/mirotalk-admin-health-contract into main

2026-05-13 18:27:14 +02:00

codex commented

2026-05-13 09:03:07 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Canary Context Pack

Product story

F1.5 corrected target mirotalk-admin is stateless, but its manifest pointed smoke at a stale Tailnet HTTP /health endpoint. The container already has a real healthcheck. This PR aligns the manifest with the reliable health source before no-op smoke.

What changed

Replaces health.http for mirotalk-admin with health.compose.required_healthy: [mirotalk-admin].
Updates one acceptance criterion to refer to container healthcheck instead of external /health.
No runtime, exposure, image, statefulness, dependency, or secret fields changed.

Why it changed

Pre-smoke checks showed:

home-platform-mirotalk-admin-1 is running and healthy.
Container healthcheck probes http://127.0.0.1:<ADMIN_PORT>/admin.
https://admin.call.pdurlej.com/health returned 403 from RS2000 and 404 locally, so workflow smoke would fail on a stale URL rather than actual runtime health.

Files touched

modules/mirotalk-admin/module.yaml

Relevant context

Issue #142 cutover lane
Pan Herbatka F1.5 correction: mirotalk-admin is a verified stateless target
Prior dashboard health-contract fix in PR #256

Runtime evidence

Read-only checks only:

docker inspect home-platform-mirotalk-admin-1 reported status=running health=healthy.
Docker healthcheck is the active runtime health source.

Known constraints

This PR does not change the Tailnet exposure model or the docker.sock acknowledged risk.
No workflow_dispatch smoke will be claimed for mirotalk-admin until this lands on main.

Explicit out-of-scope

No production apply.
No compose changes.
No runner change.
No stateful work.

Requested decision

Merge so Codex can resume F1.5 mirotalk-admin no-op smoke.

Merge blockers

Review finds a real /health endpoint should be used instead.
Strict-v2 validation fails.

Spec sources read

modules/mirotalk-admin/module.yaml — changed manifest.
modules/mirotalk-admin/runbook.md — confirmed stateless and docker.sock risk context.
compose/apps/compose.yaml — service healthcheck and labels.
RS2000 read-only docker inspect/curl evidence — current health source.

Verification

/tmp/platformctl-test-venv/bin/python -m platformctl validate --strict-v2 modules/mirotalk-admin/module.yaml
/tmp/platformctl-test-venv/bin/pytest control-plane/platformctl/tests/test_validate.py control-plane/platformctl/tests/test_health_phase3.py -q

Result: strict-v2 validation OK; 25 passed.

Refs #142

Canary status: missing — fire canary 3+3 manually before merge ## Canary Context Pack ### Product story F1.5 corrected target `mirotalk-admin` is stateless, but its manifest pointed smoke at a stale Tailnet HTTP `/health` endpoint. The container already has a real healthcheck. This PR aligns the manifest with the reliable health source before no-op smoke. ### What changed - Replaces `health.http` for `mirotalk-admin` with `health.compose.required_healthy: [mirotalk-admin]`. - Updates one acceptance criterion to refer to container healthcheck instead of external `/health`. - No runtime, exposure, image, statefulness, dependency, or secret fields changed. ### Why it changed Pre-smoke checks showed: - `home-platform-mirotalk-admin-1` is running and healthy. - Container healthcheck probes `http://127.0.0.1:<ADMIN_PORT>/admin`. - `https://admin.call.pdurlej.com/health` returned 403 from RS2000 and 404 locally, so workflow smoke would fail on a stale URL rather than actual runtime health. ### Files touched - `modules/mirotalk-admin/module.yaml` ### Relevant context - Issue #142 cutover lane - Pan Herbatka F1.5 correction: `mirotalk-admin` is a verified stateless target - Prior dashboard health-contract fix in PR #256 ### Runtime evidence Read-only checks only: - `docker inspect home-platform-mirotalk-admin-1` reported `status=running health=healthy`. - Docker healthcheck is the active runtime health source. ### Known constraints - This PR does not change the Tailnet exposure model or the docker.sock acknowledged risk. - No workflow_dispatch smoke will be claimed for `mirotalk-admin` until this lands on `main`. ### Explicit out-of-scope - No production apply. - No compose changes. - No runner change. - No stateful work. ### Requested decision Merge so Codex can resume F1.5 `mirotalk-admin` no-op smoke. ### Merge blockers - Review finds a real `/health` endpoint should be used instead. - Strict-v2 validation fails. ## Spec sources read - `modules/mirotalk-admin/module.yaml` — changed manifest. - `modules/mirotalk-admin/runbook.md` — confirmed stateless and docker.sock risk context. - `compose/apps/compose.yaml` — service healthcheck and labels. - RS2000 read-only docker inspect/curl evidence — current health source. ## Verification ```bash /tmp/platformctl-test-venv/bin/python -m platformctl validate --strict-v2 modules/mirotalk-admin/module.yaml /tmp/platformctl-test-venv/bin/pytest control-plane/platformctl/tests/test_validate.py control-plane/platformctl/tests/test_health_phase3.py -q ``` Result: strict-v2 validation OK; 25 passed. Refs #142

codex added 1 commit

2026-05-13 09:03:07 +02:00

fix(modules): align mirotalk-admin health with container check

canary-required / collect-diff (pull_request) Successful in 3s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 20s

Details

canary-required / canary (pull_request) Successful in 13s

Details

base-is-main / guard (pull_request) Successful in 2s

Details

cbfb0176b2