patchwarden-client-dry-run.yml: add `labeled` + `ready_for_review` to workflow triggers #530

New issue

Closed

opened 2026-05-28 00:05:38 +02:00 by claude · 0 comments

claude commented

2026-05-28 00:05:38 +02:00

Collaborator

Context

.forgejo/workflows/patchwarden-client-dry-run.yml currently triggers on:

on:
  pull_request:
    types: [opened, synchronize, reopened]

Per the W6d calibration playbook (docs/operations/platform-dogfood.md in pdurlej/patchwarden), the dogfood flow is:

Open PR (often as draft / WIP)
Apply W6d-automerge-calibration label
Mark ready for review
Workflow runs → Patchwarden comment → Iskra review → operator merges

But because the workflow doesn't trigger on labeled or ready_for_review, steps 2 and 3 silently don't fire the workflow. The only ways to actually run the workflow are: (a) the initial opened event (which fires on a draft, often when env/canary isn't ready), or (b) push an empty commit (synchronize).

I worked around this in #527 by pushing empty commits — observable as the chore: re-trigger ... commits on the PR branch. Not nice.

Proposed fix

 on:
   pull_request:
-    types: [opened, synchronize, reopened]
+    types: [opened, synchronize, reopened, labeled, ready_for_review]

Plus consider a label-name filter to avoid running on every label change:

jobs:
  collect-diff:
    if: >
      github.event.action != 'labeled' ||
      github.event.label.name == 'W6d-automerge-calibration'

(The ready_for_review event always means "this PR is now real" — no filter needed.)

Out of scope

canary-required.yml and other workflows — same pattern may apply, but each should be evaluated separately.

Validation

After the change: apply / remove W6d-automerge-calibration on an existing draft PR, mark ready for review on a different draft. Expect patchwarden-client-dry-run to fire on each.

Refs: pdurlej/platform#524 #527

## Context `.forgejo/workflows/patchwarden-client-dry-run.yml` currently triggers on: ```yaml on: pull_request: types: [opened, synchronize, reopened] ``` Per the W6d calibration playbook (`docs/operations/platform-dogfood.md` in `pdurlej/patchwarden`), the dogfood flow is: 1. Open PR (often as draft / WIP) 2. Apply `W6d-automerge-calibration` label 3. Mark ready for review 4. Workflow runs → Patchwarden comment → Iskra review → operator merges But because the workflow doesn't trigger on `labeled` or `ready_for_review`, **steps 2 and 3 silently don't fire the workflow**. The only ways to actually run the workflow are: (a) the initial `opened` event (which fires on a draft, often when env/canary isn't ready), or (b) push an empty commit (`synchronize`). I worked around this in `#527` by pushing empty commits — observable as the `chore: re-trigger ...` commits on the PR branch. Not nice. ## Proposed fix ```diff on: pull_request: - types: [opened, synchronize, reopened] + types: [opened, synchronize, reopened, labeled, ready_for_review] ``` Plus consider a label-name filter to avoid running on every label change: ```yaml jobs: collect-diff: if: > github.event.action != 'labeled' || github.event.label.name == 'W6d-automerge-calibration' ``` (The `ready_for_review` event always means "this PR is now real" — no filter needed.) ## Out of scope - `canary-required.yml` and other workflows — same pattern may apply, but each should be evaluated separately. ## Validation After the change: apply / remove `W6d-automerge-calibration` on an existing draft PR, mark ready for review on a different draft. Expect `patchwarden-client-dry-run` to fire on each. Refs: `pdurlej/platform#524 #527`

claude added the

ready-for-agent

tier/lite

labels

2026-05-28 00:05:38 +02:00