feat(apply): add sandbox apply receipt mode #694

Merged

pdurlej merged 4 commits from codex/687-apply-sandbox into main 2026-06-02 14:41:25 +02:00

Conversation 3 Commits 4 Files changed 4 +207 -1

codex commented 2026-06-02 14:01:24 +02:00

Collaborator

Copy link

Canary status: missing — Forgejo PR checks must run before merge.

Summary

Implements #687 slice 2: platformctl apply --sandbox as a Tier-1 sandbox receipt mode.

• Adds a non-mutating sandbox=True path to apply_plan.
• Adds CLI platformctl apply --sandbox.
• Emits a platformctl.apply.sandbox.v0 receipt and status artifact.
• Keeps live preview-slot wiring operator-gated and executes no remote commands.

Canary Context Pack

Product story

Agents need a reversible runtime lane between read-only plan and operator-gated live apply. This PR adds the auditable skeleton for that lane without weakening existing production gates.

What changed

apply --sandbox now validates the same approved plan path, constructs a sandbox receipt for a hermes-preview-slot style target, writes status evidence, and stops before transport/runtime execution.

Why it changed

#687 requires a Tier-1 runtime sandbox mechanism before classifier/receipt layers can safely route runtime-ish actions away from direct operator interruption.

Files touched

• control-plane/platformctl/apply.py
• control-plane/platformctl/cli.py
• control-plane/platformctl/tests/test_apply_phase3.py
• control-plane/platformctl/tests/test_apply_env_file.py

Relevant context

• #687 tiered execution implementation
• #673 / PR #686 autonomy design
• state/strategy/autonomy-tiered-execution-design-2026-06-02.md

Runtime evidence

No runtime mutation and no remote transport calls are made by this PR. Tests assert the sandbox path does not call the transport and does not require PLATFORMCTL_PHASE=05.

Known constraints

Live preview-slot creation, healthcheck execution, discard, and deploy wiring remain operator-gated future work.

Explicit out-of-scope

No classifier model, no live sandbox runtime, no production apply, no DB migration, no issue writer, no memory-plane persistence beyond the local event/status payload.

Requested decision

Approve this as the apply-sandbox skeleton slice; continue #687 with classifier/policy compiler next.

Merge blockers

Any failed apply tests, any remote runtime execution in sandbox mode, or any weakening of existing approval/break-glass gates.

Spec sources read

• state/strategy/autonomy-tiered-execution-design-2026-06-02.md — sandbox mechanism contract
• control-plane/platformctl/apply.py — apply gates/status artifact path
• control-plane/platformctl/cli.py — CLI option registration
• control-plane/platformctl/tests/test_apply_phase3.py — apply gate tests
• control-plane/platformctl/tests/test_apply_env_file.py — CLI apply tests

Validation

• PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py — 119 passed
• PYTHONPATH=control-plane python3 -m platformctl.cli validate all --json — exitCode 0

Refs #687

Canary status: missing — Forgejo PR checks must run before merge. ## Summary Implements #687 slice 2: `platformctl apply --sandbox` as a Tier-1 sandbox receipt mode. - Adds a non-mutating `sandbox=True` path to `apply_plan`. - Adds CLI `platformctl apply --sandbox`. - Emits a `platformctl.apply.sandbox.v0` receipt and status artifact. - Keeps live preview-slot wiring operator-gated and executes no remote commands. ## Canary Context Pack ### Product story Agents need a reversible runtime lane between read-only plan and operator-gated live apply. This PR adds the auditable skeleton for that lane without weakening existing production gates. ### What changed `apply --sandbox` now validates the same approved plan path, constructs a sandbox receipt for a hermes-preview-slot style target, writes status evidence, and stops before transport/runtime execution. ### Why it changed #687 requires a Tier-1 runtime sandbox mechanism before classifier/receipt layers can safely route runtime-ish actions away from direct operator interruption. ### Files touched - `control-plane/platformctl/apply.py` - `control-plane/platformctl/cli.py` - `control-plane/platformctl/tests/test_apply_phase3.py` - `control-plane/platformctl/tests/test_apply_env_file.py` ### Relevant context - #687 tiered execution implementation - #673 / PR #686 autonomy design - `state/strategy/autonomy-tiered-execution-design-2026-06-02.md` ### Runtime evidence No runtime mutation and no remote transport calls are made by this PR. Tests assert the sandbox path does not call the transport and does not require `PLATFORMCTL_PHASE=05`. ### Known constraints Live preview-slot creation, healthcheck execution, discard, and deploy wiring remain operator-gated future work. ### Explicit out-of-scope No classifier model, no live sandbox runtime, no production apply, no DB migration, no issue writer, no memory-plane persistence beyond the local event/status payload. ### Requested decision Approve this as the apply-sandbox skeleton slice; continue #687 with classifier/policy compiler next. ### Merge blockers Any failed apply tests, any remote runtime execution in sandbox mode, or any weakening of existing approval/break-glass gates. ## Spec sources read - `state/strategy/autonomy-tiered-execution-design-2026-06-02.md` — sandbox mechanism contract - `control-plane/platformctl/apply.py` — apply gates/status artifact path - `control-plane/platformctl/cli.py` — CLI option registration - `control-plane/platformctl/tests/test_apply_phase3.py` — apply gate tests - `control-plane/platformctl/tests/test_apply_env_file.py` — CLI apply tests ## Validation - `PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py` — 119 passed - `PYTHONPATH=control-plane python3 -m platformctl.cli validate all --json` — exitCode 0 Refs #687

codex added 1 commit 2026-06-02 14:01:25 +02:00

feat(apply): add sandbox apply receipt mode 817b0f3cd3

codex commented 2026-06-02 14:09:24 +02:00

Author

Collaborator

Copy link

Patchwarden PR sanity

• Status: eligible_sanity_clean
• PR: 694
• Commit: f81282f0cfa56e312978580cc28a1405fa8c7d5d
• Security-sensitive label: present
• Authority: advisory model review plus deterministic blockers only
• 3+3 canary: still alive; this does not replace it

Deterministic findings

• info sensitive-path-touched Sensitive path touched — control-plane/platformctl/apply.py
  • Evidence: control-plane/platformctl/apply.py
  • Next: Route through the existing 3+3/risk-tier process; model review remains advisory.

Model reviewers

global-glm / glm-5.1:cloud

• Status: ok

• Verdict: OK

• low Sandbox path bypasses phase gate without explicit guard

  • Evidence: In control-plane/platformctl/apply.py, the sandbox block (line 1184+) returns before 'Gate 4: phase gate' (line ~1277). Sandbox mode skips _real_apply_enabled() check entirely.
  • Next: Consider adding an explicit comment or assertion that sandbox intentionally bypasses phase gate because it performs no runtime execution, or add a defensive check that sandbox=True implies no transport calls.

global-deepseek / deepseek-v4-pro:cloud

• Status: ok
• Verdict: OK
• Findings: none

redteam / kimi-k2.6:cloud

• Status: ok
• Verdict: OK
• Findings: none

Policy notes

• GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
• Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
• Auto-merge is not enabled here.

<!-- patchwarden-pr-sanity:pdurlej/platform:PR-694 --> # Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `694` - Commit: `f81282f0cfa56e312978580cc28a1405fa8c7d5d` - Security-sensitive label: `present` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings - **`info` `sensitive-path-touched`** Sensitive path touched — `control-plane/platformctl/apply.py` - Evidence: `control-plane/platformctl/apply.py` - Next: Route through the existing 3+3/risk-tier process; model review remains advisory. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - **`low`** Sandbox path bypasses phase gate without explicit guard - Evidence: `In control-plane/platformctl/apply.py, the sandbox block (line 1184+) returns before 'Gate 4: phase gate' (line ~1277). Sandbox mode skips _real_apply_enabled() check entirely.` - Next: Consider adding an explicit comment or assertion that sandbox intentionally bypasses phase gate because it performs no runtime execution, or add a defensive check that sandbox=True implies no transport calls. ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.

codex added 1 commit 2026-06-02 14:09:51 +02:00

chore(ci): retrigger apply sandbox checks 10d90fc547

codex added 1 commit 2026-06-02 14:14:30 +02:00

chore(ci): retry apply sandbox checks 5886fbf107

codex added the

class/security-sensitive

label 2026-06-02 14:27:40 +02:00

codex added 1 commit 2026-06-02 14:28:23 +02:00

chore(ci): retrigger apply sandbox security lane f81282f0cf

pdurlej approved these changes 2026-06-02 14:39:05 +02:00

pdurlej left a comment

Copy link

Approved after class/security-sensitive label was applied and all Forgejo checks passed. Automated Codex operator-approved lane; no runtime/destructive action in this PR.

Approved after class/security-sensitive label was applied and all Forgejo checks passed. Automated Codex operator-approved lane; no runtime/destructive action in this PR.

pdurlej approved these changes 2026-06-02 14:41:00 +02:00

pdurlej left a comment

Copy link

Approved after class/security-sensitive label was applied and all Forgejo checks passed. Automated Codex operator-approved lane; no runtime/destructive action in this PR.

Approved after class/security-sensitive label was applied and all Forgejo checks passed. Automated Codex operator-approved lane; no runtime/destructive action in this PR.

pdurlej merged commit b08f3c8dbb into main 2026-06-02 14:41:25 +02:00

pdurlej referenced this pull request from a commit 2026-06-02 14:41:27 +02:00

Merge pull request #694 from codex/687-apply-sandbox

codex referenced this pull request 2026-06-02 14:47:31 +02:00

feat(autonomy): add fail-closed classifier gate #695

codex referenced this pull request 2026-06-02 15:24:53 +02:00

feat(autonomy): write decision receipts #696

Sign in to join this conversation.

Reviewers

No reviewers

pdurlej

Labels

Clear labels   

W6d-automerge-calibration

  

agent/claude-code

Vistula actor: Claude Code.

  

agent/codex

Vistula actor: Codex.

  

agent/hermes

Vistula actor: Hermes Upstream.

  

agent/iskra

Vistula actor: Iskra.

  

agent/ollama

Vistula actor: Ollama or compatible model.

  

agent/patchwarden

Vistula actor: Patchwarden.

  

automerge-candidate

Candidate for narrow W6d autonomous merge readiness pilot

  

class/security-sensitive

Security-sensitive class of service: smallest coherent PRs and full canary

  

cutover-gate

blocks production declare / final RS2000 replacement

  

dependency/blocked

Vistula dependency state: blocked.

  

dependency/blocks-others

Vistula dependency state: blocks other work.

  

dependency/cross-repo

Vistula dependency scope: cross-repository.

  

dependency/needs-confirmation

Vistula dependency state: needs confirmation.

  

domain:agents

Agent identity, delegation, subagents, routing, or workflows.

  

domain:ci

CI, checks, Actions, runners, or release automation.

  

domain:docs

Documentation, packets, practices, or source-of-truth text.

  

domain:forgejo

Forgejo issues, PRs, labels, repo settings, or identity.

  

domain:infra

Infrastructure, storage, backup, DNS, network, or host substrate.

  

domain:memory

Memory, recall, write gates, salience, or Honcho-adjacent behavior.

  

domain:runtime

Runtime services, deploys, daemons, timers, or live behavior.

  

domain:signal

Signal UX, delivery, context, or outbound behavior.

  

domain:ux

Product UX, operator experience, or conversation ergonomics.

  

flow/architecture

Vistula lifecycle: architecture phase in progress.

  

flow/blocked

Vistula lifecycle: blocked on dependency or decision.

  

flow/deployed

Vistula lifecycle: deployed to runtime where applicable.

  

flow/done

Vistula lifecycle: work merged or otherwise done.

  

flow/implementation

Vistula lifecycle: implementation phase in progress.

  

flow/intake

Vistula lifecycle: incoming signal not refined yet.

  

flow/maintained

Vistula lifecycle: maintained/steady state.

  

flow/observed

Vistula lifecycle: observed after delivery.

  

flow/ready

Vistula lifecycle: ready for architecture or implementation.

  

flow/refining

Vistula lifecycle: Hermes/spec refinement in progress.

  

flow/retired

Vistula lifecycle: retired or intentionally closed.

  

flow/review

Vistula lifecycle: review phase in progress.

  

iterating

Orchestrator/Codex actively amending in response to review — operator can ignore until resolved

  

judge/codex-candidate

Candidate for Codex implementation.

  

judge/hermes-candidate

Candidate for Hermes discovery/research.

  

judge/low-confidence

Judgment confidence is low.

  

judge/needs-refinement

Needs clearer evidence or scope.

  

judge/operator-needed

Needs Piotr decision or input.

  

judge/p0

Urgent, operator attention or unblock now.

  

judge/p1

High value, schedule soon.

  

judge/p2

Useful, normal queue.

  

judge/p3

Low priority, keep but do not chase.

  

judge/park

Parked from current attention.

  

judge/patchwarden-candidate

Needs Patchwarden merge-safety attention.

  

judge/stale-priority

Existing priority judgment appears stale.

  

kind/adr

Vistula work kind: architecture decision record.

  

kind/bug

Vistula work kind: bug fix.

  

kind/chore

Vistula work kind: chore.

  

kind/feature

Vistula work kind: feature.

  

kind/infra

Vistula work kind: infrastructure.

  

kind/ops

Vistula work kind: operations.

  

kind/refactor

Vistula work kind: refactor.

  

kind/research

Vistula work kind: research/discovery.

  

large-impact

Per charter §3 review-by-impact: large impact (≥300 LOC OR new module OR identity/secret change OR architectural pivot) — Oracle pre-review recommended

  

merge/auto

Vistula merge mode: automated merge.

  

merge/manual

Vistula merge mode: manual merge.

  

merge/manual-dependency-conflict

Manual merge reason: dependency conflict.

  

merge/manual-failing-tests

Manual merge reason: failing tests.

  

merge/manual-merge-conflict

Manual merge reason: merge conflict.

  

merge/manual-missing-review

Manual merge reason: missing review.

  

merge/manual-operator-preference

Manual merge reason: operator preference.

  

merge/manual-red-zone

Manual merge reason: red-zone risk.

  

merge/manual-security-sensitive

Manual merge reason: security-sensitive work.

  

merge/manual-unclear-scope

Manual merge reason: unclear scope.

  

merge/manual-unknown

Manual merge reason: unknown.

  

meta

meta-decomposition issue; first agent decomposes into atomic children

  

mode:operator-only

Apply step requires explicit operator approval.

  

mode:patchwarden-iskra-approved

Work eligible for Patchwarden/Iskra approval inside repo policy.

  

mode:safe-auto

Low-risk work eligible for lightweight autonomous handling.

  

needs-operator-decision

PR is blocked on operator yes/no decision — fresh-Claude/Codex won't make this call alone

  

needs-triage

decomposing agent has open questions / unknowns

  

not-ready

reviewed but blocked on a precondition

  

observed/erroring

Vistula observation: erroring.

  

observed/needs-followup

Vistula observation: needs follow-up.

  

observed/pending

Vistula observation: pending.

  

observed/retire-candidate

Vistula observation: retire candidate.

  

observed/unused

Vistula observation: unused.

  

observed/used

Vistula observation: used.

  

operator-emotional

operator-emotional importance (Iskra memory etc.)

  

owner-attention

owner must decide; blocks default path

  

phase/02

Phase 02 cataloging

  

phase/03

Phase 03 control plane (platformctl)

  

priority:p0

Immediate safety, uptime, data, or operator-blocking issue.

  

priority:p1

Important active work; should be pulled soon.

  

priority:p2

Useful normal-priority work.

  

priority:p3

Opportunistic cleanup, research, or backlog work.

  

proposed

auto-generated by meta-decomposition; awaiting human review

  

ready-for-agent

reviewed and pickable; agents may claim per cookbook

  

ready-for-operator

PR is ready for operator review/merge — orchestrator finished its part

  

recovery

disaster recovery / restore semantics relevant

  

review:claude-reviewed

Reviewed by Claude-family agent.

  

review:codex-reviewed

Reviewed by Codex-family agent.

  

review:dziadek-reviewed

Reviewed by Dziadek pinch-point reviewer.

  

review:needs-human

Needs human review before merge or apply.

  

risk/exposure

incorrectly public/private/tailnet/auth/routed

  

risk/process

workflow/review/orchestration may produce bad outcomes

  

risk/product

work may have lost owner/user value

  

risk/runtime

platform may not run, recover, validate, behave reproducibly

  

safety:external-write

May write to external systems, users, rooms, repos, or services.

  

safety:no-prod-mutation

Must not mutate production or live external state.

  

safety:prod-impact

May affect production/runtime behavior.

  

safety:secret-touch

Touches secrets, credentials, auth, or secret-adjacent config.

  

size/large

Vistula size: large.

  

size/medium

Vistula size: medium.

  

size/small

Vistula size: small.

  

size/tiny

Vistula size: tiny.

  

size/unknown

Vistula size: not classified yet.

  

source/adr

Vistula source: ADR.

  

source/agent-generated

Vistula source: agent generated.

  

source/manual

Vistula source: manual entry.

  

source/operator-chat

Vistula source: operator chat.

  

source/voice-note

Vistula source: voice note.

  

status:blocked

Blocked by missing dependency, evidence, access, or operator decision.

  

status:codex-ready

Ready for a Codex implementation pass.

  

status:merged:pending-evidence

Merged but waiting for live or artifact evidence before closure.

  

status:needs-evidence

Needs proof, logs, tests, or operator-visible evidence.

  

status:operator-needed

Requires explicit operator input before safe progress.

  

status:parked

Intentionally deferred; not active campaign work.

  

tier/full

Full review tier per ADR-0007

  

tier/lite

Lite review tier per ADR-0007

  

tier/stacked

Stacked PR (base != main) escape hatch per ADR-0017. Requires consolidator-PR plan in PR body.

  

tier:0-platform-substrate

Data, secrets, backup, storage, or critical platform substrate.

  

tier:1-iskra-value-layer

Iskra/OpenClaw behavior, memory, runtime, or value-layer work.

  

tier:2-tools-products-modules

Tools, products, modules, experiments, and lower-blast-radius work.

  

type:bug

Incorrect behavior or regression.

  

type:chore

Maintenance, cleanup, metadata, or operational task.

  

type:docs

Documentation-only work.

  

type:feat

New capability or product behavior.

  

type:policy

Governance, protocol, boundary, or decision-contract change.

  

type:research

Investigation, spike, or evidence-gathering task.

No labels

W6d-automerge-calibration

agent/claude-code

agent/codex

agent/hermes

agent/iskra

agent/ollama

agent/patchwarden

automerge-candidate

class/security-sensitive

cutover-gate

dependency/blocked

dependency/blocks-others

dependency/cross-repo

dependency/needs-confirmation

domain:agents

domain:ci

domain:docs

domain:forgejo

domain:infra

domain:memory

domain:runtime

domain:signal

domain:ux

flow/architecture

flow/blocked

flow/deployed

flow/done

flow/implementation

flow/intake

flow/maintained

flow/observed

flow/ready

flow/refining

flow/retired

flow/review

iterating

judge/codex-candidate

judge/hermes-candidate

judge/low-confidence

judge/needs-refinement

judge/operator-needed

judge/p0

judge/p1

judge/p2

judge/p3

judge/park

judge/patchwarden-candidate

judge/stale-priority

kind/adr

kind/bug

kind/chore

kind/feature

kind/infra

kind/ops

kind/refactor

kind/research

large-impact

merge/auto

merge/manual

merge/manual-dependency-conflict

merge/manual-failing-tests

merge/manual-merge-conflict

merge/manual-missing-review

merge/manual-operator-preference

merge/manual-red-zone

merge/manual-security-sensitive

merge/manual-unclear-scope

merge/manual-unknown

meta

mode:operator-only

mode:patchwarden-iskra-approved

mode:safe-auto

needs-operator-decision

needs-triage

not-ready

observed/erroring

observed/needs-followup

observed/pending

observed/retire-candidate

observed/unused

observed/used

operator-emotional

owner-attention

phase/02

phase/03

priority:p0

priority:p1

priority:p2

priority:p3

proposed

ready-for-agent

ready-for-operator

recovery

review:claude-reviewed

review:codex-reviewed

review:dziadek-reviewed

review:needs-human

risk/exposure

risk/process

risk/product

risk/runtime

safety:external-write

safety:no-prod-mutation

safety:prod-impact

safety:secret-touch

size/large

size/medium

size/small

size/tiny

size/unknown

source/adr

source/agent-generated

source/manual

source/operator-chat

source/voice-note

status:blocked

status:codex-ready

status:merged:pending-evidence

status:needs-evidence

status:operator-needed

status:parked

tier/full

tier/lite

tier/stacked

tier:0-platform-substrate

tier:1-iskra-value-layer

tier:2-tools-products-modules

type:bug

type:chore

type:docs

type:feat

type:policy

type:research

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pdurlej/platform!694

No description provided.