pdurlej/platform

Fork 0

feat(things): add status and doctor runtime truth #740

Merged

pdurlej merged 1 commit from codex/things-wave-3-status-doctor into main

2026-06-07 16:59:15 +02:00

codex commented

2026-06-07 16:50:35 +02:00

Collaborator

Summary

add status-json for fast local runtime truth about the Things bridge
add doctor-json with an optional tiny read-only live Things Cloud probe
record latest read/proposal/preview/apply/result runtime state so Piotr and Iskra have one status surface
document status/doctor usage in the bridge docs, OpenClaw skill, and VPS1000 wrapper help

BMADX wave

Wave 3 - Status / Doctor / Runtime Truth.

Verification

pytest -q tests/test_iskra_things_sync_contract.py
python3 -m py_compile scripts/iskra-things-sync/iskra_things_sync.py
bash -n scripts/iskra-things-sync/iskra-things-vps1000
git diff --check

What Iskra can do now

answer whether the Things bridge is healthy with iskra-things status-json
run iskra-things doctor-json for a read-only live SDK probe
distinguish live Things read health from Signal delivery and Obsidian cache state

Still cannot do

no new mutation path; writes remain behind digest-bound approvals
no Wloczykij promotion flow yet
no honest partial-search metadata or human title validator yet; that is Wave 4

## Summary - add `status-json` for fast local runtime truth about the Things bridge - add `doctor-json` with an optional tiny read-only live Things Cloud probe - record latest read/proposal/preview/apply/result runtime state so Piotr and Iskra have one status surface - document status/doctor usage in the bridge docs, OpenClaw skill, and VPS1000 wrapper help ## BMADX wave Wave 3 - Status / Doctor / Runtime Truth. ## Verification - `pytest -q tests/test_iskra_things_sync_contract.py` - `python3 -m py_compile scripts/iskra-things-sync/iskra_things_sync.py` - `bash -n scripts/iskra-things-sync/iskra-things-vps1000` - `git diff --check` ## What Iskra can do now - answer whether the Things bridge is healthy with `iskra-things status-json` - run `iskra-things doctor-json` for a read-only live SDK probe - distinguish live Things read health from Signal delivery and Obsidian cache state ## Still cannot do - no new mutation path; writes remain behind digest-bound approvals - no Wloczykij promotion flow yet - no honest partial-search metadata or human title validator yet; that is Wave 4

codex added 1 commit

2026-06-07 16:50:35 +02:00

feat(things): add status and doctor runtime truth

base-is-main / guard (pull_request) Successful in 1s

Details

canary-required / collect-diff (pull_request) Successful in 4s

Details

python-ci / Python 3.12 (pull_request) Successful in 43s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 4m18s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 3s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 3s

Details

python-ci / Python 3.11 (pull_request) Successful in 43s

Details

python-ci / Python 3.13 (pull_request) Successful in 42s

Details

canary-required / canary (pull_request) Successful in 13s

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 17s

Details

5521f85acf

patchwarden commented

2026-06-07 16:57:45 +02:00

First-time contributor

Patchwarden PR sanity

Status: advisory_findings
PR: 740
Commit: 5521f85acf05ab3e021cf067b109c1830558d533
Security-sensitive label: missing
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: ABSTAIN
medium reviewer output unparseable
- Evidence: no valid JSON object found in response
- Next: investigate provider response; possibly increase max_tokens or retry

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: OK
medium Potential state directory mismatch between write and read paths
- Evidence: scripts/iskra-things-sync/iskra_things_sync.py: try_write_runtime_statewrites tostate_dir() / name(viaruntime_state_path), while read_runtime_statereads fromconfigured_state_dir() / name. If state_dir()andconfigured_sta`
- Next: Confirm that state_dir() and configured_state_dir() are identical (both default to /state and respect ISKRA_THINGS_STATE_DIR). If they are, remove the duplicate function to avoid confusion; if not, align them to use the same directory.

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: NOT_OK
high doctor-json live probe crashes on unexpected SDK exceptions
- Evidence: scripts/iskra-things-sync/iskra_things_sync.py status_payload() wraps the live probe (collect_snapshot) in except SystemExit as exc only; any network, auth, or runtime exception from the Things SDK will propagate uncaught, causing doctor-
- Next: Change the handler to except Exception as exc: so doctor-json always emits JSON and returns exit code 2 when the live probe fails for any reason.

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `advisory_findings` - PR: `740` - Commit: `5521f85acf05ab3e021cf067b109c1830558d533` - Security-sensitive label: `missing` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `ABSTAIN` - **`medium`** reviewer output unparseable - Evidence: `no valid JSON object found in response` - Next: investigate provider response; possibly increase max_tokens or retry ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - **`medium`** Potential state directory mismatch between write and read paths - Evidence: `scripts/iskra-things-sync/iskra_things_sync.py: `try_write_runtime_state` writes to `state_dir() / name` (via `runtime_state_path`), while `read_runtime_state` reads from `configured_state_dir() / name`. If `state_dir()` and `configured_sta` - Next: Confirm that `state_dir()` and `configured_state_dir()` are identical (both default to `/state` and respect `ISKRA_THINGS_STATE_DIR`). If they are, remove the duplicate function to avoid confusion; if not, align them to use the same directory. ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `NOT_OK` - **`high`** doctor-json live probe crashes on unexpected SDK exceptions - Evidence: `scripts/iskra-things-sync/iskra_things_sync.py status_payload() wraps the live probe (collect_snapshot) in `except SystemExit as exc` only; any network, auth, or runtime exception from the Things SDK will propagate uncaught, causing doctor-` - Next: Change the handler to `except Exception as exc:` so doctor-json always emits JSON and returns exit code 2 when the live probe fails for any reason. ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.