pdurlej/platform

Fork 0

fix(manifests): tombstone vault, vault-bootstrap, np-silverbullet — remove dangling compose references #751

New issue

Closed

opened 2026-06-08 23:07:13 +02:00 by ollama · 2 comments

ollama commented

2026-06-08 23:07:13 +02:00

Collaborator

Spec sources (whitelist)

modules/vault/module.yaml — orchestrator: docker-compose, compose_service: vault
modules/vault-bootstrap/module.yaml — orchestrator: docker-compose, compose_service: vault-bootstrap
modules/np-silverbullet/module.yaml — orchestrator: docker-compose, compose_service: np-silverbullet
compose/apps/compose.yaml — verify grep=0 for vault, vault-bootstrap, np-silverbullet services
modules/teamspeak3/module.yaml — reference: already tombstoned correctly (orchestrator: external, no compose_file/compose_service)
modules/audio-mcp-legacy/module.yaml — reference: already tombstoned correctly
modules/signal-bridge-legacy/module.yaml — reference: already tombstoned correctly

Extracted context

These 3 sunset/archived modules still reference compose services that no longer exist in compose/apps/compose.yaml. Verified: grep returns 0 hits for vault, vault-bootstrap, np-silverbullet in compose/apps/compose.yaml.

Correct pattern already exists in the repo: teamspeak3, audio-mcp-legacy, signal-bridge-legacy use orchestrator: external with no compose_file/compose_service.

Scope

For each of the 3 modules (vault, vault-bootstrap, np-silverbullet):

Change runtime.orchestrator from docker-compose to external
Remove runtime.compose_file and runtime.compose_service fields

Do NOT touch any other fields. Do NOT delete the module manifests.

Acceptance criteria

All 3 manifests validate: platformctl validate all --json green
No tombstoned module references a non-existent compose service
INDEX.yaml entries for these modules still correct (no change needed — already tombstoned there)

Do NOT read

Full repo — only the files listed above

Agent notes

Recommended executor: Gemini 3.1 Pro or Gemini 3.5 Flash
Size: Small (~15 LOC across 3 files)
Review tier: tier/lite (3 reviewers per ADR-0007)
Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §A2

## Spec sources (whitelist) - `modules/vault/module.yaml` — orchestrator: docker-compose, compose_service: vault - `modules/vault-bootstrap/module.yaml` — orchestrator: docker-compose, compose_service: vault-bootstrap - `modules/np-silverbullet/module.yaml` — orchestrator: docker-compose, compose_service: np-silverbullet - `compose/apps/compose.yaml` — verify grep=0 for vault, vault-bootstrap, np-silverbullet services - `modules/teamspeak3/module.yaml` — reference: already tombstoned correctly (orchestrator: external, no compose_file/compose_service) - `modules/audio-mcp-legacy/module.yaml` — reference: already tombstoned correctly - `modules/signal-bridge-legacy/module.yaml` — reference: already tombstoned correctly ## Extracted context These 3 sunset/archived modules still reference compose services that no longer exist in `compose/apps/compose.yaml`. Verified: `grep` returns 0 hits for `vault`, `vault-bootstrap`, `np-silverbullet` in compose/apps/compose.yaml. Correct pattern already exists in the repo: `teamspeak3`, `audio-mcp-legacy`, `signal-bridge-legacy` use `orchestrator: external` with no `compose_file`/`compose_service`. ## Scope For each of the 3 modules (`vault`, `vault-bootstrap`, `np-silverbullet`): - Change `runtime.orchestrator` from `docker-compose` to `external` - Remove `runtime.compose_file` and `runtime.compose_service` fields Do NOT touch any other fields. Do NOT delete the module manifests. ## Acceptance criteria - [ ] All 3 manifests validate: `platformctl validate all --json` green - [ ] No tombstoned module references a non-existent compose service - [ ] INDEX.yaml entries for these modules still correct (no change needed — already tombstoned there) ## Do NOT read - Full repo — only the files listed above ## Agent notes - Recommended executor: Gemini 3.1 Pro or Gemini 3.5 Flash - Size: Small (~15 LOC across 3 files) - Review tier: tier/lite (3 reviewers per ADR-0007) - Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §A2

ollama referenced this issue

2026-06-08 23:09:24 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

Iskra commented

2026-06-15 03:03:24 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/platform#issue#751`
Priority	p2
Action	codex_candidate
Scores	reach 3 / impact 3 / confidence 5
Piotr fit	medium
Effort	small
Labels	`judge/p2`, `judge/codex-candidate`
Judge	`iskra` via `openclaw`

Rationale: This is P2 Codex-ready manifest hygiene because dangling compose references in archived modules can mislead inventory, dashboards, and future operators.

Caveat: Keep this as manifest-only tombstoning; do not alter live compose services or revive archived modules while cleaning references.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 5,
  "effort_hint": "small",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Issue identifies three sunset or archived module manifests with compose service references that no longer exist.",
      "type": "forgejo",
      "value": "issue-title-body-labels-and-target-snapshot"
    },
    {
      "note": "Body says compose/apps/compose.yaml has no matching vault, vault-bootstrap, or np-silverbullet services.",
      "type": "forgejo",
      "value": "issue-body-extracted-context"
    },
    {
      "note": "Body cites already tombstoned modules as the intended external-orchestrator pattern for cleanup.",
      "type": "forgejo",
      "value": "issue-body-reference-pattern"
    }
  ],
  "impact": 3,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-15T01:02:00Z",
  "labels_to_apply": [
    "judge/p2",
    "judge/codex-candidate"
  ],
  "piotr_fit": "medium",
  "priority": "p2",
  "rationale_summary": "This is P2 Codex-ready manifest hygiene because dangling compose references in archived modules can mislead inventory, dashboards, and future operators.",
  "reach": 3,
  "recommended_next_action": "codex_candidate",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 751,
    "repo": "pdurlej/platform"
  },
  "target_snapshot": {
    "body_hash": "sha256:8e48ac00ca0f4c82660a51eb0f418c166838f1fee29793f187769646462cf743",
    "commit_count": null,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": null,
    "labels": [],
    "labels_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "state": "open",
    "title_hash": "sha256:b11d72374172e06cd953b1528993d3f6db9f88f34ad2d8d9a888a694f9a04a75",
    "updated_at": "2026-06-08T23:09:24+02:00"
  },
  "top_caveat": "Keep this as manifest-only tombstoning; do not alter live compose services or revive archived modules while cleaning references."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/platform#issue#751` | | Priority | p2 | | Action | codex_candidate | | Scores | reach 3 / impact 3 / confidence 5 | | Piotr fit | medium | | Effort | small | | Labels | `judge/p2`, `judge/codex-candidate` | | Judge | `iskra` via `openclaw` | **Rationale:** This is P2 Codex-ready manifest hygiene because dangling compose references in archived modules can mislead inventory, dashboards, and future operators. **Caveat:** Keep this as manifest-only tombstoning; do not alter live compose services or revive archived modules while cleaning references. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue identifies three sunset or archived module manifests with compose service references that no longer exist.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body says compose/apps/compose.yaml has no matching vault, vault-bootstrap, or np-silverbullet services.", "type": "forgejo", "value": "issue-body-extracted-context" }, { "note": "Body cites already tombstoned modules as the intended external-orchestrator pattern for cleanup.", "type": "forgejo", "value": "issue-body-reference-pattern" } ], "impact": 3, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-15T01:02:00Z", "labels_to_apply": [ "judge/p2", "judge/codex-candidate" ], "piotr_fit": "medium", "priority": "p2", "rationale_summary": "This is P2 Codex-ready manifest hygiene because dangling compose references in archived modules can mislead inventory, dashboards, and future operators.", "reach": 3, "recommended_next_action": "codex_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 751, "repo": "pdurlej/platform" }, "target_snapshot": { "body_hash": "sha256:8e48ac00ca0f4c82660a51eb0f418c166838f1fee29793f187769646462cf743", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [], "labels_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "state": "open", "title_hash": "sha256:b11d72374172e06cd953b1528993d3f6db9f88f34ad2d8d9a888a694f9a04a75", "updated_at": "2026-06-08T23:09:24+02:00" }, "top_caveat": "Keep this as manifest-only tombstoning; do not alter live compose services or revive archived modules while cleaning references." }  ``` </details>

Iskra added the

judge/codex-candidate

judge/p2

labels

2026-06-15 03:03:25 +02:00

Iskra referenced this issue from pdurlej/judging-claw

2026-06-15 03:03:25 +02:00

[Judging Claw] codex_candidate for pdurlej/platform#751 (p2) #103

pdurlej added the

safety:no-prod-mutation

size/small

status:codex-ready

labels

2026-06-17 23:35:31 +02:00

pdurlej referenced this issue

2026-06-17 23:35:38 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

pdurlej commented

2026-06-17 23:40:57 +02:00

Owner

Closing as already implemented on current main. Evidence: vault, vault-bootstrap, and np-silverbullet module manifests now have runtime.orchestrator: external and no compose_service; targeted scan for active compose service definitions in compose/apps/compose.yaml returned no matches for those service names. Verification before close: UV_CACHE_DIR=/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev platformctl validate all --json returned exitCode: 0 on all modules.

Closing as already implemented on current main. Evidence: vault, vault-bootstrap, and np-silverbullet module manifests now have `runtime.orchestrator: external` and no `compose_service`; targeted scan for active compose service definitions in `compose/apps/compose.yaml` returned no matches for those service names. Verification before close: `UV_CACHE_DIR=/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev platformctl validate all --json` returned `exitCode: 0` on all modules.

pdurlej closed this issue

2026-06-17 23:40:58 +02:00

pdurlej referenced this issue

2026-06-18 00:06:36 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766