fix(code): remove dead branch, deduplicate constant, deduplicate import #757

New issue

Closed

opened 2026-06-08 23:07:57 +02:00 by ollama · 1 comment

ollama commented

2026-06-08 23:07:57 +02:00

Collaborator

Spec sources (whitelist)

control-plane/platformctl/cli.py lines 71-79 — EXIT_UNKNOWN_STATE=8 and _emit function with dead no-op branch
control-plane/platformctl/plan.py line 35 — EXIT_UNKNOWN_PARTIAL=8 (duplicate constant)
control-plane/platformctl/telemetry.py lines 108-120 — duplicate import fcntl

Extracted context

Three minor code-quality issues in the platformctl codebase:

Dead no-op branch (cli.py:74-79): Both if/else branches of _emit are identical:
```
click.echo(json.dumps(payload, indent=2, default=str))
```
The misleading # Compact human-readable comment suggests divergence that doesn't exist. Collapse to single echo.
Duplicate constant (cli.py:71): EXIT_UNKNOWN_STATE=8 duplicates plan.py:35 EXIT_UNKNOWN_PARTIAL=8. Reuse the imported constant.
Duplicate import (telemetry.py:108-120): fcntl imported twice in append_event function. Import once, guard only the flock calls.

Scope

Collapse _emit to single click.echo(...) call, remove misleading comment. Keep json_output param for API stability (47 call sites).
Replace EXIT_UNKNOWN_STATE=8 with from .plan import EXIT_UNKNOWN_PARTIAL + use EXIT_UNKNOWN_PARTIAL at cli.py:382.
Remove duplicate import fcntl from telemetry.py:108-120; move import to top of function if not already imported.

Acceptance criteria

715+ tests still green
No dead no-op branches
No duplicate constants
No duplicate imports in same function

Do NOT read

Full repo — only the 3 source files listed above
Do NOT modify test files

Agent notes

Recommended executor: Gemini 3.1 Pro
Size: Trivial (~7 LOC total across 3 files)
Review tier: tier/trivial
Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §E3, E4, E5
This is a subset of #726 item 3-4 (claude's deslop issue)

## Spec sources (whitelist) - `control-plane/platformctl/cli.py` lines 71-79 — `EXIT_UNKNOWN_STATE=8` and `_emit` function with dead no-op branch - `control-plane/platformctl/plan.py` line 35 — `EXIT_UNKNOWN_PARTIAL=8` (duplicate constant) - `control-plane/platformctl/telemetry.py` lines 108-120 — duplicate `import fcntl` ## Extracted context Three minor code-quality issues in the platformctl codebase: 1. **Dead no-op branch** (`cli.py:74-79`): Both if/else branches of `_emit` are identical: ```python click.echo(json.dumps(payload, indent=2, default=str)) ``` The misleading `# Compact human-readable` comment suggests divergence that doesn't exist. Collapse to single echo. 2. **Duplicate constant** (`cli.py:71`): `EXIT_UNKNOWN_STATE=8` duplicates `plan.py:35` `EXIT_UNKNOWN_PARTIAL=8`. Reuse the imported constant. 3. **Duplicate import** (`telemetry.py:108-120`): `fcntl` imported twice in `append_event` function. Import once, guard only the flock calls. ## Scope 1. Collapse `_emit` to single `click.echo(...)` call, remove misleading comment. Keep `json_output` param for API stability (47 call sites). 2. Replace `EXIT_UNKNOWN_STATE=8` with `from .plan import EXIT_UNKNOWN_PARTIAL` + use `EXIT_UNKNOWN_PARTIAL` at `cli.py:382`. 3. Remove duplicate `import fcntl` from `telemetry.py:108-120`; move import to top of function if not already imported. ## Acceptance criteria - [ ] 715+ tests still green - [ ] No dead no-op branches - [ ] No duplicate constants - [ ] No duplicate imports in same function ## Do NOT read - Full repo — only the 3 source files listed above - Do NOT modify test files ## Agent notes - Recommended executor: Gemini 3.1 Pro - Size: Trivial (~7 LOC total across 3 files) - Review tier: tier/trivial - Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §E3, E4, E5 - This is a subset of #726 item 3-4 (claude's deslop issue)

ollama referenced this issue

2026-06-08 23:09:24 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

pdurlej added the

safety:no-prod-mutation

size/small

status:codex-ready

labels

2026-06-17 23:35:34 +02:00

pdurlej referenced this issue

2026-06-17 23:35:38 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

pdurlej commented

2026-06-17 23:43:04 +02:00

Owner

Closing as already implemented on current main. Evidence: cli.py imports EXIT_UNKNOWN_PARTIAL as EXIT_UNKNOWN_STATE, _emit() has a single JSON echo path, and telemetry.append_event() imports fcntl once inside the function. Verification: full platformctl test suite passed with UV_CACHE_DIR=/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests -q -> 756 passed.

Closing as already implemented on current main. Evidence: `cli.py` imports `EXIT_UNKNOWN_PARTIAL as EXIT_UNKNOWN_STATE`, `_emit()` has a single JSON echo path, and `telemetry.append_event()` imports `fcntl` once inside the function. Verification: full `platformctl` test suite passed with `UV_CACHE_DIR=/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests -q` -> `756 passed`.

pdurlej closed this issue

2026-06-17 23:43:04 +02:00

pdurlej referenced this issue

2026-06-18 00:06:36 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766