pdurlej/platform

Fork 0

fix(tests): rewrite smoke.sh with 4 known fixes from PR #40 canary #764

New issue

Closed

opened 2026-06-08 23:09:24 +02:00 by ollama · 1 comment

ollama commented

2026-06-08 23:09:24 +02:00

Collaborator

Spec sources (whitelist)

tests/smoke.sh — current smoke test
PR #40 discussion — 4 known bugs identified during canary review
modules/n8n-worker/module.yaml — reference for correct digest extraction pattern
modules/*/module.yaml — representative modules to test against

Extracted context

PR #40 (smoke.sh rewrite) was closed without merge after canary identified 4 real bugs:

Drift detection compares {{.Image}} (local config ID) instead of registry digest — n8n-worker drift detection may have been false-positive
Container name hardcoded home-platform-${compose_service}-1 — but agaria-, agent-plane-shadow-, hermes-* use different prefixes
Python deps fragile on homelab (pyyaml + jsonschema rot risk)
Dead code read_field shipped unused

Operator decision (2026-05-03): revert + rewrite.

Scope

Rewrite tests/smoke.sh from scratch incorporating all 4 fixes:

Use registry digest comparison (docker inspect --format '{{index .RepoDigests 0}}') instead of {{.Image}}
Source container name prefix from module manifest (runtime.orchestrator + runtime.compose_service) or support multiple prefix patterns
Use Python json module + subprocess instead of pyyaml/jsonschema to avoid dependency rot
Remove dead code; keep only actually-used functions

Reference pattern from n8n-worker runbook: yq '.spec.runtime.image_observed' modules/<name>/module.yaml for digest source (no copy-paste failure modes).

Acceptance criteria

Drift detection uses registry digest, not local image ID
Container name detection works for all prefix patterns (home-platform-, agaria-, agent-plane-shadow-, hermes-)
Python deps: only stdlib (json, subprocess) or already-available tools (yq, jq)
No dead code
Tested against 3+ representative modules (core, user-app, custom-prefix)

Do NOT read

Full repo — only current smoke.sh + module manifests needed for testing

Agent notes

Recommended executor: Gemini 3.1 Pro (careful rewrite needed)
Size: Medium (~150 LOC)
Review tier: tier/medium (touches production smoke testing)
Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §T1

## Spec sources (whitelist) - `tests/smoke.sh` — current smoke test - PR #40 discussion — 4 known bugs identified during canary review - `modules/n8n-worker/module.yaml` — reference for correct digest extraction pattern - `modules/*/module.yaml` — representative modules to test against ## Extracted context PR #40 (smoke.sh rewrite) was closed without merge after canary identified 4 real bugs: 1. **Drift detection compares `{{.Image}}` (local config ID) instead of registry digest** — n8n-worker drift detection may have been false-positive 2. **Container name hardcoded `home-platform-${compose_service}-1`** — but agaria-*, agent-plane-shadow-*, hermes-* use different prefixes 3. **Python deps fragile** on homelab (pyyaml + jsonschema rot risk) 4. **Dead code `read_field` shipped unused** Operator decision (2026-05-03): revert + rewrite. ## Scope Rewrite `tests/smoke.sh` from scratch incorporating all 4 fixes: 1. Use registry digest comparison (`docker inspect --format '{{index .RepoDigests 0}}'`) instead of `{{.Image}}` 2. Source container name prefix from module manifest (`runtime.orchestrator` + `runtime.compose_service`) or support multiple prefix patterns 3. Use Python `json` module + `subprocess` instead of pyyaml/jsonschema to avoid dependency rot 4. Remove dead code; keep only actually-used functions Reference pattern from n8n-worker runbook: `yq '.spec.runtime.image_observed' modules/<name>/module.yaml` for digest source (no copy-paste failure modes). ## Acceptance criteria - [ ] Drift detection uses registry digest, not local image ID - [ ] Container name detection works for all prefix patterns (home-platform-*, agaria-*, agent-plane-shadow-*, hermes-*) - [ ] Python deps: only stdlib (json, subprocess) or already-available tools (yq, jq) - [ ] No dead code - [ ] Tested against 3+ representative modules (core, user-app, custom-prefix) ## Do NOT read - Full repo — only current smoke.sh + module manifests needed for testing ## Agent notes - Recommended executor: Gemini 3.1 Pro (careful rewrite needed) - Size: Medium (~150 LOC) - Review tier: tier/medium (touches production smoke testing) - Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §T1

codex added the

labels

2026-06-11 08:15:48 +02:00

pdurlej referenced this issue

2026-06-17 23:35:38 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

pdurlej referenced this issue

2026-06-18 00:06:36 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

Iskra commented

2026-06-19 03:03:54 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/platform#issue#764`
Priority	p2
Action	codex_candidate
Scores	reach 4 / impact 4 / confidence 5
Piotr fit	high
Effort	small
Labels	`judge/p2`, `judge/codex-candidate`
Judge	`iskra` via `openclaw`

Rationale: This is a strong P2 Codex candidate because it converts known canary findings into a scoped smoke-test rewrite that protects runtime drift detection and deployment confidence.

Caveat: Preserve smoke-test portability and verify against representative module manifests rather than reintroducing environment-specific assumptions.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 5,
  "effort_hint": "small",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Issue scopes a ready bugfix rewrite of tests/smoke.sh based on four canary-identified defects from PR review.",
      "type": "forgejo",
      "value": "issue-title-body-labels-and-target-snapshot"
    },
    {
      "note": "Body names concrete fixes for registry digest comparison, non-uniform container names, fragile Python dependencies, and unused dead code.",
      "type": "forgejo",
      "value": "issue-body-known-bugs-and-scope"
    },
    {
      "note": "Labels mark this as a small ready runtime bug with process and runtime risk.",
      "type": "snapshot",
      "value": "target-labels-and-target-snapshot"
    }
  ],
  "impact": 4,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-19T00:00:00Z",
  "labels_to_apply": [
    "judge/p2",
    "judge/codex-candidate"
  ],
  "piotr_fit": "high",
  "priority": "p2",
  "rationale_summary": "This is a strong P2 Codex candidate because it converts known canary findings into a scoped smoke-test rewrite that protects runtime drift detection and deployment confidence.",
  "reach": 4,
  "recommended_next_action": "codex_candidate",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 764,
    "repo": "pdurlej/platform"
  },
  "target_snapshot": {
    "body_hash": "sha256:2b351cebe8081b3f72a708552ef07c4847e107f81dedc9790c89c1e965678f71",
    "commit_count": null,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": null,
    "labels": [
      "domain:runtime",
      "flow/ready",
      "kind/bug",
      "phase/03",
      "priority:p2",
      "risk/process",
      "risk/runtime",
      "size/small"
    ],
    "labels_hash": "sha256:977d06cdf2ca8aadcea6572e50e27c1fa3d437b2b2fe0dbbb64749b343973fbe",
    "state": "open",
    "title_hash": "sha256:2b71b7f9733d54ee8f5ad48a6f3cceed2cc1df65a41bbf53c83b00e78c6f04b6",
    "updated_at": "2026-06-18T00:06:36+02:00"
  },
  "top_caveat": "Preserve smoke-test portability and verify against representative module manifests rather than reintroducing environment-specific assumptions."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/platform#issue#764` | | Priority | p2 | | Action | codex_candidate | | Scores | reach 4 / impact 4 / confidence 5 | | Piotr fit | high | | Effort | small | | Labels | `judge/p2`, `judge/codex-candidate` | | Judge | `iskra` via `openclaw` | **Rationale:** This is a strong P2 Codex candidate because it converts known canary findings into a scoped smoke-test rewrite that protects runtime drift detection and deployment confidence. **Caveat:** Preserve smoke-test portability and verify against representative module manifests rather than reintroducing environment-specific assumptions. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue scopes a ready bugfix rewrite of tests/smoke.sh based on four canary-identified defects from PR review.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body names concrete fixes for registry digest comparison, non-uniform container names, fragile Python dependencies, and unused dead code.", "type": "forgejo", "value": "issue-body-known-bugs-and-scope" }, { "note": "Labels mark this as a small ready runtime bug with process and runtime risk.", "type": "snapshot", "value": "target-labels-and-target-snapshot" } ], "impact": 4, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-19T00:00:00Z", "labels_to_apply": [ "judge/p2", "judge/codex-candidate" ], "piotr_fit": "high", "priority": "p2", "rationale_summary": "This is a strong P2 Codex candidate because it converts known canary findings into a scoped smoke-test rewrite that protects runtime drift detection and deployment confidence.", "reach": 4, "recommended_next_action": "codex_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 764, "repo": "pdurlej/platform" }, "target_snapshot": { "body_hash": "sha256:2b351cebe8081b3f72a708552ef07c4847e107f81dedc9790c89c1e965678f71", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "domain:runtime", "flow/ready", "kind/bug", "phase/03", "priority:p2", "risk/process", "risk/runtime", "size/small" ], "labels_hash": "sha256:977d06cdf2ca8aadcea6572e50e27c1fa3d437b2b2fe0dbbb64749b343973fbe", "state": "open", "title_hash": "sha256:2b71b7f9733d54ee8f5ad48a6f3cceed2cc1df65a41bbf53c83b00e78c6f04b6", "updated_at": "2026-06-18T00:06:36+02:00" }, "top_caveat": "Preserve smoke-test portability and verify against representative module manifests rather than reintroducing environment-specific assumptions." }  ``` </details>

Iskra added the

judge/codex-candidate

judge/p2

labels

2026-06-19 03:03:54 +02:00

Iskra referenced this issue from pdurlej/judging-claw

2026-06-19 03:03:54 +02:00

[Judging Claw] codex_candidate for pdurlej/platform#764 (p2) #107

codex referenced this issue from a pull request that will close it,

2026-06-26 08:45:04 +02:00

feat(platformctl): generate module index and close catalog audits #836

pdurlej closed this issue