pdurlej/platform

Fork 0

fix(tests): restore pytest 9-compatible docker_mock fixture registration #808

New issue

Closed

opened 2026-06-19 01:27:18 +02:00 by codex · 1 comment

codex commented

2026-06-19 01:27:18 +02:00

Collaborator

Spec sources (whitelist)

control-plane/platformctl/tests/conftest.py
control-plane/platformctl/tests/fixtures/docker_mock.py
control-plane/platformctl/tests/test_plan_integration.py
docs/forgejo-agent-operations.md §Issue Rules

Extracted context

From control-plane/platformctl/tests/fixtures/docker_mock.py:
@pytest.fixture
def docker_mock() -> DockerMockProvider:
    return DockerMockProvider()
From control-plane/platformctl/tests/test_plan_integration.py:
def _plan(module_id: str, docker_mock: DockerMockProvider, tmp_path: Path) -> tuple[dict, int]:
    return plan_module(module_id, out_path=tmp_path / f"{module_id}.plan.json", transport=docker_mock)
From Antigravity/Gemini audit, 2026-06-19: nested pytest_plugins was reported as incompatible with pytest 9.x, but later ruff cleanup tried to remove the direct fixture import as unused.

Do NOT read (unless escape hatch fires)

control-plane/platformctl/tools/ — runtime implementation is out of scope; this is fixture registration only.
modules/ — module manifests do not affect this pytest fixture contract.

Allowed touched paths

control-plane/platformctl/tests/conftest.py (modify)
control-plane/platformctl/tests/test_plan_integration.py (read only unless a minimal assertion is needed)

Why this exists (product-first)

Agents need the platformctl test suite to collect reliably on current pytest versions. The docker_mock fixture is part of the read-only runtime planning test surface; losing fixture discovery turns a simple linter cleanup into a broken test harness.

Why this matters now

The Antigravity audit found the pytest 9 compatibility issue, but the follow-up ruff cleanup appears to remove the import pytest needs for fixture registration. This should be made explicit and pinned with a focused test command before any branch cleanup is merged.

What "done" looks like

control-plane/platformctl/tests/conftest.py registers docker_mock without using nested pytest_plugins.
Ruff does not flag the intentional fixture import, e.g. via explicit alias/re-export or scoped noqa.
PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests/test_plan_integration.py passes.
PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests collects without pytest-plugin deprecation errors.

Scope

In scope:

Pytest fixture registration for docker_mock.
Minimal lint suppression if needed.

Out of scope:

Broad ruff cleanup.
Runtime Docker behavior changes.
platformctl planning semantics.

Suggested approach

Replace nested pytest_plugins with an explicit import that pytest can discover and ruff will not remove.
Run the focused test_plan_integration.py test.
Run the broader platformctl collection/test command if cheap enough.

Escape hatch

If pytest no longer needs this fixture import, comment with the exact pytest discovery evidence before deleting it. Do not silently accept an empty conftest.py just because ruff reports an unused import.

Unknowns / owner questions

None expected.

Risk class

risk/runtime — test harness validates read-only runtime planning behavior.
risk/process — bad lint cleanup can break agent-visible verification.

Class of service

class/security-sensitive

Trace

Original source: Antigravity/Gemini audit reviewed in Codex side conversation, 2026-06-19.
Migrated by: codex, 2026-06-19.
Related local branch: antigravity/orders/audit-reconcile.

## Spec sources (whitelist) - `control-plane/platformctl/tests/conftest.py` - `control-plane/platformctl/tests/fixtures/docker_mock.py` - `control-plane/platformctl/tests/test_plan_integration.py` - `docs/forgejo-agent-operations.md` §Issue Rules ## Extracted context > From `control-plane/platformctl/tests/fixtures/docker_mock.py`: > ```python > @pytest.fixture > def docker_mock() -> DockerMockProvider: > return DockerMockProvider() > ``` > > From `control-plane/platformctl/tests/test_plan_integration.py`: > ```python > def _plan(module_id: str, docker_mock: DockerMockProvider, tmp_path: Path) -> tuple[dict, int]: > return plan_module(module_id, out_path=tmp_path / f"{module_id}.plan.json", transport=docker_mock) > ``` > > From Antigravity/Gemini audit, 2026-06-19: nested `pytest_plugins` was reported as incompatible with pytest 9.x, but later ruff cleanup tried to remove the direct fixture import as unused. ## Do NOT read (unless escape hatch fires) - `control-plane/platformctl/tools/` — runtime implementation is out of scope; this is fixture registration only. - `modules/` — module manifests do not affect this pytest fixture contract. ## Allowed touched paths - `control-plane/platformctl/tests/conftest.py` (modify) - `control-plane/platformctl/tests/test_plan_integration.py` (read only unless a minimal assertion is needed) ## Why this exists (product-first) Agents need the platformctl test suite to collect reliably on current pytest versions. The `docker_mock` fixture is part of the read-only runtime planning test surface; losing fixture discovery turns a simple linter cleanup into a broken test harness. ## Why this matters now The Antigravity audit found the pytest 9 compatibility issue, but the follow-up ruff cleanup appears to remove the import pytest needs for fixture registration. This should be made explicit and pinned with a focused test command before any branch cleanup is merged. ## What "done" looks like - [ ] `control-plane/platformctl/tests/conftest.py` registers `docker_mock` without using nested `pytest_plugins`. - [ ] Ruff does not flag the intentional fixture import, e.g. via explicit alias/re-export or scoped noqa. - [ ] `PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests/test_plan_integration.py` passes. - [ ] `PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests` collects without pytest-plugin deprecation errors. ## Scope **In scope:** - Pytest fixture registration for `docker_mock`. - Minimal lint suppression if needed. **Out of scope:** - Broad ruff cleanup. - Runtime Docker behavior changes. - platformctl planning semantics. ## Suggested approach 1. Replace nested `pytest_plugins` with an explicit import that pytest can discover and ruff will not remove. 2. Run the focused `test_plan_integration.py` test. 3. Run the broader platformctl collection/test command if cheap enough. ## Escape hatch If pytest no longer needs this fixture import, comment with the exact pytest discovery evidence before deleting it. Do not silently accept an empty `conftest.py` just because ruff reports an unused import. ## Unknowns / owner questions - None expected. ## Risk class - [x] `risk/runtime` — test harness validates read-only runtime planning behavior. - [x] `risk/process` — bad lint cleanup can break agent-visible verification. ## Class of service - [ ] `class/security-sensitive` ## Trace - Original source: Antigravity/Gemini audit reviewed in Codex side conversation, 2026-06-19. - Migrated by: codex, 2026-06-19. - Related local branch: `antigravity/orders/audit-reconcile`.

codex added the

size/tiny

proposed

source/agent-generated

safety:no-prod-mutation

labels

2026-06-19 01:27:18 +02:00

Iskra commented

2026-06-20 03:02:02 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/platform#issue#808`
Priority	p2
Action	codex_candidate
Scores	reach 3 / impact 3 / confidence 4
Piotr fit	medium
Effort	tiny
Labels	`judge/p2`, `judge/codex-candidate`
Judge	`iskra` via `openclaw`

Rationale: This is a small Codex-suitable CI fix with clear scoped files and low production blast radius, but it protects pytest compatibility for platformctl tests.

Caveat: The judgment relies on the supplied excerpt and does not verify the actual pytest failure locally.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 4,
  "effort_hint": "tiny",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Public repository metadata and dry-run packet only.",
      "type": "snapshot",
      "value": "issue-or-pr-title-body-labels-and-target-snapshot"
    }
  ],
  "impact": 3,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-20T00:00:00Z",
  "labels_to_apply": [
    "judge/p2",
    "judge/codex-candidate"
  ],
  "piotr_fit": "medium",
  "priority": "p2",
  "rationale_summary": "This is a small Codex-suitable CI fix with clear scoped files and low production blast radius, but it protects pytest compatibility for platformctl tests.",
  "reach": 3,
  "recommended_next_action": "codex_candidate",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 808,
    "repo": "pdurlej/platform"
  },
  "target_snapshot": {
    "body_hash": "sha256:0dd695c16f3750035768d8691917f958808b4b13568f402fb7ad9d05e6faee43",
    "commit_count": null,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": null,
    "labels": [
      "agent/codex",
      "domain:ci",
      "proposed",
      "risk/process",
      "risk/runtime",
      "safety:no-prod-mutation",
      "size/tiny",
      "source/agent-generated",
      "type:bug"
    ],
    "labels_hash": "sha256:cf3ffec15e1ec0bdefc9d8ab6428a43827ace6200acd3f006c97545d831988ac",
    "state": "open",
    "title_hash": "sha256:1dab883ee676383b65ebedf3ab79b63f5919de6deeb87f208d71352838901993",
    "updated_at": "2026-06-19T01:27:18+02:00"
  },
  "top_caveat": "The judgment relies on the supplied excerpt and does not verify the actual pytest failure locally."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/platform#issue#808` | | Priority | p2 | | Action | codex_candidate | | Scores | reach 3 / impact 3 / confidence 4 | | Piotr fit | medium | | Effort | tiny | | Labels | `judge/p2`, `judge/codex-candidate` | | Judge | `iskra` via `openclaw` | **Rationale:** This is a small Codex-suitable CI fix with clear scoped files and low production blast radius, but it protects pytest compatibility for platformctl tests. **Caveat:** The judgment relies on the supplied excerpt and does not verify the actual pytest failure locally. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 4, "effort_hint": "tiny", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Public repository metadata and dry-run packet only.", "type": "snapshot", "value": "issue-or-pr-title-body-labels-and-target-snapshot" } ], "impact": 3, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-20T00:00:00Z", "labels_to_apply": [ "judge/p2", "judge/codex-candidate" ], "piotr_fit": "medium", "priority": "p2", "rationale_summary": "This is a small Codex-suitable CI fix with clear scoped files and low production blast radius, but it protects pytest compatibility for platformctl tests.", "reach": 3, "recommended_next_action": "codex_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 808, "repo": "pdurlej/platform" }, "target_snapshot": { "body_hash": "sha256:0dd695c16f3750035768d8691917f958808b4b13568f402fb7ad9d05e6faee43", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "agent/codex", "domain:ci", "proposed", "risk/process", "risk/runtime", "safety:no-prod-mutation", "size/tiny", "source/agent-generated", "type:bug" ], "labels_hash": "sha256:cf3ffec15e1ec0bdefc9d8ab6428a43827ace6200acd3f006c97545d831988ac", "state": "open", "title_hash": "sha256:1dab883ee676383b65ebedf3ab79b63f5919de6deeb87f208d71352838901993", "updated_at": "2026-06-19T01:27:18+02:00" }, "top_caveat": "The judgment relies on the supplied excerpt and does not verify the actual pytest failure locally." }  ``` </details>

Iskra added the

judge/codex-candidate

judge/p2

labels

2026-06-20 03:02:02 +02:00

Iskra referenced this issue from pdurlej/judging-claw

2026-06-20 03:02:03 +02:00

[Judging Claw] codex_candidate for pdurlej/platform#808 (p2) #111

codex referenced this issue from a pull request that will close it,

2026-06-26 14:07:27 +02:00

fix(tests): register docker mock fixture directly #840