pdurlej/platform

Fork 0

fix(tests): reconcile stale platform contract expectations #810

New issue

Closed

opened 2026-06-19 01:27:18 +02:00 by codex · 1 comment

codex commented

2026-06-19 01:27:18 +02:00

Collaborator

Spec sources (whitelist)

compose/apps/compose.yaml
tests/test_deploy_control_cutoff_contract.py
tests/test_iskra_things_sync_contract.py
decisions/0026-wloczykij-gold-vault-and-iskra-promotion-boundary.md

Extracted context

From Antigravity/Gemini audit, 2026-06-19:

deploy-control test expected /opt/vps-home-platform-infra/ paths, while compose now uses /opt/pdurlej-platform/runtime/legacy-import/.
iskra things sync contract test expected ADR 0023, while the ADR was renumbered to 0026.

Do NOT read (unless escape hatch fires)

control-plane/platformctl/ — platformctl internals are not needed for this contract-test reconciliation.
modules/ — module manifests are out of scope unless a failing test explicitly cites one.

Allowed touched paths

tests/test_deploy_control_cutoff_contract.py (modify)
tests/test_iskra_things_sync_contract.py (modify)

Why this exists (product-first)

Contract tests should protect current platform intent, not pin stale paths or stale ADR numbers. When tests encode obsolete contracts, agents either mistrust the test suite or patch around correct repo state.

Why this matters now

The audit found root-level test failures caused by stale expectations. These updates are small, but they should be reviewed separately from prompt-link repair and lint cleanup.

What "done" looks like

test_deploy_control_cutoff_contract.py expectations match current compose/apps/compose.yaml deploy-control mounts.
test_iskra_things_sync_contract.py reads ADR 0026-wloczykij-gold-vault-and-iskra-promotion-boundary.md if that is the current canonical ADR.
Focused tests pass: uv run pytest tests/test_deploy_control_cutoff_contract.py tests/test_iskra_things_sync_contract.py.
The PR explains whether these are test-only reconciliations or expose a real contract change.

Scope

In scope:

Test expectation updates for current compose path and ADR renumbering.

Out of scope:

Compose/runtime path changes.
ADR renumbering or ADR content edits.
Iskra sync implementation behavior.

Suggested approach

Compare the failing assertions with the current source files.
Update only stale expected values.
Run the focused root tests.

Escape hatch

If the compose file or ADR path is wrong rather than the tests, stop and comment with evidence. Do not change runtime compose or ADR files inside this issue.

Unknowns / owner questions

None expected if the current compose and ADR paths are confirmed.

Risk class

risk/runtime — tests encode runtime mount contracts.
risk/process — stale contract tests mislead future agents.

Class of service

class/security-sensitive

Trace

Original source: Antigravity/Gemini audit reviewed in Codex side conversation, 2026-06-19.
Migrated by: codex, 2026-06-19.
Related local branch: antigravity/orders/audit-reconcile.

## Spec sources (whitelist) - `compose/apps/compose.yaml` - `tests/test_deploy_control_cutoff_contract.py` - `tests/test_iskra_things_sync_contract.py` - `decisions/0026-wloczykij-gold-vault-and-iskra-promotion-boundary.md` ## Extracted context > From Antigravity/Gemini audit, 2026-06-19: > ```text > deploy-control test expected /opt/vps-home-platform-infra/ paths, while compose now uses /opt/pdurlej-platform/runtime/legacy-import/. > iskra things sync contract test expected ADR 0023, while the ADR was renumbered to 0026. > ``` ## Do NOT read (unless escape hatch fires) - `control-plane/platformctl/` — platformctl internals are not needed for this contract-test reconciliation. - `modules/` — module manifests are out of scope unless a failing test explicitly cites one. ## Allowed touched paths - `tests/test_deploy_control_cutoff_contract.py` (modify) - `tests/test_iskra_things_sync_contract.py` (modify) ## Why this exists (product-first) Contract tests should protect current platform intent, not pin stale paths or stale ADR numbers. When tests encode obsolete contracts, agents either mistrust the test suite or patch around correct repo state. ## Why this matters now The audit found root-level test failures caused by stale expectations. These updates are small, but they should be reviewed separately from prompt-link repair and lint cleanup. ## What "done" looks like - [ ] `test_deploy_control_cutoff_contract.py` expectations match current `compose/apps/compose.yaml` deploy-control mounts. - [ ] `test_iskra_things_sync_contract.py` reads ADR `0026-wloczykij-gold-vault-and-iskra-promotion-boundary.md` if that is the current canonical ADR. - [ ] Focused tests pass: `uv run pytest tests/test_deploy_control_cutoff_contract.py tests/test_iskra_things_sync_contract.py`. - [ ] The PR explains whether these are test-only reconciliations or expose a real contract change. ## Scope **In scope:** - Test expectation updates for current compose path and ADR renumbering. **Out of scope:** - Compose/runtime path changes. - ADR renumbering or ADR content edits. - Iskra sync implementation behavior. ## Suggested approach 1. Compare the failing assertions with the current source files. 2. Update only stale expected values. 3. Run the focused root tests. ## Escape hatch If the compose file or ADR path is wrong rather than the tests, stop and comment with evidence. Do not change runtime compose or ADR files inside this issue. ## Unknowns / owner questions - None expected if the current compose and ADR paths are confirmed. ## Risk class - [x] `risk/runtime` — tests encode runtime mount contracts. - [x] `risk/process` — stale contract tests mislead future agents. ## Class of service - [ ] `class/security-sensitive` ## Trace - Original source: Antigravity/Gemini audit reviewed in Codex side conversation, 2026-06-19. - Migrated by: codex, 2026-06-19. - Related local branch: `antigravity/orders/audit-reconcile`.

codex added the

proposed

source/agent-generated

safety:no-prod-mutation

labels

2026-06-19 01:27:18 +02:00

Iskra commented

2026-06-21 03:02:32 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/platform#issue#810`
Priority	p2
Action	codex_candidate
Scores	reach 3 / impact 3 / confidence 4
Piotr fit	high
Effort	small
Labels	`judge/p2`, `judge/codex-candidate`
Judge	`iskra` via `openclaw`

Rationale: This is a bounded CI contract-test repair with explicit allowed paths, small scope, and no production mutation risk, making it a good Codex candidate.

Caveat: The full issue body and live repository state were not inspected, so the judgment rests on the supplied packet and labels.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 4,
  "effort_hint": "small",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Public repository metadata and dry-run packet only.",
      "type": "snapshot",
      "value": "issue-or-pr-title-body-labels-and-target-snapshot"
    }
  ],
  "impact": 3,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-21T00:00:00Z",
  "labels_to_apply": [
    "judge/p2",
    "judge/codex-candidate"
  ],
  "piotr_fit": "high",
  "priority": "p2",
  "rationale_summary": "This is a bounded CI contract-test repair with explicit allowed paths, small scope, and no production mutation risk, making it a good Codex candidate.",
  "reach": 3,
  "recommended_next_action": "codex_candidate",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 810,
    "repo": "pdurlej/platform"
  },
  "target_snapshot": {
    "body_hash": "sha256:34915fddc866a6e0da29f94b1e576c9dc29ef2f3e72b93fe6b6492b32ceb02a1",
    "commit_count": null,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": null,
    "labels": [
      "agent/codex",
      "domain:ci",
      "proposed",
      "risk/process",
      "risk/runtime",
      "safety:no-prod-mutation",
      "size/small",
      "source/agent-generated",
      "type:bug"
    ],
    "labels_hash": "sha256:ff549897f48a28fded08528a4684f50018532bb73f3b9a8715f4b999f4994361",
    "state": "open",
    "title_hash": "sha256:64f2292b98b0f39fe84c4cade949848471c44e82bf77ca461fe6d69d2748e586",
    "updated_at": "2026-06-19T01:27:18+02:00"
  },
  "top_caveat": "The full issue body and live repository state were not inspected, so the judgment rests on the supplied packet and labels."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/platform#issue#810` | | Priority | p2 | | Action | codex_candidate | | Scores | reach 3 / impact 3 / confidence 4 | | Piotr fit | high | | Effort | small | | Labels | `judge/p2`, `judge/codex-candidate` | | Judge | `iskra` via `openclaw` | **Rationale:** This is a bounded CI contract-test repair with explicit allowed paths, small scope, and no production mutation risk, making it a good Codex candidate. **Caveat:** The full issue body and live repository state were not inspected, so the judgment rests on the supplied packet and labels. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 4, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Public repository metadata and dry-run packet only.", "type": "snapshot", "value": "issue-or-pr-title-body-labels-and-target-snapshot" } ], "impact": 3, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-21T00:00:00Z", "labels_to_apply": [ "judge/p2", "judge/codex-candidate" ], "piotr_fit": "high", "priority": "p2", "rationale_summary": "This is a bounded CI contract-test repair with explicit allowed paths, small scope, and no production mutation risk, making it a good Codex candidate.", "reach": 3, "recommended_next_action": "codex_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 810, "repo": "pdurlej/platform" }, "target_snapshot": { "body_hash": "sha256:34915fddc866a6e0da29f94b1e576c9dc29ef2f3e72b93fe6b6492b32ceb02a1", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "agent/codex", "domain:ci", "proposed", "risk/process", "risk/runtime", "safety:no-prod-mutation", "size/small", "source/agent-generated", "type:bug" ], "labels_hash": "sha256:ff549897f48a28fded08528a4684f50018532bb73f3b9a8715f4b999f4994361", "state": "open", "title_hash": "sha256:64f2292b98b0f39fe84c4cade949848471c44e82bf77ca461fe6d69d2748e586", "updated_at": "2026-06-19T01:27:18+02:00" }, "top_caveat": "The full issue body and live repository state were not inspected, so the judgment rests on the supplied packet and labels." }  ``` </details>

Iskra added the

judge/codex-candidate

judge/p2

labels

2026-06-21 03:02:32 +02:00

Iskra referenced this issue from pdurlej/judging-claw

2026-06-21 03:02:32 +02:00

[Judging Claw] codex_candidate for pdurlej/platform#810 (p2) #119

codex referenced this issue from a pull request that will close it,

2026-06-26 14:15:09 +02:00

fix(tests): reconcile platform contract expectations #841