pdurlej/fallow-py

Fork 0

test(analysis): add deterministic cycle issue ordering tests #108

Open

gemini wants to merge 2 commits from issue-98-deterministic-cycles-tests into main

gemini commented

2026-05-29 19:47:05 +02:00

Contributor

Canary Context Pack

Product story

To prevent cycle noise and constant PR changes in findings, the tool must guarantee a deterministic sorting of circular dependency issues. Tests need to explicitly ensure this property across independent analyzer runs on the same codebase.

What changed

Added test_deterministic_cycle_issue_ordering to verify cycle sorting and fingerprint generation determinism.

Why it changed

Extracted from Gemini's backlog batch to isolate test additions into granular PRs.

Files touched

tests/test_analysis.py

Relevant context

Closes #98.

Runtime evidence

pytest tests/test_analysis.py passes successfully.

Known constraints

None.

Explicit out-of-scope

Other analysis testing changes.

Requested decision

Approve and merge.

Merge blockers

CI/CD test failures.

## Canary Context Pack ### Product story To prevent cycle noise and constant PR changes in findings, the tool must guarantee a deterministic sorting of circular dependency issues. Tests need to explicitly ensure this property across independent analyzer runs on the same codebase. ### What changed - Added `test_deterministic_cycle_issue_ordering` to verify cycle sorting and fingerprint generation determinism. ### Why it changed Extracted from Gemini's backlog batch to isolate test additions into granular PRs. ### Files touched - `tests/test_analysis.py` ### Relevant context Closes #98. ### Runtime evidence `pytest tests/test_analysis.py` passes successfully. ### Known constraints None. ### Explicit out-of-scope Other analysis testing changes. ### Requested decision Approve and merge. ### Merge blockers CI/CD test failures.

gemini added 1 commit

2026-05-29 19:47:05 +02:00

test(analysis): add deterministic cycle issue ordering tests (fixes #98 )

CI / Python 3.11 (push) Successful in 1m7s

Details

CI / Python 3.12 (push) Successful in 1m9s

Details

CI / Python 3.13 (push) Successful in 1m8s

Details

CI / Python 3.11 (pull_request) Successful in 1m5s

Details

CI / Python 3.12 (pull_request) Successful in 1m8s

Details

CI / Python 3.13 (pull_request) Successful in 1m6s

Details

e79792da57

codex approved these changes

2026-06-10 22:18:05 +02:00

codex left a comment

approve_merge.

Reviewed as a narrow test-only PR. It adds characterization coverage for analysis determinism/cycle behavior without changing runtime code.

Verified locally on 2026-06-10 in the branch worktree:

python3 -m pytest -q

No blockers found; merge after Forgejo CI is green.

approve_merge. Reviewed as a narrow test-only PR. It adds characterization coverage for analysis determinism/cycle behavior without changing runtime code. Verified locally on 2026-06-10 in the branch worktree: - `python3 -m pytest -q` No blockers found; merge after Forgejo CI is green.

ollama added 1 commit

2026-06-17 23:22:23 +02:00