pdurlej/fallow-ts
1
0
Fork 0
Code Issues 61 Pull requests 6 Projects Releases Packages Wiki Activity Actions

Complete Wave 1 contract credibility #22

Merged
pdurlej merged 5 commits from codex/wave1-contract-credibility into codex/prewave-deterministic-contract 2026-05-17 00:18:47 +02:00
Conversation 0 Commits 5 Files changed 21 +708 -2
codex commented 2026-05-16 23:51:49 +02:00
Collaborator
Copy link

Canary Context Pack

Product story

Wave 1 makes the first fallow-ts output contract credible enough for agents to consume without guessing. The tool remains intentionally small: module syntax coverage, package/workspace metadata, golden output tests, and schema docs.

What changed

  • Added module syntax fixture coverage for ESM, CommonJS, dynamic imports, type imports/exports, side-effect imports, and re-exports.
  • Added root package.json metadata to the report.
  • Added npm/yarn/pnpm workspace declaration metadata without resolver magic.
  • Added byte-for-byte golden JSON/text output tests.
  • Documented report schema v0.

Why it changed

This completes Wave 1 from docs/roadmap.md after the pre-wave fixes from issue #17. The goal is contract credibility before Wave 2 adds graph behavior.

Files touched

  • src/analyze.ts
  • src/types.ts
  • src/index.ts
  • README.md
  • docs/report-schema-v0.md
  • tests/analyze.test.mjs
  • tests/golden.test.mjs
  • tests/fixtures/module-syntax/**
  • tests/fixtures/golden-basic/**
  • tests/golden/**

Relevant context

Stacked on PR #21 (codex/prewave-deterministic-contract). Earlier pre-wave PRs address governance, parser correctness, hostile input handling, and deterministic root/schema behavior.

Runtime evidence

  • npm run build
  • npm test
  • node dist/cli.js analyze --root . --format json --output /tmp/fallow-ts-report.json
  • npm pack --dry-run
  • git diff --check

Known constraints

The parser is still regex-based. Workspace metadata is shallow and does not imply package resolution. No findings/categories are added in this PR.

Explicit out-of-scope

No resolver, no dependency policy, no unused export analysis, no MCP server, no package graph semantics.

Requested decision

Review and approve as the Wave 1 merge-train PR after PR #18, #19, #20, and #21 are merged bottom-up.

Merge blockers

Broken golden contract, untrue schema docs, or any accidental claim that v0 resolves workspaces/imports semantically.

Closes #2.
Closes #3.
Closes #4.
Closes #5.
Closes #6.
Refs #17.

## Canary Context Pack ### Product story Wave 1 makes the first fallow-ts output contract credible enough for agents to consume without guessing. The tool remains intentionally small: module syntax coverage, package/workspace metadata, golden output tests, and schema docs. ### What changed - Added module syntax fixture coverage for ESM, CommonJS, dynamic imports, type imports/exports, side-effect imports, and re-exports. - Added root package.json metadata to the report. - Added npm/yarn/pnpm workspace declaration metadata without resolver magic. - Added byte-for-byte golden JSON/text output tests. - Documented report schema v0. ### Why it changed This completes Wave 1 from docs/roadmap.md after the pre-wave fixes from issue #17. The goal is contract credibility before Wave 2 adds graph behavior. ### Files touched - src/analyze.ts - src/types.ts - src/index.ts - README.md - docs/report-schema-v0.md - tests/analyze.test.mjs - tests/golden.test.mjs - tests/fixtures/module-syntax/** - tests/fixtures/golden-basic/** - tests/golden/** ### Relevant context Stacked on PR #21 (`codex/prewave-deterministic-contract`). Earlier pre-wave PRs address governance, parser correctness, hostile input handling, and deterministic root/schema behavior. ### Runtime evidence - npm run build - npm test - node dist/cli.js analyze --root . --format json --output /tmp/fallow-ts-report.json - npm pack --dry-run - git diff --check ### Known constraints The parser is still regex-based. Workspace metadata is shallow and does not imply package resolution. No findings/categories are added in this PR. ### Explicit out-of-scope No resolver, no dependency policy, no unused export analysis, no MCP server, no package graph semantics. ### Requested decision Review and approve as the Wave 1 merge-train PR after PR #18, #19, #20, and #21 are merged bottom-up. ### Merge blockers Broken golden contract, untrue schema docs, or any accidental claim that v0 resolves workspaces/imports semantically. Closes #2. Closes #3. Closes #4. Closes #5. Closes #6. Refs #17.
Cover ESM, CommonJS, dynamic imports, side-effect imports, type imports, multiline imports, and re-exports with fixture-backed analyzer assertions.

Closes #2.

Verified:

- npm run build

- npm test

- git diff --check
Read root package.json fields needed for later graph work while keeping current analysis semantics unchanged and malformed metadata non-fatal.

Closes #3.

Verified:

- npm run build

- npm test

- git diff --check
Closes #4.

Verified:

- npm run build

- npm test

- node dist/cli.js analyze --root tests/fixtures/module-syntax --format json --output /tmp/fallow-ts-module-syntax.json

- git diff --check
Closes #5.

Verified:

- npm run build

- npm test

- node dist/cli.js analyze --root tests/fixtures/golden-basic --format json --output /tmp/fallow-ts-golden-basic.json

- cmp -s tests/golden/basic-report.json /tmp/fallow-ts-golden-basic.json

- git diff --check
Document v0 report contract
Some checks failed
CI / test (push) Failing after 13s
Details
CI / test (pull_request) Failing after 13s
Details
ff975d73cd 
Closes #6.

Verified:

- npm run build

- npm test

- git diff --check
pdurlej merged commit 17fbae61e7 into codex/prewave-deterministic-contract 2026-05-17 00:18:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:agents
Agent identity, delegation, subagents, routing, or workflows.

  
domain:ci
CI, checks, Actions, runners, or release automation.

  
domain:docs
Documentation, packets, practices, or source-of-truth text.

  
domain:forgejo
Forgejo issues, PRs, labels, repo settings, or identity.

  
domain:infra
Infrastructure, storage, backup, DNS, network, or host substrate.

  
domain:memory
Memory, recall, write gates, salience, or Honcho-adjacent behavior.

  
domain:runtime
Runtime services, deploys, daemons, timers, or live behavior.

  
domain:signal
Signal UX, delivery, context, or outbound behavior.

  
domain:ux
Product UX, operator experience, or conversation ergonomics.

  
mode:operator-only
Apply step requires explicit operator approval.

  
mode:patchwarden-iskra-approved
Work eligible for Patchwarden/Iskra approval inside repo policy.

  
mode:safe-auto
Low-risk work eligible for lightweight autonomous handling.

  
priority:p0
Immediate safety, uptime, data, or operator-blocking issue.

  
priority:p1
Important active work; should be pulled soon.

  
priority:p2
Useful normal-priority work.

  
priority:p3
Opportunistic cleanup, research, or backlog work.

  
review:claude-reviewed
Reviewed by Claude-family agent.

  
review:codex-reviewed
Reviewed by Codex-family agent.

  
review:dziadek-reviewed
Reviewed by Dziadek pinch-point reviewer.

  
review:needs-human
Needs human review before merge or apply.

  
safety:external-write
May write to external systems, users, rooms, repos, or services.

  
safety:no-prod-mutation
Must not mutate production or live external state.

  
safety:prod-impact
May affect production/runtime behavior.

  
safety:secret-touch
Touches secrets, credentials, auth, or secret-adjacent config.

  
status:blocked
Blocked by missing dependency, evidence, access, or operator decision.

  
status:codex-ready
Ready for a Codex implementation pass.

  
status:merged:pending-evidence
Merged but waiting for live or artifact evidence before closure.

  
status:needs-evidence
Needs proof, logs, tests, or operator-visible evidence.

  
status:operator-needed
Requires explicit operator input before safe progress.

  
status:parked
Intentionally deferred; not active campaign work.

  
tier:0-platform-substrate
Data, secrets, backup, storage, or critical platform substrate.

  
tier:1-iskra-value-layer
Iskra/OpenClaw behavior, memory, runtime, or value-layer work.

  
tier:2-tools-products-modules
Tools, products, modules, experiments, and lower-blast-radius work.

  
type:bug
Incorrect behavior or regression.

  
type:chore
Maintenance, cleanup, metadata, or operational task.

  
type:docs
Documentation-only work.

  
type:feat
New capability or product behavior.

  
type:policy
Governance, protocol, boundary, or decision-contract change.

  
type:research
Investigation, spike, or evidence-gathering task.

No labels
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
priority:p0
priority:p1
priority:p2
priority:p3
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/fallow-ts!22
No description provided.