pdurlej/kan-ductor

Fork 0

gemini(w4): card.created toListPublicId regression fixture #120

New issue

Open

opened 2026-05-28 01:20:42 +02:00 by codex · 2 comments

codex commented

2026-05-28 01:20:42 +02:00

Collaborator

Parent: #2
Agent lane: Gemini 3.5 Flash
Wave: 4 / analytics foundation
Risk class: low

Goal

Protect analytics foundation: card creation activity must know its starting column.

Context refs

docs/agent-mcp-contract.md activity log section
packages/db/src/schema

Scope

Find existing test for card.created activity.
Assert toListName and toListPublicId are present on create.
Assert fromListName remains null.

Acceptance

Create into Captured returns toListName=Captured and stable public ID.
Move Captured -> Doing still includes from/to names and public IDs.
Metadata fields like source/sourceRef/createdByKind are preserved.

Suggested checks

Activity/recent-activity tests.

Non-goals / fences

Do not deploy, restart production, rotate secrets, or run production migrations.
Do not widen MCP write authority or public exposure.
Keep the change small enough for one focused PR or one scouting report.

Expected output

A short PR or issue comment with findings, touched files, tests run, and remaining risks.

Parent: #2 Agent lane: Gemini 3.5 Flash Wave: 4 / analytics foundation Risk class: low ## Goal Protect analytics foundation: card creation activity must know its starting column. ## Context refs - `docs/agent-mcp-contract.md` activity log section - `packages/db/src/schema` ## Scope - Find existing test for card.created activity. - Assert `toListName` and `toListPublicId` are present on create. - Assert `fromListName` remains null. ## Acceptance - Create into Captured returns `toListName=Captured` and stable public ID. - Move Captured -> Doing still includes from/to names and public IDs. - Metadata fields like source/sourceRef/createdByKind are preserved. ## Suggested checks - Activity/recent-activity tests. ## Non-goals / fences - Do not deploy, restart production, rotate secrets, or run production migrations. - Do not widen MCP write authority or public exposure. - Keep the change small enough for one focused PR or one scouting report. ## Expected output A short PR or issue comment with findings, touched files, tests run, and remaining risks.

codex added the

labels

2026-05-28 01:20:42 +02:00

codex commented

2026-06-03 10:17:20 +02:00

Author

Collaborator

Codex verification on current origin/main (966de964...): this contract is already covered; I do not see value in opening a duplicate PR.

Evidence from code/tests:

packages/db/src/repository/agent.repo.ts#getRecentCardActivity selects fromListPublicId, fromListName, toListPublicId, toListName by joining card_activity.fromListId/toListId to lists.
packages/api/src/routers/agent.ts#getRecentActivity exposes those fields in the output schema.
packages/api/src/routers/agent.test.ts has agent router > attributes card activity to the matching agent audit action, asserting:
- card.created: fromListPublicId: null, fromListName: null, toListPublicId: "captured0001", toListName: "Captured"
- card.updated.list: fromListPublicId: "captured0001", toListPublicId: "doing0000001"
packages/api/integration-tests/agent.integration.test.ts has returns create and move activity with stable list names and public IDs, asserting a real create into Captured returns toListPublicId: "captured1234", toListName: "Captured", and preserves source, sourceRef, createdByKind, and sensitivity.

Verification run:

pnpm --filter @kan/api test -- src/routers/agent.test.ts -t "attributes card activity"
pnpm --filter @kan/api exec vitest integration-tests/agent.integration.test.ts --run -t "returns create and move activity with stable list names and public IDs"

Both passed. Recommendation: close #120 as already satisfied by current main.

Codex verification on current `origin/main` (`966de964...`): this contract is already covered; I do not see value in opening a duplicate PR. Evidence from code/tests: - `packages/db/src/repository/agent.repo.ts#getRecentCardActivity` selects `fromListPublicId`, `fromListName`, `toListPublicId`, `toListName` by joining `card_activity.fromListId/toListId` to `lists`. - `packages/api/src/routers/agent.ts#getRecentActivity` exposes those fields in the output schema. - `packages/api/src/routers/agent.test.ts` has `agent router > attributes card activity to the matching agent audit action`, asserting: - `card.created`: `fromListPublicId: null`, `fromListName: null`, `toListPublicId: "captured0001"`, `toListName: "Captured"` - `card.updated.list`: `fromListPublicId: "captured0001"`, `toListPublicId: "doing0000001"` - `packages/api/integration-tests/agent.integration.test.ts` has `returns create and move activity with stable list names and public IDs`, asserting a real create into `Captured` returns `toListPublicId: "captured1234"`, `toListName: "Captured"`, and preserves `source`, `sourceRef`, `createdByKind`, and `sensitivity`. Verification run: ```bash pnpm --filter @kan/api test -- src/routers/agent.test.ts -t "attributes card activity" pnpm --filter @kan/api exec vitest integration-tests/agent.integration.test.ts --run -t "returns create and move activity with stable list names and public IDs" ``` Both passed. Recommendation: close #120 as already satisfied by current main.

Iskra commented

2026-06-18 03:08:29 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/kan-ductor#issue#120`
Priority	p2
Action	observe
Scores	reach 4 / impact 3 / confidence 5
Piotr fit	high
Effort	small
Labels	`judge/p2`
Judge	`iskra` via `openclaw`

Rationale: This is P2 observe-first analytics testing because creation activity needs stable starting-column metadata for trustworthy recent activity and flow metrics.

Caveat: Keep the fixture focused on activity metadata preservation and do not infer analytics correctness beyond the asserted create and move fields.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 5,
  "effort_hint": "small",
  "escalation": {
    "kind": "none",
    "reason": ""
  },
  "evidence_refs": [
    {
      "note": "Issue scopes a regression fixture ensuring card.created activity records its destination column name and public ID.",
      "type": "forgejo",
      "value": "issue-title-body-labels-and-target-snapshot"
    },
    {
      "note": "Body requires create activity to include toListName and toListPublicId while fromListName remains null.",
      "type": "forgejo",
      "value": "issue-body-scope-and-acceptance"
    },
    {
      "note": "Body fences the work away from production deploys, migrations, authority widening, and exposure changes.",
      "type": "forgejo",
      "value": "issue-body-non-goals"
    }
  ],
  "impact": 3,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-18T01:07:00Z",
  "labels_to_apply": [
    "judge/p2"
  ],
  "piotr_fit": "high",
  "priority": "p2",
  "rationale_summary": "This is P2 observe-first analytics testing because creation activity needs stable starting-column metadata for trustworthy recent activity and flow metrics.",
  "reach": 4,
  "recommended_next_action": "observe",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "issue",
    "number": 120,
    "repo": "pdurlej/kan-ductor"
  },
  "target_snapshot": {
    "body_hash": "sha256:044247c590c98a34d09e874424cba57c63337130af45c1d5801fab084ba360e2",
    "commit_count": null,
    "evidence_hash": "sha256:c40c5239efb4ca04b114a44d5863e4c04bfaeffe5460fcfd9588375fb590e0eb",
    "head_sha": null,
    "labels": [
      "analytics",
      "api",
      "gemini-flash",
      "priority:p2",
      "small-task",
      "tests"
    ],
    "labels_hash": "sha256:c841c9a5baba8fbddc360eeb90580cc67b988b021b00ca914362c0b85b683fc5",
    "state": "open",
    "title_hash": "sha256:98ad94f56c65f2f406f82b6883ca67ef46f98c1069f8309715047fae07af8c17",
    "updated_at": "2026-06-03T10:17:20+02:00"
  },
  "top_caveat": "Keep the fixture focused on activity metadata preservation and do not infer analytics correctness beyond the asserted create and move fields."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/kan-ductor#issue#120` | | Priority | p2 | | Action | observe | | Scores | reach 4 / impact 3 / confidence 5 | | Piotr fit | high | | Effort | small | | Labels | `judge/p2` | | Judge | `iskra` via `openclaw` | **Rationale:** This is P2 observe-first analytics testing because creation activity needs stable starting-column metadata for trustworthy recent activity and flow metrics. **Caveat:** Keep the fixture focused on activity metadata preservation and do not infer analytics correctness beyond the asserted create and move fields. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue scopes a regression fixture ensuring card.created activity records its destination column name and public ID.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body requires create activity to include toListName and toListPublicId while fromListName remains null.", "type": "forgejo", "value": "issue-body-scope-and-acceptance" }, { "note": "Body fences the work away from production deploys, migrations, authority widening, and exposure changes.", "type": "forgejo", "value": "issue-body-non-goals" } ], "impact": 3, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-18T01:07:00Z", "labels_to_apply": [ "judge/p2" ], "piotr_fit": "high", "priority": "p2", "rationale_summary": "This is P2 observe-first analytics testing because creation activity needs stable starting-column metadata for trustworthy recent activity and flow metrics.", "reach": 4, "recommended_next_action": "observe", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 120, "repo": "pdurlej/kan-ductor" }, "target_snapshot": { "body_hash": "sha256:044247c590c98a34d09e874424cba57c63337130af45c1d5801fab084ba360e2", "commit_count": null, "evidence_hash": "sha256:c40c5239efb4ca04b114a44d5863e4c04bfaeffe5460fcfd9588375fb590e0eb", "head_sha": null, "labels": [ "analytics", "api", "gemini-flash", "priority:p2", "small-task", "tests" ], "labels_hash": "sha256:c841c9a5baba8fbddc360eeb90580cc67b988b021b00ca914362c0b85b683fc5", "state": "open", "title_hash": "sha256:98ad94f56c65f2f406f82b6883ca67ef46f98c1069f8309715047fae07af8c17", "updated_at": "2026-06-03T10:17:20+02:00" }, "top_caveat": "Keep the fixture focused on activity metadata preservation and do not infer analytics correctness beyond the asserted create and move fields." }  ``` </details>

Iskra added the

judge/p2

label

2026-06-18 03:08:29 +02:00