fix(agent): report Leviathan partial apply recovery #150

Merged
pdurlej merged 1 commit from codex/leviathan-apply-partial-failure into main 2026-06-03 21:31:16 +02:00
Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Fixes #127 by making Leviathan apply results explain partial failures without scraping logs.

Scope

  • Adds task-level idempotencyKey and resumeHint fields to Leviathan apply results.
  • Keeps old batch audit replay compatibility by making the new fields optional in the output schema.
  • Centralizes apply result formatting through buildLeviathanApplyResult, so dry-run/skipped/failed/applied outputs are consistent.
  • Adds integration coverage for a partial apply where:
    • one task creates a card successfully,
    • one task fails during move because the target column is proposal_required,
    • the first write remains applied,
    • the failed task keeps card state unchanged,
    • batch audit summary and task recovery fields are recorded.
  • Documents the recovery fields in the Leviathan projection contract.

Non-goals

  • No production deploy or restart.
  • No DB schema or migration.
  • No production feature flag change.
  • No token/Infisical change.
  • No broad projection apply behavior rewrite.
  • No auto-repair or warning override change.

Spec sources read

  • #127
  • docs/leviathan-projection-contract.md
  • _bmad-output/project-context.md was not present/needed for this narrow patch.
  • packages/api/src/routers/agent.ts
  • packages/api/integration-tests/agent.integration.test.ts

Tests / smoke

  • pnpm --filter @kan/api exec vitest integration-tests/agent.integration.test.ts --run -t "reports partial Leviathan apply failures" — passed.
  • pnpm --filter @kan/api exec vitest integration-tests/agent.integration.test.ts --run — passed, 16 tests.
  • pnpm --filter @kan/api typecheck — passed.
  • pnpm exec prettier --check packages/api/src/routers/agent.ts packages/api/integration-tests/agent.integration.test.ts docs/leviathan-projection-contract.md — passed.

Rollback

Revert 875c1d4f. No data migration.

Owner gates

No production-impacting action taken. Merge decision remains with Piotr.

Canary status: missing — fire 3+3 review before merge ## Summary Fixes #127 by making Leviathan apply results explain partial failures without scraping logs. ## Scope - Adds task-level `idempotencyKey` and `resumeHint` fields to Leviathan apply results. - Keeps old batch audit replay compatibility by making the new fields optional in the output schema. - Centralizes apply result formatting through `buildLeviathanApplyResult`, so dry-run/skipped/failed/applied outputs are consistent. - Adds integration coverage for a partial apply where: - one task creates a card successfully, - one task fails during move because the target column is `proposal_required`, - the first write remains applied, - the failed task keeps card state unchanged, - batch audit summary and task recovery fields are recorded. - Documents the recovery fields in the Leviathan projection contract. ## Non-goals - No production deploy or restart. - No DB schema or migration. - No production feature flag change. - No token/Infisical change. - No broad projection apply behavior rewrite. - No auto-repair or warning override change. ## Spec sources read - #127 - `docs/leviathan-projection-contract.md` - `_bmad-output/project-context.md` was not present/needed for this narrow patch. - `packages/api/src/routers/agent.ts` - `packages/api/integration-tests/agent.integration.test.ts` ## Tests / smoke - `pnpm --filter @kan/api exec vitest integration-tests/agent.integration.test.ts --run -t "reports partial Leviathan apply failures"` — passed. - `pnpm --filter @kan/api exec vitest integration-tests/agent.integration.test.ts --run` — passed, 16 tests. - `pnpm --filter @kan/api typecheck` — passed. - `pnpm exec prettier --check packages/api/src/routers/agent.ts packages/api/integration-tests/agent.integration.test.ts docs/leviathan-projection-contract.md` — passed. ## Rollback Revert `875c1d4f`. No data migration. ## Owner gates No production-impacting action taken. Merge decision remains with Piotr.
fix(agent): report Leviathan partial apply recovery (#127)
All checks were successful
Forgejo CI / verify (pull_request) Successful in 40s
875c1d4f4d
pdurlej deleted branch codex/leviathan-apply-partial-failure 2026-06-03 21:31:16 +02:00
Sign in to join this conversation.
No reviewers
No labels
3plus3-followup
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
analytics
api
cockpit
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
docs
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
gemini-flash
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
leviathan
mcp
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
ops
priority:p0
priority:p1
priority:p2
priority:p3
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
scout
security
size/large
size/medium
size/small
size/tiny
size/unknown
small-task
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tests
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/kan-ductor!150
No description provided.