feat(mcp): expose card relation tools #35

Merged
pdurlej merged 1 commit from codex/mcp-card-relations-tools into codex/cards-lightweight-relations 2026-05-10 13:44:28 +02:00
Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Expose lightweight card relations through the Kan-ductor agent/MCP surface without expanding into generic graph management.

Scope

  • Add card_relations:write as a separate agent scope.
  • Include relation summaries in get_card_context.
  • Add agent read route for listCardRelations.
  • Add audited, idempotent single-relation action routes for link/unlink.
  • Add MCP tools: list_card_relations, link_cards, unlink_card_relation.
  • Extend the MCP smoke script with optional relation-tool smoke via KAN_SMOKE_RELATIONS=true.
  • Document relation atoms, scope rules, and owner gate.

Non-goals

  • No graph visualization.
  • No automatic relation inference.
  • No bulk relation import or rewrite.
  • No production token scope changes in this PR.

Spec sources read

  • Forgejo issue #11: mcp/card-relations-tools.
  • docs/kan-ductor-working-pr-plan.md Wave 2 relation plan.
  • Existing protected card relation API from PR #34.
  • docs/agent-mcp-contract.md direct/proposal/action boundaries.

Tests / smoke

  • pnpm --filter @kan/db build
  • pnpm --filter @kan/api build
  • pnpm --filter @kan/api typecheck
  • pnpm --filter @kan/mcp typecheck
  • pnpm --filter @kan/db typecheck
  • pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts integration-tests/card-relations.integration.test.ts
  • pnpm exec prettier --check docs/agent-mcp-contract.md scripts/kan-mcp-loop-smoke.mjs packages/api/src/routers/agent.ts packages/mcp/src/index.ts
  • node --check scripts/kan-mcp-loop-smoke.mjs
  • git diff --check

Rollback

Disable or omit card_relations:write on agent tokens; read-only relation context remains available through cards:read. If needed, remove the MCP relation tools while keeping the underlying PR #34 protected API.

Owner gates

Piotr approval required before enabling relation write scope in production MCP tokens or running production relation-write smoke.

Closes #11

Canary status: missing — fire 3+3 review before merge ## Summary Expose lightweight card relations through the Kan-ductor agent/MCP surface without expanding into generic graph management. ## Scope - Add `card_relations:write` as a separate agent scope. - Include relation summaries in `get_card_context`. - Add agent read route for `listCardRelations`. - Add audited, idempotent single-relation action routes for link/unlink. - Add MCP tools: `list_card_relations`, `link_cards`, `unlink_card_relation`. - Extend the MCP smoke script with optional relation-tool smoke via `KAN_SMOKE_RELATIONS=true`. - Document relation atoms, scope rules, and owner gate. ## Non-goals - No graph visualization. - No automatic relation inference. - No bulk relation import or rewrite. - No production token scope changes in this PR. ## Spec sources read - Forgejo issue #11: `mcp/card-relations-tools`. - `docs/kan-ductor-working-pr-plan.md` Wave 2 relation plan. - Existing protected card relation API from PR #34. - `docs/agent-mcp-contract.md` direct/proposal/action boundaries. ## Tests / smoke - `pnpm --filter @kan/db build` - `pnpm --filter @kan/api build` - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/db typecheck` - `pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts integration-tests/card-relations.integration.test.ts` - `pnpm exec prettier --check docs/agent-mcp-contract.md scripts/kan-mcp-loop-smoke.mjs packages/api/src/routers/agent.ts packages/mcp/src/index.ts` - `node --check scripts/kan-mcp-loop-smoke.mjs` - `git diff --check` ## Rollback Disable or omit `card_relations:write` on agent tokens; read-only relation context remains available through `cards:read`. If needed, remove the MCP relation tools while keeping the underlying PR #34 protected API. ## Owner gates Piotr approval required before enabling relation write scope in production MCP tokens or running production relation-write smoke. Closes #11
Author
Collaborator

3+3 Review Result

Status: NOT READY

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

  • PASS: @kan/db typecheck/build
  • PASS: @kan/shared typecheck/build
  • PASS: @kan/mcp typecheck/build
  • PASS: @kan/api typecheck/build and focused agent tests: 28/28
  • FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
  • FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

  • Tech blocker: board-scoped agent relation reads may expose related-card details from another board via get_card_context/list_card_relations. Filter/redact out-of-scope relations and bind relation-write idempotency to input.
## 3+3 Review Result Status: **NOT READY** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - Tech blocker: board-scoped agent relation reads may expose related-card details from another board via get_card_context/list_card_relations. Filter/redact out-of-scope relations and bind relation-write idempotency to input.
pdurlej merged commit 73dc38ca7d into codex/cards-lightweight-relations 2026-05-10 13:44:28 +02:00
Sign in to join this conversation.
No reviewers
No labels
3plus3-followup
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
analytics
api
cockpit
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
docs
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
gemini-flash
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
leviathan
mcp
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
ops
priority:p0
priority:p1
priority:p2
priority:p3
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
scout
security
size/large
size/medium
size/small
size/tiny
size/unknown
small-task
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tests
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/kan-ductor!35
No description provided.