feat: harden AI Inbox conventions #40

Merged

pdurlej merged 1 commit from codex/ai-inbox-conventions-hardening into codex/projection-manual-kan-drift

2026-05-10 13:46:46 +02:00

codex commented

2026-05-10 01:19:27 +02:00

Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Hardens the AI Inbox convention layer without changing production deploys or seed data. AI Inbox board/column names now live in shared constants, MCP uses the same canonical column list, agent-created AI/import cards get a visible marker comment, and tests cover metadata validation plus idempotent AI Inbox setup.

Closes #16.

Scope

Adds shared AI Inbox constants: board name, canonical columns, default column.
Uses shared constants in Integration API and MCP convenience tools.
Adds AI-origin marker comments for agent-created cards with non-human/manual metadata.
Extends create-card results with aiMarkerCommentPublicId when a marker is created.
Adds integration tests for marker comments, metadata enum rejection, create replay, and ensureDefaultAiInbox idempotency.

Non-goals

No Fastmail/Signal/Obsidian import pipelines.
No autonomous task grooming.
No production seed/deploy changes.
No schema migration.

Spec sources read

docs/agent-mcp-contract.md
Issue #16 acceptance criteria
Existing AI Inbox ensureDefaultAiInbox and MCP convenience tools
Existing metadata and card activity patterns

Tests / smoke

pnpm install
pnpm --filter @kan/shared build
pnpm --filter @kan/db build
pnpm --filter @kan/shared typecheck
pnpm --filter @kan/db typecheck
pnpm --filter @kan/api typecheck
pnpm --filter @kan/api build
pnpm --filter @kan/mcp typecheck
pnpm --filter @kan/api test -- integration-tests/agent.integration.test.ts agent.test.ts
pnpm --filter @kan/api exec eslint src/routers/agent.ts
pnpm exec prettier --check packages/shared/src/constants/ai-inbox.ts packages/shared/src/constants/index.ts packages/mcp/package.json packages/mcp/src/index.ts packages/api/src/routers/agent.ts packages/api/integration-tests/agent.integration.test.ts docs/agent-mcp-contract.md
git diff --check

Note: pnpm --filter @kan/mcp exec eslint src/index.ts is blocked by the package's current ESLint config discovery (eslint.config not found), so MCP validation used typecheck instead.

Rollback

Remove the marker-comment creation and switch MCP/API back to local AI Inbox constants. No migration rollback is needed.

Owner gates

None for this PR. Production changes to existing AI Inbox seed behavior remain owner-gated.

Canary status: missing — fire 3+3 review before merge ## Summary Hardens the AI Inbox convention layer without changing production deploys or seed data. AI Inbox board/column names now live in shared constants, MCP uses the same canonical column list, agent-created AI/import cards get a visible marker comment, and tests cover metadata validation plus idempotent AI Inbox setup. Closes #16. ## Scope - Adds shared AI Inbox constants: board name, canonical columns, default column. - Uses shared constants in Integration API and MCP convenience tools. - Adds AI-origin marker comments for agent-created cards with non-human/manual metadata. - Extends create-card results with `aiMarkerCommentPublicId` when a marker is created. - Adds integration tests for marker comments, metadata enum rejection, create replay, and `ensureDefaultAiInbox` idempotency. ## Non-goals - No Fastmail/Signal/Obsidian import pipelines. - No autonomous task grooming. - No production seed/deploy changes. - No schema migration. ## Spec sources read - `docs/agent-mcp-contract.md` - Issue #16 acceptance criteria - Existing AI Inbox `ensureDefaultAiInbox` and MCP convenience tools - Existing metadata and card activity patterns ## Tests / smoke - `pnpm install` - `pnpm --filter @kan/shared build` - `pnpm --filter @kan/db build` - `pnpm --filter @kan/shared typecheck` - `pnpm --filter @kan/db typecheck` - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/api build` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/api test -- integration-tests/agent.integration.test.ts agent.test.ts` - `pnpm --filter @kan/api exec eslint src/routers/agent.ts` - `pnpm exec prettier --check packages/shared/src/constants/ai-inbox.ts packages/shared/src/constants/index.ts packages/mcp/package.json packages/mcp/src/index.ts packages/api/src/routers/agent.ts packages/api/integration-tests/agent.integration.test.ts docs/agent-mcp-contract.md` - `git diff --check` Note: `pnpm --filter @kan/mcp exec eslint src/index.ts` is blocked by the package's current ESLint config discovery (`eslint.config` not found), so MCP validation used typecheck instead. ## Rollback Remove the marker-comment creation and switch MCP/API back to local AI Inbox constants. No migration rollback is needed. ## Owner gates None for this PR. Production changes to existing AI Inbox seed behavior remain owner-gated.

codex added 1 commit

2026-05-10 01:19:27 +02:00

feat(agent): harden ai inbox conventions 4ebbe88092

codex commented

2026-05-10 08:48:14 +02:00

Author

Collaborator

3+3 Review Result

Status: NOT READY / OWNER CHECKPOINT

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

PASS: @kan/db typecheck/build
PASS: @kan/shared typecheck/build
PASS: @kan/mcp typecheck/build
PASS: @kan/api typecheck/build and focused agent tests: 28/28
FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

Product/privacy blocker: visible AI marker comments on every AI/import card can create noise and expose sourceRef/idempotency context. Prefer audit/metadata or system-style hidden/collapsed activity; redact Signal-like refs if shown.

## 3+3 Review Result Status: **NOT READY / OWNER CHECKPOINT** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - Product/privacy blocker: visible AI marker comments on every AI/import card can create noise and expose sourceRef/idempotency context. Prefer audit/metadata or system-style hidden/collapsed activity; redact Signal-like refs if shown.