feat(executor): add guarded executor preflight contract #122

Merged

pdurlej merged 3 commits from codex/executor-preflight-contract into main

2026-06-23 18:19:21 +02:00

codex commented

2026-06-23 18:10:16 +02:00

Collaborator

Issue: #107
Value: risk
Effort: medium
Lead time: same-day

Summary

add executor-preflight-check as a read-only guarded branch/PR executor contract
preserve deterministic controller/job-plan branch names for fix/worker-loop handoffs
publish the executor preflight schema/example and update the operator status, schema inventory, architecture module inventory, and vision-gap ledger

Verification

PYTHONPATH=src:. python3 -m unittest discover -s tests
jq empty spec/schemas/executor-preflight.schema.json spec/schemas/examples/executor-preflight.ready.json spec/schemas/job-plan.schema.json spec/schemas/controller-intake.schema.json
git diff --check origin/main
PYTHONPATH=src:. python3 -m patchwarden.cli status
patchwarden contract-pr on PR #122: Vistula pass, required check success, only expected policy_governance manual tier remains

Refs #107

Issue: #107 Value: risk Effort: medium Lead time: same-day ## Summary - add `executor-preflight-check` as a read-only guarded branch/PR executor contract - preserve deterministic controller/job-plan branch names for fix/worker-loop handoffs - publish the executor preflight schema/example and update the operator status, schema inventory, architecture module inventory, and vision-gap ledger ## Verification - `PYTHONPATH=src:. python3 -m unittest discover -s tests` - `jq empty spec/schemas/executor-preflight.schema.json spec/schemas/examples/executor-preflight.ready.json spec/schemas/job-plan.schema.json spec/schemas/controller-intake.schema.json` - `git diff --check origin/main` - `PYTHONPATH=src:. python3 -m patchwarden.cli status` - `patchwarden contract-pr` on PR #122: Vistula pass, required check success, only expected `policy_governance` manual tier remains Refs #107

codex added the

labels

2026-06-23 18:10:16 +02:00

codex added 1 commit

2026-06-23 18:10:17 +02:00

feat: add executor preflight contract

fallow-py / fallow-py-advisory (pull_request) Successful in 17s

Details

3783c5653a

ollama added 2 commits

2026-06-23 18:14:30 +02:00

chore: keep executor preflight PR within contract size 8b7dc1e0fe

chore: keep executor schema inventory complete

fallow-py / fallow-py-advisory (pull_request) Successful in 16s

Details

97566ddcb5

claude commented

2026-06-23 18:18:44 +02:00

Collaborator

🏛️ Architect review (loop) — ✅ sound, safe to merge

Reviewed against D20 + D24 as the riskiest gap (PW-G011 guarded executor). It honors the "risk" tag by staying read-only + fail-closed:

No real mutation: no create_branch / push / merge / post_* / set_status calls — only a verdict. patchwarden_write_allowed=false, external_write_allowed=false, merge_allowed=false hardcoded.
Fail-closed default-deny on writes: blocks unless the upstream job-plan has materialization.write_allowed=false AND external_write_allowed=false AND the job-plan verdict is ready (job_plan_write_allowed / job_plan_external_write_allowed / job_plan_not_ready blockers).
Head-bound: _valid_sha + expected-vs-live head comparison → needs_live_state on drift.
Chains the read-only contract stack (intake → approval-preflight #121 no-self-approval → executor-preflight) with each link refusing unless the whole chain keeps writes off.
585 tests green; D20 lint passes (no merge endpoint introduced).

The decision chain is now provable end-to-end read-only before any actuator exists — textbook safe sequencing. The one thing I'll review hardest is the next PR: the real actuator that performs an actual Forgejo write (branch create / PR raise / merge) — that's where D24's mission/vision scope + hard-manual carve-out + no-self-approval get exercised live. This PR keeps that boundary clean.

No changes requested. — claude (architect loop)

## 🏛️ Architect review (loop) — ✅ sound, safe to merge Reviewed against D20 + D24 as the riskiest gap (PW-G011 guarded executor). It honors the "risk" tag by staying **read-only + fail-closed**: - **No real mutation**: no `create_branch` / `push` / `merge` / `post_*` / `set_status` calls — only a verdict. `patchwarden_write_allowed=false`, `external_write_allowed=false`, `merge_allowed=false` hardcoded. - **Fail-closed default-deny on writes**: blocks unless the upstream job-plan has `materialization.write_allowed=false` AND `external_write_allowed=false` AND the job-plan verdict is `ready` (`job_plan_write_allowed` / `job_plan_external_write_allowed` / `job_plan_not_ready` blockers). - **Head-bound**: `_valid_sha` + expected-vs-live head comparison → `needs_live_state` on drift. - **Chains the read-only contract stack** (intake → approval-preflight #121 no-self-approval → executor-preflight) with each link refusing unless the whole chain keeps writes off. - **585 tests green**; D20 lint passes (no merge endpoint introduced). The decision chain is now provable end-to-end **read-only** before any actuator exists — textbook safe sequencing. The one thing I'll review hardest is the *next* PR: the real actuator that performs an actual Forgejo write (branch create / PR raise / merge) — that's where D24's mission/vision scope + hard-manual carve-out + no-self-approval get exercised live. This PR keeps that boundary clean. No changes requested. — claude (architect loop)