feat(feedback): add post-merge feedback contract #156

Merged
pdurlej merged 1 commit from codex/post-merge-feedback into main 2026-06-23 22:57:44 +02:00
Collaborator

Summary

Closes #147.

Adds a read-only patchwarden post-merge-feedback-check contract for the June 2026 analytics feedback loop. The command consumes a passing contract-pr result, an external merge outcome, and optional post-merge signals, then emits a head-bound patchwarden.post_merge_feedback.v1 artifact with one of:

  • recorded
  • follow_up_needed
  • trust_signal
  • blocked

The contract keeps Patchwarden inside its policy/planner boundary: no issue creation, no job dispatch, no trust-state writes, no approvals, no merges, and all external write fields stay false.

What changed

  • New src/patchwarden/post_merge_feedback.py evaluator and CLI command.
  • New public schema and example under spec/schemas/.
  • New external handoff registry entry for analytics/issue/job/trust-state writers.
  • Updated patchwarden status, docs/status.html, STATUS, architecture, PR passage contracts, and June vision docs.
  • Tests for clean merge recording, follow-up candidates, trust signals, stale SHA fail-closed behavior, CLI errors, schema contracts, handoff registry, and status drift.

Verification

  • PYTHONPATH=src:. python3 -m unittest discover -s tests — 656 tests OK
  • git diff --check — clean

Boundaries

  • Read-only only.
  • Exact-head binding against the passing Contract PR head.
  • External controllers must recheck live state before persisting analytics, creating issues/jobs, or applying trust-state updates.
## Summary Closes #147. Adds a read-only `patchwarden post-merge-feedback-check` contract for the June 2026 analytics feedback loop. The command consumes a passing `contract-pr` result, an external merge outcome, and optional post-merge signals, then emits a head-bound `patchwarden.post_merge_feedback.v1` artifact with one of: - `recorded` - `follow_up_needed` - `trust_signal` - `blocked` The contract keeps Patchwarden inside its policy/planner boundary: no issue creation, no job dispatch, no trust-state writes, no approvals, no merges, and all external write fields stay false. ## What changed - New `src/patchwarden/post_merge_feedback.py` evaluator and CLI command. - New public schema and example under `spec/schemas/`. - New external handoff registry entry for analytics/issue/job/trust-state writers. - Updated `patchwarden status`, `docs/status.html`, STATUS, architecture, PR passage contracts, and June vision docs. - Tests for clean merge recording, follow-up candidates, trust signals, stale SHA fail-closed behavior, CLI errors, schema contracts, handoff registry, and status drift. ## Verification - `PYTHONPATH=src:. python3 -m unittest discover -s tests` — 656 tests OK - `git diff --check` — clean ## Boundaries - Read-only only. - Exact-head binding against the passing Contract PR head. - External controllers must recheck live state before persisting analytics, creating issues/jobs, or applying trust-state updates.
feat(feedback): add post-merge feedback contract
All checks were successful
fallow-py / fallow-py-advisory (pull_request) Successful in 15s
504cdc2df0
Author
Collaborator

Patchwarden pre-merge audit for #156:

  • Local verification: PYTHONPATH=src:. python3 -m unittest discover -s tests -> 656 tests OK.
  • Whitespace: git diff --check -> clean.
  • Forgejo head status for 504cdc2df04b0838cbe90b01e85d40e1cf136118: fallow-py / fallow-py-advisory (pull_request) -> success.
  • contract-pr dry-run with metadata-file returned policy_governance / governance_tier_path because this slice intentionally changes Patchwarden governance surfaces (src/, tests/, spec/, status/docs). This is the expected operator-owned class, not a failing check in the implementation.

Scope is aligned with #147 and the June 2026 Patchwarden mission: read-only post-merge analytics feedback contract; no issue/job/trust-state writes, no approvals, no merges from Patchwarden itself.

Patchwarden pre-merge audit for #156: - Local verification: `PYTHONPATH=src:. python3 -m unittest discover -s tests` -> 656 tests OK. - Whitespace: `git diff --check` -> clean. - Forgejo head status for `504cdc2df04b0838cbe90b01e85d40e1cf136118`: `fallow-py / fallow-py-advisory (pull_request)` -> success. - `contract-pr` dry-run with metadata-file returned `policy_governance` / `governance_tier_path` because this slice intentionally changes Patchwarden governance surfaces (`src/`, `tests/`, `spec/`, status/docs). This is the expected operator-owned class, not a failing check in the implementation. Scope is aligned with #147 and the June 2026 Patchwarden mission: read-only post-merge analytics feedback contract; no issue/job/trust-state writes, no approvals, no merges from Patchwarden itself.
pdurlej deleted branch codex/post-merge-feedback 2026-06-23 22:57:44 +02:00
Sign in to join this conversation.
No reviewers
No labels
agent/claude-code
agent/codex
agent/gemini
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
area:business-model
area:competitive
area:discovery
area:forgejo
area:metrics
area:product-strategy
area:v0-core
cagan-grade-approved
client:platform
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
kind:artifact
kind:decision
kind:dogfood
kind:epic
kind:implementation
kind:research
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
priority:p0
priority:p1
priority:p2
priority:p3
ready-for-agent
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:blocked-on-discovery
status:cagan-grade-review-pending
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:needs-operator-decision
status:operator-needed
status:parked
tier:0-anchor
tier:0-platform-substrate
tier:1-core
tier:1-iskra-value-layer
tier:2-supporting
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
wave:1-foundation
wave:2-positioning
wave:3-validation
wave:4-economics
wave:5-operating
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/patchwarden!156
No description provided.