feat(v0): add reviewer lane config loader #28

Closed
opened 2026-05-26 02:14:39 +02:00 by codex · 0 comments
Collaborator

Goal

Make reviewer lanes explicit data, not hardcoded CLI arguments. This prepares visible per-lane review artifacts without adding model calls yet.

Scope

  • Add a small TOML or JSON lane config format, for example reviewer_id, pass_kind, model_id, model_version, prompt_version, cloud_review_mode_used.
  • Add loader code with validation and tests.
  • Add review-run --lane-config <file> while preserving the current explicit-arg mode.
  • Include one example lane config for repo-pattern, anti-slop-product, and security-sentinel.

Acceptance criteria

  • A lane config can produce a valid patchwarden.review_artifact.v1 artifact.
  • Invalid/missing required lane fields fail with exit code 2 through CLI.
  • Existing review-run tests still pass.

No-go

  • No LLM API calls.
  • No prompt rendering.
  • No findings policy changes.
  • No automerge authority.

Spec sources

  • src/patchwarden/review_run.py
  • src/patchwarden/cli.py
  • spec/schemas/review-artifact.schema.json
## Goal Make reviewer lanes explicit data, not hardcoded CLI arguments. This prepares visible per-lane review artifacts without adding model calls yet. ## Scope - Add a small TOML or JSON lane config format, for example `reviewer_id`, `pass_kind`, `model_id`, `model_version`, `prompt_version`, `cloud_review_mode_used`. - Add loader code with validation and tests. - Add `review-run --lane-config <file>` while preserving the current explicit-arg mode. - Include one example lane config for `repo-pattern`, `anti-slop-product`, and `security-sentinel`. ## Acceptance criteria - A lane config can produce a valid `patchwarden.review_artifact.v1` artifact. - Invalid/missing required lane fields fail with exit code `2` through CLI. - Existing `review-run` tests still pass. ## No-go - No LLM API calls. - No prompt rendering. - No findings policy changes. - No automerge authority. ## Spec sources - `src/patchwarden/review_run.py` - `src/patchwarden/cli.py` - `spec/schemas/review-artifact.schema.json`
Sign in to join this conversation.
No labels
agent/claude-code
agent/codex
agent/gemini
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
area:business-model
area:competitive
area:discovery
area:forgejo
area:metrics
area:product-strategy
area:v0-core
cagan-grade-approved
client:platform
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
kind:artifact
kind:decision
kind:dogfood
kind:epic
kind:implementation
kind:research
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
priority:p0
priority:p1
priority:p2
priority:p3
ready-for-agent
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:blocked-on-discovery
status:cagan-grade-review-pending
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:needs-operator-decision
status:operator-needed
status:parked
tier:0-anchor
tier:0-platform-substrate
tier:1-core
tier:1-iskra-value-layer
tier:2-supporting
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
wave:1-foundation
wave:2-positioning
wave:3-validation
wave:4-economics
wave:5-operating
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/patchwarden#28
No description provided.