feat(v0): add cloud_review policy field for reviewer lanes #37

New issue

Closed

opened 2026-05-26 10:56:17 +02:00 by codex · 0 comments

codex commented

2026-05-26 10:56:17 +02:00

Collaborator

Context

Patchwarden roadmap mentions G9: add cloud_review schema field before LLM reviewer lanes. Oracle consult confirmed the smallest useful next step is one required repo-pattern/anti-slop sanity lane for boring PRs, with Patchwarden as verdict authority.

Scope

Extend reviewer lane configuration/policy bundle shape with a minimal field:

cloud_review = "allowed" # allowed | forbidden | required-with-redaction

and define the initial low-risk lane concept:

[review_lanes.repo_pattern_sanity]
enabled = true
required_for = ["safe_docs_status"]
cloud_review = "allowed"
provider = "ollama"
model = "kimi-k2.6:cloud"
fallback_model = "gemma4:31b-cloud"
timeout_seconds = 90
fail_on_missing = true
fail_on_unparseable = true

Model choice is configuration seed, not permanent policy. DeepSeek v4 Pro should remain optional/manual deep lane until reliability/cost telemetry exists.

Acceptance criteria

Policy/lane config parser accepts cloud_review with allowed values only.
Sensitive/manual classes force cloud_review=forbidden or needs_human regardless of lane config.
Missing/stale/unparseable required lane artifacts fail closed.
Optional lane failure does not block unless configured required.
Tests cover at least: safe docs allowed, workflow/runtime/secrets forbidden, invalid enum rejected.
No real model calls in this issue unless already explicitly scoped by #29/#30 sequencing.

Out of scope

Webhook service mode.
Calling Ollama Cloud.
Posting Forgejo reviews.
Merge automation expansion.
Cloud credentials/secrets.

Trace

Oracle consult: patchwarde-auditlm-boundary, 2026-05-26.
Roadmap: G9 cloud_review schema field.
Related issues: #28 reviewer lane config loader, #29 prompt rendering, #30 finding comments, #33 boring PR lifecycle fixture.

## Context Patchwarden roadmap mentions G9: add `cloud_review` schema field before LLM reviewer lanes. Oracle consult confirmed the smallest useful next step is one required repo-pattern/anti-slop sanity lane for boring PRs, with Patchwarden as verdict authority. ## Scope Extend reviewer lane configuration/policy bundle shape with a minimal field: ```toml cloud_review = "allowed" # allowed | forbidden | required-with-redaction ``` and define the initial low-risk lane concept: ```toml [review_lanes.repo_pattern_sanity] enabled = true required_for = ["safe_docs_status"] cloud_review = "allowed" provider = "ollama" model = "kimi-k2.6:cloud" fallback_model = "gemma4:31b-cloud" timeout_seconds = 90 fail_on_missing = true fail_on_unparseable = true ``` Model choice is configuration seed, not permanent policy. DeepSeek v4 Pro should remain optional/manual deep lane until reliability/cost telemetry exists. ## Acceptance criteria - [ ] Policy/lane config parser accepts `cloud_review` with allowed values only. - [ ] Sensitive/manual classes force `cloud_review=forbidden` or `needs_human` regardless of lane config. - [ ] Missing/stale/unparseable required lane artifacts fail closed. - [ ] Optional lane failure does not block unless configured required. - [ ] Tests cover at least: safe docs allowed, workflow/runtime/secrets forbidden, invalid enum rejected. - [ ] No real model calls in this issue unless already explicitly scoped by #29/#30 sequencing. ## Out of scope - Webhook service mode. - Calling Ollama Cloud. - Posting Forgejo reviews. - Merge automation expansion. - Cloud credentials/secrets. ## Trace - Oracle consult: `patchwarde-auditlm-boundary`, 2026-05-26. - Roadmap: G9 `cloud_review` schema field. - Related issues: #28 reviewer lane config loader, #29 prompt rendering, #30 finding comments, #33 boring PR lifecycle fixture.

Rows
Columns