fix(schema): review-artifact soft-fail fields + add finding-resolution schema (closes #72) #80

Merged

pdurlej merged 1 commit from gemini/issue-72 into main

2026-06-08 21:46:38 +02:00

claude commented

2026-06-08 21:43:27 +02:00

Collaborator

Authored by gemini (Gemini 3.1 Pro via Antigravity), Swarmheart worker under claude's arbitration. claude read both schema changes against the real review_run.py / resolve_findings.py output shapes and confirmed no version bump.

What

Fixes the two real contract drifts that #71's jsonschema contract test surfaced (and #62 documented via assertRaises). The schemas now match what the code actually emits.

Drift 1 — review-artifact rejected soft-fail `runtime_metadata`

review-artifact.schema.json now models the soft-fail fields review_run emits (PR #54): model_used (str), fell_back (bool), error_kind (enum transport|unparseable), error_detail (str). A real soft-fail review artifact now validates.

Drift 2 — `finding-resolution.schema.json` was missing

New schema for resolve_findings() output (patchwarden.finding_resolution.v1): verdict PASS/HOLD, findings[], blockers[] (incl. the soft_fail_review_unreliable shape with null finding_id), target, registry ids. Plus a validating example finding-resolution.hold.json.

claude's review

✅ No version bump — both stay .v1 (patchwarden.review_artifact.v1, patchwarden.finding_resolution.v1). We made the schema match what .v1 already emits, exactly as #72 required.
✅ Soft-fail fields match review_run.py; finding-resolution shape matches resolve_findings.py (verified against the source).
✅ additionalProperties: false retained → still catches future drift.
✅ Tests flipped: the two assertRaises(ValidationError) cases are now positive validate(); real PASS/HOLD/soft-fail resolve outputs validate against the new schema; deliberately-invalid cases still raise.

Arbiter verification (claude)

PYTHONPATH=src python3 -m unittest discover tests → 220/220 OK.
Scope: spec/schemas/review-artifact.schema.json (+6), spec/schemas/finding-resolution.schema.json (new +116), spec/schemas/examples/finding-resolution.hold.json (new +36), tests/test_artifact_schema_contract.py (+56). No src/ changes.
jsonschema test-only; D20 boundary passes.

Closes #72. Closes the loop opened by gemini's own #62 — the contract tests now enforce the correct contracts, not the drifted ones.

> **Authored by gemini** (Gemini 3.1 Pro via Antigravity), Swarmheart worker under claude's arbitration. claude read both schema changes against the real `review_run.py` / `resolve_findings.py` output shapes and confirmed no version bump. ## What Fixes the two real contract drifts that #71's jsonschema contract test surfaced (and #62 documented via `assertRaises`). The schemas now match what the code actually emits. ## Drift 1 — review-artifact rejected soft-fail `runtime_metadata` `review-artifact.schema.json` now models the soft-fail fields `review_run` emits (PR #54): `model_used` (str), `fell_back` (bool), `error_kind` (enum `transport`|`unparseable`), `error_detail` (str). A real soft-fail review artifact now validates. ## Drift 2 — `finding-resolution.schema.json` was missing New schema for `resolve_findings()` output (`patchwarden.finding_resolution.v1`): verdict `PASS`/`HOLD`, `findings[]`, `blockers[]` (incl. the `soft_fail_review_unreliable` shape with null `finding_id`), target, registry ids. Plus a validating example `finding-resolution.hold.json`. ## claude's review - ✅ **No version bump** — both stay `.v1` (`patchwarden.review_artifact.v1`, `patchwarden.finding_resolution.v1`). We made the schema match what `.v1` already emits, exactly as #72 required. - ✅ Soft-fail fields match `review_run.py`; finding-resolution shape matches `resolve_findings.py` (verified against the source). - ✅ `additionalProperties: false` retained → still catches future drift. - ✅ Tests flipped: the two `assertRaises(ValidationError)` cases are now positive `validate()`; real PASS/HOLD/soft-fail resolve outputs validate against the new schema; deliberately-invalid cases still raise. ## Arbiter verification (claude) - `PYTHONPATH=src python3 -m unittest discover tests` → **220/220 OK**. - Scope: `spec/schemas/review-artifact.schema.json` (+6), `spec/schemas/finding-resolution.schema.json` (new +116), `spec/schemas/examples/finding-resolution.hold.json` (new +36), `tests/test_artifact_schema_contract.py` (+56). **No `src/` changes.** - `jsonschema` test-only; D20 boundary passes. Closes #72. Closes the loop opened by gemini's own #62 — the contract tests now enforce the *correct* contracts, not the drifted ones.

Rows
Columns