feat(contract): accept required checks in contract-pr #86

Merged

pdurlej merged 1 commit from contract-pr-required-checks into main

2026-06-17 21:24:18 +02:00

codex commented

2026-06-10 23:59:58 +02:00

Collaborator

Summary

Add --required-check NAME=STATUS@SHA to patchwarden contract-pr.
Merge explicit required checks with checks loaded from PR metadata before evaluating the Contract Run.
Document why this matters for artifact-only client workflows.

Why

contract-pr can fetch Forgejo PR metadata directly, but client workflows often pre-collect metadata and call it with --metadata-file. In that artifact mode, required checks should not silently disappear just because the client did not hand-edit checks into the JSON payload. This keeps the required_checks expert usable in CI glue without reimplementing the evaluator.

Verification

PYTHONPATH=src python3 -m pytest -q tests/test_contract_pipeline.py tests/test_cli_contract_pr.py tests/test_contract_run.py tests/test_cli_evaluate.py -> 24 passed
PYTHONPATH=src python3 -m pytest -q -> 261 passed
git diff --check -> clean

Notes

No Forgejo mutation path changes.
No workflow changes in this PR.
This prepares the next platform workflow revision to pass collected statuses explicitly when fetch mode is not available.

## Summary - Add `--required-check NAME=STATUS@SHA` to `patchwarden contract-pr`. - Merge explicit required checks with checks loaded from PR metadata before evaluating the Contract Run. - Document why this matters for artifact-only client workflows. ## Why `contract-pr` can fetch Forgejo PR metadata directly, but client workflows often pre-collect metadata and call it with `--metadata-file`. In that artifact mode, required checks should not silently disappear just because the client did not hand-edit checks into the JSON payload. This keeps the `required_checks` expert usable in CI glue without reimplementing the evaluator. ## Verification - `PYTHONPATH=src python3 -m pytest -q tests/test_contract_pipeline.py tests/test_cli_contract_pr.py tests/test_contract_run.py tests/test_cli_evaluate.py` -> 24 passed - `PYTHONPATH=src python3 -m pytest -q` -> 261 passed - `git diff --check` -> clean ## Notes - No Forgejo mutation path changes. - No workflow changes in this PR. - This prepares the next platform workflow revision to pass collected statuses explicitly when fetch mode is not available.

codex added 1 commit

2026-06-10 23:59:58 +02:00

feat(contract): accept required checks in contract-pr 787424d2e2

Allow contract-pr artifact mode to receive explicit required check inputs so the required_checks expert stays active when client workflows pre-collect PR metadata.

Iskra commented

2026-06-11 03:06:41 +02:00

Collaborator

Iskra judgment

Field	Value
Target	`pdurlej/patchwarden#pull_request#86`
Priority	p2
Action	patchwarden_candidate
Scores	reach 4 / impact 4 / confidence 5
Piotr fit	high
Effort	small
Labels	`judge/p2`, `judge/patchwarden-candidate`
Judge	`iskra` via `openclaw`

Rationale: This is P2 Patchwarden-candidate work because it hardens contract-pr for artifact-only CI clients without changing Forgejo mutation paths.

Caveat: Review should confirm duplicate or conflicting required-check sources are handled predictably before merge.

Structured openclaw.judge.v0 payload

<!-- openclaw.judge.v0 -->
{
  "confidence": 5,
  "effort_hint": "small",
  "escalation": {
    "kind": "patchwarden_review",
    "reason": "This is a Patchwarden contract evaluator change with direct CI artifact workflow impact."
  },
  "evidence_refs": [
    {
      "note": "PR adds an explicit required-check argument to patchwarden contract-pr and merges it with PR metadata checks before evaluation.",
      "type": "forgejo",
      "value": "pr-title-body-labels-and-target-snapshot"
    },
    {
      "note": "Body explains artifact-only client workflows can otherwise lose required checks when using metadata files.",
      "type": "forgejo",
      "value": "pr-body-why"
    },
    {
      "note": "Verification reports focused contract tests, full pytest suite, and diff check passing.",
      "type": "check",
      "value": "pr-body-verification-summary"
    }
  ],
  "impact": 4,
  "judge_actor": {
    "name": "iskra",
    "runtime": "openclaw"
  },
  "judged_at": "2026-06-11T01:04:00Z",
  "labels_to_apply": [
    "judge/p2",
    "judge/patchwarden-candidate"
  ],
  "piotr_fit": "high",
  "priority": "p2",
  "rationale_summary": "This is P2 Patchwarden-candidate work because it hardens contract-pr for artifact-only CI clients without changing Forgejo mutation paths.",
  "reach": 4,
  "recommended_next_action": "patchwarden_candidate",
  "rerun_reason": "no_prior_judgment",
  "schema": "openclaw.judge.v0",
  "target": {
    "kind": "pull_request",
    "number": 86,
    "repo": "pdurlej/patchwarden"
  },
  "target_snapshot": {
    "body_hash": "sha256:7e33ec7e5e4136de2e9e485911f33a55deaf0598c03c18a6b20d518fc90cf653",
    "commit_count": 1,
    "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "head_sha": "787424d2e2a81c9d3c00bd1da9a1dd48193a1ccb",
    "labels": [],
    "labels_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
    "state": "open",
    "title_hash": "sha256:071b5431bad926b68922b0b6d4193c29511fcf5c371f88dad1271f01c02cdf97",
    "updated_at": "2026-06-10T23:59:58+02:00"
  },
  "top_caveat": "Review should confirm duplicate or conflicting required-check sources are handled predictably before merge."
}
<!-- /openclaw.judge.v0 -->

### Iskra judgment | Field | Value | | --- | --- | | Target | `pdurlej/patchwarden#pull_request#86` | | Priority | p2 | | Action | patchwarden_candidate | | Scores | reach 4 / impact 4 / confidence 5 | | Piotr fit | high | | Effort | small | | Labels | `judge/p2`, `judge/patchwarden-candidate` | | Judge | `iskra` via `openclaw` | **Rationale:** This is P2 Patchwarden-candidate work because it hardens contract-pr for artifact-only CI clients without changing Forgejo mutation paths. **Caveat:** Review should confirm duplicate or conflicting required-check sources are handled predictably before merge. <details> <summary>Structured openclaw.judge.v0 payload</summary> ```json  { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "patchwarden_review", "reason": "This is a Patchwarden contract evaluator change with direct CI artifact workflow impact." }, "evidence_refs": [ { "note": "PR adds an explicit required-check argument to patchwarden contract-pr and merges it with PR metadata checks before evaluation.", "type": "forgejo", "value": "pr-title-body-labels-and-target-snapshot" }, { "note": "Body explains artifact-only client workflows can otherwise lose required checks when using metadata files.", "type": "forgejo", "value": "pr-body-why" }, { "note": "Verification reports focused contract tests, full pytest suite, and diff check passing.", "type": "check", "value": "pr-body-verification-summary" } ], "impact": 4, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-11T01:04:00Z", "labels_to_apply": [ "judge/p2", "judge/patchwarden-candidate" ], "piotr_fit": "high", "priority": "p2", "rationale_summary": "This is P2 Patchwarden-candidate work because it hardens contract-pr for artifact-only CI clients without changing Forgejo mutation paths.", "reach": 4, "recommended_next_action": "patchwarden_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "pull_request", "number": 86, "repo": "pdurlej/patchwarden" }, "target_snapshot": { "body_hash": "sha256:7e33ec7e5e4136de2e9e485911f33a55deaf0598c03c18a6b20d518fc90cf653", "commit_count": 1, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": "787424d2e2a81c9d3c00bd1da9a1dd48193a1ccb", "labels": [], "labels_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "state": "open", "title_hash": "sha256:071b5431bad926b68922b0b6d4193c29511fcf5c371f88dad1271f01c02cdf97", "updated_at": "2026-06-10T23:59:58+02:00" }, "top_caveat": "Review should confirm duplicate or conflicting required-check sources are handled predictably before merge." }  ``` </details>

Iskra added the

judge/p2

judge/patchwarden-candidate

labels

2026-06-11 03:06:41 +02:00

Iskra referenced this pull request from pdurlej/judging-claw

2026-06-11 03:06:41 +02:00

[Judging Claw] patchwarden_candidate for pdurlej/patchwarden#86 (p2) #86