fix(modules): make dashboard strict-v2 healthable #255

Merged

pdurlej merged 1 commit from codex/cutover/dashboard-v2-health into main

2026-05-13 07:51:47 +02:00

codex commented

2026-05-13 07:37:41 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Canary Context Pack

Product story

The first dashboard auto-apply smoke reached the trusted plan/apply path, produced a no-op apply, and then failed at the health step because modules/dashboard/module.yaml was not strict-v2 cataloged. This PR removes that blocker so the next dashboard smoke can test the deploy pipeline instead of failing on manifest metadata.

What changed

Adds the missing strict-v2 fields for dashboard:

spec.intent.user_facing_outcome
spec.intent.acceptance_criteria
spec.runtime.image_observed
spec.runtime.image_digest_pinned_in_compose
spec.runtime.image_audit_ts
spec.runtime.image_build
spec.runtime.statefulness

Why it changed

Run #604 / API run #740 failed after plan/apply evidence was produced. The uploaded evidence showed dashboard.health.json failed only because strict-v2 validation required these fields.

Files touched

modules/dashboard/module.yaml

Relevant context

Issue #142 cutover lane
PR #251 include base/core compose files
PR #252 compose env-file preflight
PR #253 manual dashboard workflow dispatch input
PR #254 platform-host-agent compose preflight wrapper

Runtime evidence

Auto-apply run #604 artifact showed actions_planned: 0, status: noop, and health failure at manifest strict-v2 validation.
Read-only RS2000 docker inspect for home-platform-dashboard-1 reported live image ghcr.io/gethomepage/homepage:v1.10.1 with repo digest sha256:0b596092c0b55fe4c65379a428a3fe90bd192f10d1b07d189a34fe5fabe7eedb.

Known constraints

No runtime mutation in this PR.
Local platformctl health --module dashboard --json cannot fully pass from this Codex session because the local shell lacks the runner's platform-host-agent SSH capability and smoke env. The strict-v2 manifest check now passes locally.

Explicit out-of-scope

No workflow edits.
No compose edits.
No Infisical, runner, or secret changes.
No stateful service apply.

Requested decision

Merge this narrow manifest fix, then Codex will sync /opt/pdurlej-platform/current to the merge commit and rerun the dashboard workflow_dispatch smoke.

Merge blockers

Strict-v2 validation fails for dashboard.
Live image evidence is found to be wrong.

Spec sources read

modules/dashboard/module.yaml — changed manifest and existing dashboard contract.
schema/module.schema.json — strict-v2 field schema names.
control-plane/platformctl/schema.py — strict-v2 required-field behavior.
Forgejo Actions run #604 / API run #740 artifact evidence — failure cause and apply status.
RS2000 read-only docker inspect home-platform-dashboard-1 — live image digest source.

Verification

/tmp/platformctl-test-venv/bin/python -m platformctl validate --strict-v2 modules/dashboard/module.yaml
/tmp/platformctl-test-venv/bin/pytest control-plane/platformctl/tests/test_validate.py control-plane/platformctl/tests/test_health_phase3.py -q

Result: strict-v2 validation OK; 25 passed.

Refs #142

Canary status: missing — fire canary 3+3 manually before merge ## Canary Context Pack ### Product story The first dashboard auto-apply smoke reached the trusted plan/apply path, produced a no-op apply, and then failed at the health step because `modules/dashboard/module.yaml` was not strict-v2 cataloged. This PR removes that blocker so the next dashboard smoke can test the deploy pipeline instead of failing on manifest metadata. ### What changed Adds the missing strict-v2 fields for `dashboard`: - `spec.intent.user_facing_outcome` - `spec.intent.acceptance_criteria` - `spec.runtime.image_observed` - `spec.runtime.image_digest_pinned_in_compose` - `spec.runtime.image_audit_ts` - `spec.runtime.image_build` - `spec.runtime.statefulness` ### Why it changed Run #604 / API run #740 failed after plan/apply evidence was produced. The uploaded evidence showed `dashboard.health.json` failed only because strict-v2 validation required these fields. ### Files touched - `modules/dashboard/module.yaml` ### Relevant context - Issue #142 cutover lane - PR #251 include base/core compose files - PR #252 compose env-file preflight - PR #253 manual dashboard workflow dispatch input - PR #254 platform-host-agent compose preflight wrapper ### Runtime evidence - Auto-apply run #604 artifact showed `actions_planned: 0`, `status: noop`, and health failure at manifest strict-v2 validation. - Read-only RS2000 `docker inspect` for `home-platform-dashboard-1` reported live image `ghcr.io/gethomepage/homepage:v1.10.1` with repo digest `sha256:0b596092c0b55fe4c65379a428a3fe90bd192f10d1b07d189a34fe5fabe7eedb`. ### Known constraints - No runtime mutation in this PR. - Local `platformctl health --module dashboard --json` cannot fully pass from this Codex session because the local shell lacks the runner's `platform-host-agent` SSH capability and smoke env. The strict-v2 manifest check now passes locally. ### Explicit out-of-scope - No workflow edits. - No compose edits. - No Infisical, runner, or secret changes. - No stateful service apply. ### Requested decision Merge this narrow manifest fix, then Codex will sync `/opt/pdurlej-platform/current` to the merge commit and rerun the dashboard workflow_dispatch smoke. ### Merge blockers - Strict-v2 validation fails for `dashboard`. - Live image evidence is found to be wrong. ## Spec sources read - `modules/dashboard/module.yaml` — changed manifest and existing dashboard contract. - `schema/module.schema.json` — strict-v2 field schema names. - `control-plane/platformctl/schema.py` — strict-v2 required-field behavior. - Forgejo Actions run #604 / API run #740 artifact evidence — failure cause and apply status. - RS2000 read-only `docker inspect home-platform-dashboard-1` — live image digest source. ## Verification ```bash /tmp/platformctl-test-venv/bin/python -m platformctl validate --strict-v2 modules/dashboard/module.yaml /tmp/platformctl-test-venv/bin/pytest control-plane/platformctl/tests/test_validate.py control-plane/platformctl/tests/test_health_phase3.py -q ``` Result: strict-v2 validation OK; 25 passed. Refs #142

codex added 1 commit

2026-05-13 07:37:41 +02:00

fix(modules): make dashboard strict-v2 healthable

canary-required / collect-diff (pull_request) Successful in 4s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 19s

Details

canary-required / canary (pull_request) Successful in 13s

Details

base-is-main / guard (pull_request) Successful in 1s

Details

0f1a49bbcd