fix(modules): keep mirotalk-sfu strict-v2 valid #258

Merged

pdurlej merged 1 commit from codex/cutover/mirotalk-sfu-strict-v2 into main

2026-05-13 18:27:08 +02:00

codex commented

2026-05-13 08:59:03 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Canary Context Pack

Product story

F1.5 corrected target mirotalk-sfu is stateless and safe for a no-op smoke, but strict-v2 validation was blocked by an overlong user-facing outcome string. This PR makes the manifest validate without changing runtime truth.

What changed

Shortened spec.intent.user_facing_outcome for mirotalk-sfu.
No runtime, exposure, health, image, statefulness, or dependency fields changed.

Why it changed

platformctl validate --strict-v2 modules/mirotalk-sfu/module.yaml failed because the outcome exceeded the schema length limit.

Files touched

modules/mirotalk-sfu/module.yaml

Relevant context

Issue #142 cutover lane
Pan Herbatka F1.5 correction: mirotalk-sfu is a verified stateless target
Prior dashboard smoke run #621 / API #757

Runtime evidence

No runtime mutation in this PR. Existing module/runbook classify mirotalk-sfu as stateless with no volumes.

Known constraints

This PR only unblocks strict-v2 validation before no-op smoke.
Smoke is still separate and will run only after this lands on main.

Explicit out-of-scope

No production apply.
No compose changes.
No exposure policy change.
No stateful work.

Requested decision

Merge so Codex can resume F1.5 mirotalk-sfu no-op smoke.

Merge blockers

Strict-v2 validation fails.
Review finds the shortened outcome lost material operator meaning.

Spec sources read

modules/mirotalk-sfu/module.yaml — changed manifest.
modules/mirotalk-sfu/runbook.md — confirmed stateless/no volumes context.
prompts/codex-f1.5-hardening-f2-2026-05-13.md plus inline correction — target selection and procedure.

Verification

/tmp/platformctl-test-venv/bin/python -m platformctl validate --strict-v2 modules/mirotalk-sfu/module.yaml
/tmp/platformctl-test-venv/bin/pytest control-plane/platformctl/tests/test_validate.py control-plane/platformctl/tests/test_health_phase3.py -q

Result: strict-v2 validation OK; 25 passed.

Refs #142

Canary status: missing — fire canary 3+3 manually before merge ## Canary Context Pack ### Product story F1.5 corrected target `mirotalk-sfu` is stateless and safe for a no-op smoke, but strict-v2 validation was blocked by an overlong user-facing outcome string. This PR makes the manifest validate without changing runtime truth. ### What changed - Shortened `spec.intent.user_facing_outcome` for `mirotalk-sfu`. - No runtime, exposure, health, image, statefulness, or dependency fields changed. ### Why it changed `platformctl validate --strict-v2 modules/mirotalk-sfu/module.yaml` failed because the outcome exceeded the schema length limit. ### Files touched - `modules/mirotalk-sfu/module.yaml` ### Relevant context - Issue #142 cutover lane - Pan Herbatka F1.5 correction: `mirotalk-sfu` is a verified stateless target - Prior dashboard smoke run #621 / API #757 ### Runtime evidence No runtime mutation in this PR. Existing module/runbook classify `mirotalk-sfu` as stateless with no volumes. ### Known constraints - This PR only unblocks strict-v2 validation before no-op smoke. - Smoke is still separate and will run only after this lands on `main`. ### Explicit out-of-scope - No production apply. - No compose changes. - No exposure policy change. - No stateful work. ### Requested decision Merge so Codex can resume F1.5 `mirotalk-sfu` no-op smoke. ### Merge blockers - Strict-v2 validation fails. - Review finds the shortened outcome lost material operator meaning. ## Spec sources read - `modules/mirotalk-sfu/module.yaml` — changed manifest. - `modules/mirotalk-sfu/runbook.md` — confirmed stateless/no volumes context. - `prompts/codex-f1.5-hardening-f2-2026-05-13.md` plus inline correction — target selection and procedure. ## Verification ```bash /tmp/platformctl-test-venv/bin/python -m platformctl validate --strict-v2 modules/mirotalk-sfu/module.yaml /tmp/platformctl-test-venv/bin/pytest control-plane/platformctl/tests/test_validate.py control-plane/platformctl/tests/test_health_phase3.py -q ``` Result: strict-v2 validation OK; 25 passed. Refs #142

codex added 1 commit

2026-05-13 08:59:03 +02:00

fix(modules): keep mirotalk-sfu strict-v2 valid

canary-required / collect-diff (pull_request) Successful in 4s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 19s

Details

canary-required / canary (pull_request) Successful in 13s

Details

base-is-main / guard (pull_request) Successful in 1s

Details

c2b8633c7b