pdurlej/platform

Fork 0

fix(modules): remove uniform agent_context_budget:1500 stamp from 80 manifests #331

Closed

claude wants to merge 1 commit from claude/d/agent-context-budget-schema-default into main

claude commented

2026-05-17 17:46:39 +02:00

Collaborator

Summary

DeepSeek deep review 2026-05-14, finding #6: every of 80 module manifests carries identical agent_context_budget: 1500. Per DeepSeek: "if the budget is always 1500, it's a constant, not a per-module parameter".

What

Removes agent_context_budget: 1500 line from all 80 manifests (uniform stamp, no signal)
Updates schema/module.schema.md to instruct: omit from manifest when 1500 suffices; specify only when actual budget differs

Why this is safe

Field is optional in schema/module.schema.json (default: 1500)
No runtime code reads it (verified via grep -rn 'agent_context_budget' control-plane/platformctl/ → only test fixtures, intentional)
Test fixtures keep their copies
All 80 module.yaml files parse via yaml.safe_load post-change (verified)

Why per ADR-0018

This is exactly the "platform telling agents something it doesn't actually use" pattern. Future cousins reading 80× '1500' would either tune toward the constant (wrong) or learn to ignore the field (also wrong) — both outcomes degrade agent-readable system state.

Tier

Lite per ADR-0007 — single mechanical concern, 80 trivial deletions, docs-only change to schema spec markdown.

Verification

# Before:
grep -l 'agent_context_budget: 1500' modules/*/module.yaml | wc -l
# 80

# After:
grep -l 'agent_context_budget:' modules/*/module.yaml | wc -l
# 0

# Parse check:
python3 -c "import yaml; [yaml.safe_load(open(f'modules/{m}/module.yaml')) for m in __import__('os').listdir('modules')]"
# all module.yaml parse OK

Refs DeepSeek deep review 2026-05-14 finding #6 (state/deep-reviews/2026-05-14-platform-deep-review.md)

## Summary DeepSeek deep review 2026-05-14, finding #6: every of 80 module manifests carries identical `agent_context_budget: 1500`. Per DeepSeek: *"if the budget is always 1500, it's a constant, not a per-module parameter"*. ## What - Removes ` agent_context_budget: 1500` line from all 80 manifests (uniform stamp, no signal) - Updates `schema/module.schema.md` to instruct: omit from manifest when 1500 suffices; specify only when actual budget differs ## Why this is safe - Field is **optional** in `schema/module.schema.json` (default: 1500) - No runtime code reads it (verified via `grep -rn 'agent_context_budget' control-plane/platformctl/` → only test fixtures, intentional) - Test fixtures keep their copies - All 80 `module.yaml` files parse via `yaml.safe_load` post-change (verified) ## Why per ADR-0018 This is exactly the "platform telling agents something it doesn't actually use" pattern. Future cousins reading 80× '1500' would either tune toward the constant (wrong) or learn to ignore the field (also wrong) — both outcomes degrade agent-readable system state. ## Tier **Lite** per ADR-0007 — single mechanical concern, 80 trivial deletions, docs-only change to schema spec markdown. ## Verification ```bash # Before: grep -l 'agent_context_budget: 1500' modules/*/module.yaml | wc -l # 80 # After: grep -l 'agent_context_budget:' modules/*/module.yaml | wc -l # 0 # Parse check: python3 -c "import yaml; [yaml.safe_load(open(f'modules/{m}/module.yaml')) for m in __import__('os').listdir('modules')]" # all module.yaml parse OK ``` Refs DeepSeek deep review 2026-05-14 finding #6 (state/deep-reviews/2026-05-14-platform-deep-review.md)

claude added 1 commit

2026-05-17 17:46:39 +02:00

fix(modules): remove uniform agent_context_budget:1500 stamp from 80 manifests

base-is-main / guard (pull_request) Successful in 1s

Details

canary-required / collect-diff (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 3s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 21s

Details

python-ci / Python 3.11 (pull_request) Successful in 36s

Details

python-ci / Python 3.12 (pull_request) Successful in 40s

Details

python-ci / Python 3.13 (pull_request) Successful in 37s

Details

canary-required / canary (pull_request) Successful in 12s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 20s

Details

a9463c3399

DeepSeek deep review 2026-05-14, finding #6: every of the 80 module
manifests carried identical agent_context_budget:1500. Per DeepSeek:
"if the budget is always 1500, it's a constant, not a per-module
parameter".

Field is optional in schema/module.schema.json (default:1500). No
runtime code reads the value (verified via grep across control-plane/);
test fixtures keep their copies intentionally. Removing the line from
manifests has zero behavior impact and removes metadata theatre.

Schema doc (schema/module.schema.md) updated to instruct: omit from
manifest when 1500 suffices; specify only when actual budget differs.

Per ADR-0018: this is exactly the "platform telling agents
something it doesn't actually use" pattern. Future cousins reading
80× '1500' would either tune toward the constant (wrong) or learn
to ignore the field (also wrong).

Tier: Lite per ADR-0007 (single mechanical concern, 80 trivial deletions,
docs-only change to schema spec markdown).

Verification:
  grep -l "agent_context_budget: 1500" modules/*/module.yaml | wc -l
  # before: 80
  # after: 0
  all module.yaml parse via yaml.safe_load (verified)

Refs DeepSeek finding #6

codex commented

2026-05-24 08:03:38 +02:00

Collaborator

Fork C triage result: keep as merge candidate, not rewrite. Evidence checked from live Forgejo/main: PR is mergeable and green; merge-base diff is 81 files, mechanically removing uniform spec.agent_context_budget: 1500 plus the schema doc clarification. Current main still has 82 uniform stamps; the PR branch has 0. Validation: cd control-plane && uv run platformctl validate all => exitCode=0, 82 results, 0 failed. Recommendation: operator may merge #331 as a Full-tier metadata cleanup if required checks remain green; splitting would leave mixed metadata semantics and add churn without reducing meaningful runtime risk. No production touch.

codex referenced this pull request

2026-05-27 08:45:08 +02:00

docs(w9): rewrite stale charter topology #517

codex referenced this pull request

2026-05-27 08:49:30 +02:00

fix(modules): remove default context-budget stamps #518

codex commented

2026-05-27 08:49:48 +02:00

Collaborator

W9 rewrite/archive triage: closing this stale branch because the useful mechanical cleanup was rewritten from current main in #518. #518 preserves the schema default, keeps non-default 1800 budgets, and validates cleanly.

codex closed this pull request

2026-05-27 08:49:48 +02:00