docs(review): define non-author AI approval policy #450

Merged
pdurlej merged 1 commit from codex/w6-reviewer-safety-policy into main 2026-05-24 22:20:15 +02:00
Collaborator

Canary status: missing — rely on required Forgejo checks before merge

Canary Context Pack

Product story

W6 is preparing the platform for faster AI-assisted review and eventually narrower autonomous merge classes. Before any merge automation can exist, the platform needs a clear rule for when an AI review counts and when it is only advisory.

What changed

Added docs/ci/ai-review-governance.md defining:

  • mandatory non-author counted review baseline;
  • current behavior / target behavior / not-yet-allowed table;
  • counted AI approval contract;
  • self-approval rule;
  • required PR metadata before AI approval can count;
  • security-sensitive exception;
  • future autonomous merge preconditions;
  • sibling-repo rollout notes.

Why it changed

Issue #75 asks for global governance around non-author AI reviewers and branch protection. This PR captures the policy baseline without enabling automerge or changing branch protection.

Files touched

  • docs/ci/ai-review-governance.md

Relevant context

  • Issue #75
  • AGENTS.md canary/risk-tier/security-sensitive review rules
  • docs/forgejo-agent-operations.md identity and PR rules
  • .forgejo/pull_request_template.md
  • W6 reviewer safety lane

Runtime evidence

Runtime mutation: none. Docs-only policy PR.

Known constraints

This PR deliberately does not enforce the rule mechanically. Fork B/W6c is expected to handle security-sensitive routing mechanics; Fork A/W6a handles required-check evidence; Fork C/W6b handles actor identity boundaries.

Explicit out-of-scope

  • No automerge.
  • No branch-protection changes.
  • No Forgejo API mutation except creating this PR as codex.
  • No workflow changes.
  • No state/STATUS_NOW.md edit.

Requested decision

Merge this as the policy baseline for W6 reviewer safety if checks are green.

Merge blockers

  • The policy weakens identity isolation.
  • The policy implies autonomous merge is allowed now.
  • git diff --check fails.

Spec sources read

  • Issue #75 via Forgejo API
  • AGENTS.md review/risk/security-sensitive sections
  • .forgejo/pull_request_template.md
  • docs/forgejo-agent-operations.md
  • .forgejo/workflows/canary-required.yml
  • .forgejo/workflows/patchwarden-pr-sanity.yml

Test plan

  • git diff --check → clean

Refs #75

Canary status: missing — rely on required Forgejo checks before merge ## Canary Context Pack ### Product story W6 is preparing the platform for faster AI-assisted review and eventually narrower autonomous merge classes. Before any merge automation can exist, the platform needs a clear rule for when an AI review counts and when it is only advisory. ### What changed Added `docs/ci/ai-review-governance.md` defining: - mandatory non-author counted review baseline; - current behavior / target behavior / not-yet-allowed table; - counted AI approval contract; - self-approval rule; - required PR metadata before AI approval can count; - security-sensitive exception; - future autonomous merge preconditions; - sibling-repo rollout notes. ### Why it changed Issue #75 asks for global governance around non-author AI reviewers and branch protection. This PR captures the policy baseline without enabling automerge or changing branch protection. ### Files touched - `docs/ci/ai-review-governance.md` ### Relevant context - Issue #75 - `AGENTS.md` canary/risk-tier/security-sensitive review rules - `docs/forgejo-agent-operations.md` identity and PR rules - `.forgejo/pull_request_template.md` - W6 reviewer safety lane ### Runtime evidence Runtime mutation: none. Docs-only policy PR. ### Known constraints This PR deliberately does not enforce the rule mechanically. Fork B/W6c is expected to handle security-sensitive routing mechanics; Fork A/W6a handles required-check evidence; Fork C/W6b handles actor identity boundaries. ### Explicit out-of-scope - No automerge. - No branch-protection changes. - No Forgejo API mutation except creating this PR as `codex`. - No workflow changes. - No `state/STATUS_NOW.md` edit. ### Requested decision Merge this as the policy baseline for W6 reviewer safety if checks are green. ### Merge blockers - The policy weakens identity isolation. - The policy implies autonomous merge is allowed now. - `git diff --check` fails. ## Spec sources read - Issue #75 via Forgejo API - `AGENTS.md` review/risk/security-sensitive sections - `.forgejo/pull_request_template.md` - `docs/forgejo-agent-operations.md` - `.forgejo/workflows/canary-required.yml` - `.forgejo/workflows/patchwarden-pr-sanity.yml` ## Test plan - `git diff --check` → clean Refs #75
docs(review): define non-author AI approval policy
All checks were successful
base-is-main / guard (pull_request) Successful in 1s
canary-required / collect-diff (pull_request) Successful in 4s
infra-docs-drift / docs-drift (pull_request) Successful in 5s
patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s
workflow-lint / lint (pull_request) Successful in 4s
canary-required / canary (pull_request) Has been skipped
patchwarden-pr-sanity / sanity (pull_request) Successful in 23s
bf3a1a4b66
Sign in to join this conversation.
No reviewers
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!450
No description provided.