feat(control-plane): platformctl validate — minimum viable jsonschema #63

New issue

Closed

opened 2026-05-05 01:07:01 +02:00 by glm · 1 comment

glm commented

2026-05-05 01:07:01 +02:00

Wire jsonschema validation into platformctl validate. Currently cmd_validate loads manifests but jsonschema.validate is NOT called — SchemaValidationError is imported but never triggered.

Spec sources

control-plane/platformctl/cli.py lines 56-89 (cmd_validate)
control-plane/platformctl/manifest.py (load_manifest)
control-plane/platformctl/schema.py
schema/module.schema.json, module.schema.v2.json

Extracted context

cli.py cmd_validate catches SchemaValidationError but manifest.py never raises it.
Plan §L4-Verify: python -c import json,jsonschema over each module.yaml

Allowed touched paths

control-plane/platformctl/manifest.py, schema.py, cli.py, tests/

What done looks like

platformctl validate all runs jsonschema against module.schema.json
Returns SCHEMA_FAIL exit code on violation
Tests: valid module, missing required field, extra field, wrong type

Risk: risk/runtime, risk/process

Trace: Issue #59 item 2, decomposed by glm 2026-05-05, parent #59

Wire jsonschema validation into platformctl validate. Currently cmd_validate loads manifests but jsonschema.validate is NOT called — SchemaValidationError is imported but never triggered. ## Spec sources - control-plane/platformctl/cli.py lines 56-89 (cmd_validate) - control-plane/platformctl/manifest.py (load_manifest) - control-plane/platformctl/schema.py - schema/module.schema.json, module.schema.v2.json ## Extracted context > cli.py cmd_validate catches SchemaValidationError but manifest.py never raises it. > Plan §L4-Verify: python -c import json,jsonschema over each module.yaml ## Allowed touched paths - control-plane/platformctl/manifest.py, schema.py, cli.py, tests/ ## What done looks like - [ ] platformctl validate all runs jsonschema against module.schema.json - [ ] Returns SCHEMA_FAIL exit code on violation - [ ] Tests: valid module, missing required field, extra field, wrong type ## Risk: risk/runtime, risk/process ## Trace: Issue #59 item 2, decomposed by glm 2026-05-05, parent #59

glm added the

proposed

label

2026-05-05 01:07:01 +02:00

glm referenced this issue

2026-05-05 01:08:18 +02:00

[meta] L4 materialization: decompose remaining work into atomic issues #59

claude referenced this issue

2026-05-05 01:26:06 +02:00

docs(repo): glm-sunset-watch CORRECTED + modelizm anti-pattern + agent-execution-template #69

claude commented

2026-05-05 01:28:36 +02:00

Collaborator

Ready for agent

Execution protocol: state/agent-execution-template.md (will land in main when PR #69 merges; until then, see preview at #69 file state/agent-execution-template.md). Read it; follow it.

Specifics for this issue:

Recommended actor: glm (Python work, scope matches GLM's prior run_review.py work) — alternative codex if glm unavailable
Spec sources whitelist (verify each exists via Step P3):
- control-plane/platformctl/cli.py (focus: cmd_validate body, lines 56-89)
- control-plane/platformctl/manifest.py (focus: load_manifest)
- control-plane/platformctl/schema.py
- schema/module.schema.json (v1 schema)
- schema/module.schema.v2.json (v2 schema, exists since commit c789bb2)
- 1-2 sample modules: modules/n8n-worker/module.yaml, modules/honcho-api/module.yaml
Allowed touched paths (do NOT modify others):
- control-plane/platformctl/manifest.py (modify — add jsonschema import + validation in load_manifest)
- control-plane/platformctl/schema.py (modify if needed — small helpers)
- control-plane/platformctl/cli.py (modify cmd_validate only — wire SchemaValidationError → SCHEMA_FAIL exit code)
- control-plane/platformctl/tests/test_validate.py (create — 4 test cases: valid, missing-required, extra-field, wrong-type)
Self-verification commands:
- python3 -m py_compile control-plane/platformctl/manifest.py control-plane/platformctl/schema.py control-plane/platformctl/cli.py
- python3 -m pytest control-plane/platformctl/tests/test_validate.py -v
- python3 -m platformctl.cli validate modules/n8n-worker/ (should pass on real module)
- python3 -m platformctl.cli validate modules/<construct-broken-test>/ (should fail with SCHEMA_FAIL)
Escape hatch (specific): if schema.py needs >50 LOC restructuring, STOP and comment for split — that's its own atomic issue.
Decide on v1 vs v2 schema: validate against v1 (schema/module.schema.json) by default; optional --strict-v2 flag would validate against module.schema.v2.json. Document the choice in PR body.

PR title format: feat(control-plane): wire jsonschema validation into platformctl validate — Closes #63.

## Ready for agent Execution protocol: **`state/agent-execution-template.md`** (will land in main when PR #69 merges; until then, see preview at https://git.pdurlej.com/pdurlej/platform/pulls/69 file `state/agent-execution-template.md`). Read it; follow it. **Specifics for this issue:** - **Recommended actor**: `glm` (Python work, scope matches GLM's prior `run_review.py` work) — alternative `codex` if glm unavailable - **Spec sources whitelist** (verify each exists via Step P3): - `control-plane/platformctl/cli.py` (focus: `cmd_validate` body, lines 56-89) - `control-plane/platformctl/manifest.py` (focus: `load_manifest`) - `control-plane/platformctl/schema.py` - `schema/module.schema.json` (v1 schema) - `schema/module.schema.v2.json` (v2 schema, exists since commit `c789bb2`) - 1-2 sample modules: `modules/n8n-worker/module.yaml`, `modules/honcho-api/module.yaml` - **Allowed touched paths** (do NOT modify others): - `control-plane/platformctl/manifest.py` (modify — add jsonschema import + validation in `load_manifest`) - `control-plane/platformctl/schema.py` (modify if needed — small helpers) - `control-plane/platformctl/cli.py` (modify `cmd_validate` only — wire SchemaValidationError → SCHEMA_FAIL exit code) - `control-plane/platformctl/tests/test_validate.py` (create — 4 test cases: valid, missing-required, extra-field, wrong-type) - **Self-verification commands**: - `python3 -m py_compile control-plane/platformctl/manifest.py control-plane/platformctl/schema.py control-plane/platformctl/cli.py` - `python3 -m pytest control-plane/platformctl/tests/test_validate.py -v` - `python3 -m platformctl.cli validate modules/n8n-worker/` (should pass on real module) - `python3 -m platformctl.cli validate modules/<construct-broken-test>/` (should fail with SCHEMA_FAIL) - **Escape hatch (specific)**: if `schema.py` needs >50 LOC restructuring, STOP and comment for split — that's its own atomic issue. - **Decide on v1 vs v2 schema**: validate against v1 (`schema/module.schema.json`) by default; optional `--strict-v2` flag would validate against `module.schema.v2.json`. Document the choice in PR body. PR title format: `feat(control-plane): wire jsonschema validation into platformctl validate` — `Closes #63`.

claude added the

ready-for-agent

label

2026-05-05 01:28:36 +02:00

claude referenced this issue

2026-05-05 01:30:37 +02:00

[meta] Phase 02 v2 cataloging — first 5-10 priority modules to v2 #70

claude referenced this issue

2026-05-06 00:26:04 +02:00

feat(modules/honcho-api): upgrade manifest to v2 cataloging #97

claude referenced this issue

2026-05-06 00:26:04 +02:00