fix(ci): standardize step-output writes to use FORGEJO_OUTPUT fallback #755

New issue

Closed

opened 2026-06-08 23:07:57 +02:00 by ollama · 1 comment

ollama commented

2026-06-08 23:07:57 +02:00

Collaborator

Spec sources (whitelist)

.forgejo/workflows/base-is-main.yml — bare $GITHUB_OUTPUT usage
.forgejo/workflows/w8-uptime-kuma-runtime-pilot.yml — same
.forgejo/workflows/merged-in-main-audit.yml — same
.forgejo/workflows/platformctl-auto-apply.yml — same
.forgejo/workflows/canary-required.yml — reference: already uses ${FORGEJO_OUTPUT:-$GITHUB_OUTPUT} (correct)
.forgejo/workflows/patchwarden-client-dry-run.yml — reference: already uses correct pattern

Extracted context

4 workflow files write bare $GITHUB_OUTPUT:

echo "key=value" >> $GITHUB_OUTPUT

The cross-platform pattern used by canary-required.yml and patchwarden-client-dry-run.yml is:

echo "key=value" >> ${FORGEJO_OUTPUT:-$GITHUB_OUTPUT}

This ensures compatibility with both GitHub and Forgejo runners.

Scope

In all 4 workflow files, replace bare $GITHUB_OUTPUT with ${FORGEJO_OUTPUT:-$GITHUB_OUTPUT}.

Search pattern (to verify count): rg '\$GITHUB_OUTPUT' .forgejo/workflows/ --include '*.yml' | grep -v FORGEJO_OUTPUT

Acceptance criteria

0 bare $GITHUB_OUTPUT references (without FORGEJO_OUTPUT fallback)
All references use ${FORGEJO_OUTPUT:-$GITHUB_OUTPUT}
Workflow YAML still syntactically valid

Do NOT read

Full repo — only the 6 files listed above

Agent notes

Recommended executor: Gemini 3.5 Flash
Size: Trivial (~8 LOC)
Review tier: tier/trivial
Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §D3
This is a subset of #729 item 2 (claude's deslop issue)

## Spec sources (whitelist) - `.forgejo/workflows/base-is-main.yml` — bare `$GITHUB_OUTPUT` usage - `.forgejo/workflows/w8-uptime-kuma-runtime-pilot.yml` — same - `.forgejo/workflows/merged-in-main-audit.yml` — same - `.forgejo/workflows/platformctl-auto-apply.yml` — same - `.forgejo/workflows/canary-required.yml` — reference: already uses `${FORGEJO_OUTPUT:-$GITHUB_OUTPUT}` (correct) - `.forgejo/workflows/patchwarden-client-dry-run.yml` — reference: already uses correct pattern ## Extracted context 4 workflow files write bare `$GITHUB_OUTPUT`: ```yaml echo "key=value" >> $GITHUB_OUTPUT ``` The cross-platform pattern used by canary-required.yml and patchwarden-client-dry-run.yml is: ```yaml echo "key=value" >> ${FORGEJO_OUTPUT:-$GITHUB_OUTPUT} ``` This ensures compatibility with both GitHub and Forgejo runners. ## Scope In all 4 workflow files, replace bare `$GITHUB_OUTPUT` with `${FORGEJO_OUTPUT:-$GITHUB_OUTPUT}`. Search pattern (to verify count): `rg '\$GITHUB_OUTPUT' .forgejo/workflows/ --include '*.yml' | grep -v FORGEJO_OUTPUT` ## Acceptance criteria - [ ] 0 bare `$GITHUB_OUTPUT` references (without FORGEJO_OUTPUT fallback) - [ ] All references use `${FORGEJO_OUTPUT:-$GITHUB_OUTPUT}` - [ ] Workflow YAML still syntactically valid ## Do NOT read - Full repo — only the 6 files listed above ## Agent notes - Recommended executor: Gemini 3.5 Flash - Size: Trivial (~8 LOC) - Review tier: tier/trivial - Audit ref: state/audit/deepseek-2026-06-08-multiperspective.md §D3 - This is a subset of #729 item 2 (claude's deslop issue)

ollama referenced this issue

2026-06-08 23:09:24 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

pdurlej added the

safety:no-prod-mutation

size/small

status:codex-ready

labels

2026-06-17 23:35:33 +02:00

pdurlej referenced this issue

2026-06-17 23:35:38 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

pdurlej commented

2026-06-17 23:43:03 +02:00

Owner

Closing as already implemented on current main. Evidence: workflow writes now use ; targeted scan for bare writes without FORGEJO_OUTPUT returned no matches. Verification: full platformctl test suite passed with UV_CACHE_DIR=/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests -q -> 756 passed.

Closing as already implemented on current main. Evidence: workflow writes now use ``; targeted scan for bare `` writes without `FORGEJO_OUTPUT` returned no matches. Verification: full `platformctl` test suite passed with `UV_CACHE_DIR=/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests -q` -> `756 passed`.

pdurlej closed this issue

2026-06-17 23:43:03 +02:00

pdurlej referenced this issue

2026-06-18 00:06:36 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766