fix(auto-apply): target manual dispatch module #253

Merged

pdurlej merged 1 commit from codex/cutover/manual-dashboard-dispatch into main

2026-05-13 07:08:04 +02:00

codex commented

2026-05-13 07:05:34 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Canary Context Pack

Product story

Piotr gave apply ✅ for the first RS2000 dashboard smoke, but the active workflow could not actually target dashboard: workflow_dispatch had no module input and would classify the latest control-plane merge diff instead. This PR makes the manual smoke path explicit and fail-closed.

What changed

Added workflow_dispatch.inputs.module, defaulting to dashboard.
Added auto_apply_scope.py --module <id> to classify an explicit trusted-main module target.
Updated the auto-apply workflow so manual dispatch uses the requested module instead of the last merge diff.
Added tests for manual module changed-file synthesis and workflow contract markers.

Why it changed

Pre-Phase-4 inspection showed that triggering the existing workflow would not prove dashboard cutover. It would inspect #252's control-plane/** changes and block. The apply ✅ needs a safe target, not a noisy failed run.

Files touched

.forgejo/workflows/platformctl-auto-apply.yml
control-plane/platformctl/ci/auto_apply_scope.py
control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py

Relevant context

Issue #142 cutover lane
PR #251 compose include fix
PR #252 env-file/preflight apply support
docs/ci/runner-contract.md

Runtime evidence

No runtime mutation was performed.

Tests:

uv run --project control-plane --with pytest python -m pytest \
  control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py \
  control-plane/platformctl/tests/test_apply_env_file.py \
  control-plane/platformctl/tests/test_apply_phase3.py \
  -q
75 passed in 1.86s

Known constraints

This only makes manual dispatch target one module. Runner-local runtime setup still must pass readiness before any smoke.

Explicit out-of-scope

No production mutation.
No stateful services.
No Infisical Token Auth retry.
No broadening auto-apply beyond v1 allowlist.

Requested decision

Operator merge if the manual dashboard smoke trigger is acceptable.

Merge blockers

Any route where workflow_dispatch can run from a PR head or non-main ref.
Any route where manual dispatch bypasses module manifest allowlist checks.
Any secret material in workflow YAML or repository secrets.

Spec sources read

.forgejo/workflows/platformctl-auto-apply.yml — target workflow
control-plane/platformctl/ci/auto_apply_scope.py — allowlist classifier
control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py — workflow contract tests
docs/ci/runner-contract.md — deploy runner trust boundary

Refs #142

Canary status: missing — fire canary 3+3 manually before merge ## Canary Context Pack ### Product story Piotr gave `apply ✅` for the first RS2000 dashboard smoke, but the active workflow could not actually target `dashboard`: `workflow_dispatch` had no module input and would classify the latest control-plane merge diff instead. This PR makes the manual smoke path explicit and fail-closed. ### What changed - Added `workflow_dispatch.inputs.module`, defaulting to `dashboard`. - Added `auto_apply_scope.py --module <id>` to classify an explicit trusted-main module target. - Updated the auto-apply workflow so manual dispatch uses the requested module instead of the last merge diff. - Added tests for manual module changed-file synthesis and workflow contract markers. ### Why it changed Pre-Phase-4 inspection showed that triggering the existing workflow would not prove dashboard cutover. It would inspect #252's `control-plane/**` changes and block. The `apply ✅` needs a safe target, not a noisy failed run. ### Files touched - `.forgejo/workflows/platformctl-auto-apply.yml` - `control-plane/platformctl/ci/auto_apply_scope.py` - `control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py` ### Relevant context - Issue #142 cutover lane - PR #251 compose include fix - PR #252 env-file/preflight apply support - `docs/ci/runner-contract.md` ### Runtime evidence No runtime mutation was performed. Tests: ```text uv run --project control-plane --with pytest python -m pytest \ control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py \ control-plane/platformctl/tests/test_apply_env_file.py \ control-plane/platformctl/tests/test_apply_phase3.py \ -q 75 passed in 1.86s ``` ### Known constraints This only makes manual dispatch target one module. Runner-local runtime setup still must pass readiness before any smoke. ### Explicit out-of-scope - No production mutation. - No stateful services. - No Infisical Token Auth retry. - No broadening auto-apply beyond v1 allowlist. ### Requested decision Operator merge if the manual dashboard smoke trigger is acceptable. ### Merge blockers - Any route where `workflow_dispatch` can run from a PR head or non-main ref. - Any route where manual dispatch bypasses module manifest allowlist checks. - Any secret material in workflow YAML or repository secrets. ## Spec sources read - `.forgejo/workflows/platformctl-auto-apply.yml` — target workflow - `control-plane/platformctl/ci/auto_apply_scope.py` — allowlist classifier - `control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py` — workflow contract tests - `docs/ci/runner-contract.md` — deploy runner trust boundary Refs #142

codex added 1 commit

2026-05-13 07:05:35 +02:00

fix(auto-apply): target manual dispatch module

canary-required / collect-diff (pull_request) Successful in 4s

Details

infra-docs-drift / docs-drift (pull_request) Successful in 4s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 20s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 17s

Details

python-ci / Python 3.11 (pull_request) Successful in 40s