fix(cutover): prune deploy-control legacy backups #308

Merged
pdurlej merged 1 commit from codex/f3/deploy-control-backup-prune into main 2026-05-17 01:21:04 +02:00
Collaborator

Canary status: missing — backup helper fix; PR checks required before deploy-control F3.

Canary Context Pack

Product story

Allow deploy-control to enter the F3 backup-before-smoke path without archiving the entire legacy backup store.

What changed

Updated scripts/cutover/backup-before-apply.sh so class-E mount archives:

  • skip socket mounts;
  • log a best-effort archive input estimate;
  • for deploy-control, exclude /opt/vps-home-platform-infra/backups from both estimate and tar.

Why it changed

The first deploy-control backup attempted to archive /opt/vps-home-platform-infra, including /opt/vps-home-platform-infra/backups (~146G out of ~147G). That was stopped and the partial backup was removed before F3 could continue.

Files touched

  • scripts/cutover/backup-before-apply.sh

Runtime evidence

  • /opt/vps-home-platform-infra: 147G
  • /opt/vps-home-platform-infra/backups: 146G
  • estimate after excluding legacy backups: 1.6G

Known constraints

No production backup was run with this new script yet. After merge, sync release root and run backup-before-apply.sh deploy-control, then F3 workflow dispatch with allow_stateful=true.

Explicit out-of-scope

No deletion of legacy backups. No deploy-control runtime restart. No compose changes.

Requested decision

Merge so deploy-control backup can be retried safely.

Merge blockers

Script syntax failure, reviewer concern that excluding legacy backups removes required deploy-control state.

Spec sources read

  • scripts/cutover/backup-before-apply.sh
  • live RS2000 docker inspect/du evidence for deploy-control mounts and legacy backup size

Verification

  • bash -n scripts/cutover/backup-before-apply.sh: green
  • RS2000 size evidence: legacy root 147G, legacy backups 146G, post-exclude estimate 1.6G
Canary status: missing — backup helper fix; PR checks required before deploy-control F3. ## Canary Context Pack ### Product story Allow `deploy-control` to enter the F3 backup-before-smoke path without archiving the entire legacy backup store. ### What changed Updated `scripts/cutover/backup-before-apply.sh` so class-E mount archives: - skip socket mounts; - log a best-effort archive input estimate; - for `deploy-control`, exclude `/opt/vps-home-platform-infra/backups` from both estimate and tar. ### Why it changed The first `deploy-control` backup attempted to archive `/opt/vps-home-platform-infra`, including `/opt/vps-home-platform-infra/backups` (~146G out of ~147G). That was stopped and the partial backup was removed before F3 could continue. ### Files touched - `scripts/cutover/backup-before-apply.sh` ### Runtime evidence - `/opt/vps-home-platform-infra`: 147G - `/opt/vps-home-platform-infra/backups`: 146G - estimate after excluding legacy backups: 1.6G ### Known constraints No production backup was run with this new script yet. After merge, sync release root and run `backup-before-apply.sh deploy-control`, then F3 workflow dispatch with `allow_stateful=true`. ### Explicit out-of-scope No deletion of legacy backups. No deploy-control runtime restart. No compose changes. ### Requested decision Merge so `deploy-control` backup can be retried safely. ### Merge blockers Script syntax failure, reviewer concern that excluding legacy backups removes required deploy-control state. ## Spec sources read - `scripts/cutover/backup-before-apply.sh` - live RS2000 `docker inspect`/`du` evidence for `deploy-control` mounts and legacy backup size ## Verification - `bash -n scripts/cutover/backup-before-apply.sh`: green - RS2000 size evidence: legacy root 147G, legacy backups 146G, post-exclude estimate 1.6G
fix(cutover): prune deploy-control legacy backups
Some checks failed
base-is-main / guard (pull_request) Successful in 1s
canary-required / collect-diff (pull_request) Failing after 4s
patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s
canary-required / canary (pull_request) Has been skipped
patchwarden-pr-sanity / sanity (pull_request) Successful in 20s
ce2d143db1
Sign in to join this conversation.
No reviewers
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!308
No description provided.