pdurlej/platform
1
1
Fork 0
Code Issues 44 Pull requests 1 Projects Releases Packages Wiki Activity Actions

docs(specs): prebuild for #243 branch protection main with base-is-main guard #330

Merged
pdurlej merged 1 commit from claude/c-batch/canary-pr-body-context-bug-prebuild into main 2026-05-23 09:19:02 +02:00
Conversation 1 Commits 1 Files changed 6 +549
claude commented 2026-05-17 17:27:24 +02:00
Collaborator
Copy link

Summary

Bug prebuild (codex's preferred shape per 2026-05-17 feedback: reproduction + evidence + expected/actual + hypothesis ranking + minimal fix surface + acceptance + tests) for issue #85.

Bug observed

Canary reviewers (claude/codex/glm) report PR description: none for PRs with non-empty Forgejo body. Reached 3-iter cap on PR #84 due to this false dissent.

Hypothesis ranking

  • H1 (60%): body parameter not threaded through run_review CLI/builder
  • H2 (20%): adapter strips body in prompt template
  • H3 (10%): Forgejo null vs empty-string body normalization
  • H4/H5 (5% each): workflow YAML wrong PR id / race condition

3-state model (per ADR-0018)

Decision packet evidence must distinguish:

  • pr_body_source: provided (body supplied to reviewer)
  • pr_body_source: forgejo_empty (legitimately empty PR body)
  • pr_body_source: runner_error (pipeline failure to fetch)

Without this, agent reads conflated signal as "PR description: none" → false blocker → wasted operator-attention. Direct ADR-0018 application (agent-readable surface that lies = wrong action).

Files

  • docs/specs/canary-pr-body-context-bug/README.md
  • docs/specs/canary-pr-body-context-bug/01-reproduction.md (steps + evidence from PR #82/#84)
  • docs/specs/canary-pr-body-context-bug/02-expected-vs-actual.md (3-state model)
  • docs/specs/canary-pr-body-context-bug/03-hypothesis-ranking.md (ranked H1-H5 with test procedures)
  • docs/specs/canary-pr-body-context-bug/04-minimal-fix-surface.md (files allowed/forbidden per hypothesis)
  • docs/specs/canary-pr-body-context-bug/05-acceptance-and-tests.md (5 regression test cases + fixture spec)
  • prompts/codex-canary-pr-body-context-bug.md (codex execution: investigate → fix → tests, per ADR-0018 stop conditions)

Tier

Trivial per ADR-0007 (docs-only prebuild). The downstream fix (separate PR) is Lite.

Part of batch C (process/governance) prebuild shift

This is 2/6 prebuilds. Others: #243 branch protection (PR #327 done), #86 security-sensitive routing, #49 ADR-0002 CI enforcement, DeepSeek #11 ADR-0018 mechanical guard, #75 governance globalne.

Refs #85 #82 #84

## Summary Bug prebuild (codex's preferred shape per 2026-05-17 feedback: reproduction + evidence + expected/actual + hypothesis ranking + minimal fix surface + acceptance + tests) for issue #85. ## Bug observed Canary reviewers (claude/codex/glm) report `PR description: none` for PRs with non-empty Forgejo body. Reached 3-iter cap on PR #84 due to this false dissent. ## Hypothesis ranking - **H1 (60%):** body parameter not threaded through `run_review` CLI/builder - **H2 (20%):** adapter strips body in prompt template - **H3 (10%):** Forgejo null vs empty-string body normalization - **H4/H5 (5% each):** workflow YAML wrong PR id / race condition ## 3-state model (per ADR-0018) Decision packet evidence must distinguish: - `pr_body_source: provided` (body supplied to reviewer) - `pr_body_source: forgejo_empty` (legitimately empty PR body) - `pr_body_source: runner_error` (pipeline failure to fetch) Without this, agent reads conflated signal as "PR description: none" → false blocker → wasted operator-attention. Direct ADR-0018 application (agent-readable surface that lies = wrong action). ## Files - `docs/specs/canary-pr-body-context-bug/README.md` - `docs/specs/canary-pr-body-context-bug/01-reproduction.md` (steps + evidence from PR #82/#84) - `docs/specs/canary-pr-body-context-bug/02-expected-vs-actual.md` (3-state model) - `docs/specs/canary-pr-body-context-bug/03-hypothesis-ranking.md` (ranked H1-H5 with test procedures) - `docs/specs/canary-pr-body-context-bug/04-minimal-fix-surface.md` (files allowed/forbidden per hypothesis) - `docs/specs/canary-pr-body-context-bug/05-acceptance-and-tests.md` (5 regression test cases + fixture spec) - `prompts/codex-canary-pr-body-context-bug.md` (codex execution: investigate → fix → tests, per ADR-0018 stop conditions) ## Tier Trivial per ADR-0007 (docs-only prebuild). The downstream fix (separate PR) is Lite. ## Part of batch C (process/governance) prebuild shift This is 2/6 prebuilds. Others: #243 branch protection (PR #327 done), #86 security-sensitive routing, #49 ADR-0002 CI enforcement, DeepSeek #11 ADR-0018 mechanical guard, #75 governance globalne. Refs #85 #82 #84
docs(specs): prebuild for #243 branch protection main base-is-main guard
All checks were successful
base-is-main / guard (pull_request) Successful in 2s
Details
canary-required / collect-diff (pull_request) Successful in 4s
Details
patchwarden-pr-sanity / collect-diff (pull_request) Successful in 3s
Details
canary-required / canary (pull_request) Successful in 14s
Details
patchwarden-pr-sanity / sanity (pull_request) Successful in 20s
Details
13bced9cc3 
Operator-action issue #243 deferred since ADR-0017 merge (PR #220, 2026-05-12)
because RS2000 cutover window was active. F3 stateful smokes landed
2026-05-17 ~02:37 CEST, so the deferral preconditions are now satisfied.

This prebuild documents:

- Why this now, what changed since #243 was deferred
- Exact Forgejo UI checklist (steps, fields, required values)
- Post-enablement verification smoke (test stacked PR red, escape hatch
  green, normal PR no regression)
- Rollback procedure if anything breaks ongoing work
- Companion execution prompt for codex (verification-only role; operator
  is the only actor who toggles UI settings)

Files:
- docs/specs/branch-protection-main-base-guard/README.md
- docs/specs/branch-protection-main-base-guard/01-context.md
- docs/specs/branch-protection-main-base-guard/02-checklist.md
- docs/specs/branch-protection-main-base-guard/03-verification.md
- docs/specs/branch-protection-main-base-guard/04-rollback.md
- prompts/codex-branch-protection-main-base-guard.md

Hard gates preserved:
- Operator-UI only for protection toggle (codex MUST NOT call branch
  protection API)
- No test PR merge during verification (test PRs created, observed,
  closed without merge)
- Per ADR-0018: no "accept workaround" outcomes if verification fails

Tier: Trivial per ADR-0007 (docs-only, no runtime/schema/sacred-path
mutation). The action this enables (branch protection enable) is itself
operator-UI-only, no code involved.

Part of batch C (process/governance) prebuild shift.
Refs #243 #220 ADR-0017 ADR-0018
claude changed title from docs(specs): bug prebuild for #85 canary PR body in reviewer context to docs(specs): prebuild for #243 branch protection main with base-is-main guard 2026-05-17 22:43:42 +02:00
claude commented 2026-05-17 22:43:42 +02:00
Author
Collaborator
Copy link

Title corrected (fork-anchor szpachla 2026-05-17)

Original title said "bug prebuild for #85 canary PR body in reviewer context" but the 6 committed files are entirely #243 branch protection Spec Kit (docs/specs/branch-protection-main-base-guard/* + prompts/codex-branch-protection-main-base-guard.md). Fork-anchor cross-branch collision.

Retitled to reflect actual content. The #85 canary PR body bug prebuild was genuinely lost. Retry #85 in fresh worktree session.

This PR addresses #243.

## Title corrected (fork-anchor szpachla 2026-05-17) Original title said "bug prebuild for #85 canary PR body in reviewer context" but the 6 committed files are entirely #243 branch protection Spec Kit (docs/specs/branch-protection-main-base-guard/* + prompts/codex-branch-protection-main-base-guard.md). Fork-anchor cross-branch collision. Retitled to reflect actual content. The #85 canary PR body bug prebuild was genuinely lost. Retry #85 in fresh worktree session. This PR addresses #243.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
W6d-automerge-calibration

   
agent/claude-code
Vistula actor: Claude Code.

  
agent/codex
Vistula actor: Codex.

  
agent/hermes
Vistula actor: Hermes Upstream.

  
agent/iskra
Vistula actor: Iskra.

  
agent/ollama
Vistula actor: Ollama or compatible model.

  
agent/patchwarden
Vistula actor: Patchwarden.

  
automerge-candidate
Candidate for narrow W6d autonomous merge readiness pilot

  
class/security-sensitive
Security-sensitive class of service: smallest coherent PRs and full canary

  
cutover-gate
blocks production declare / final RS2000 replacement

  
dependency/blocked
Vistula dependency state: blocked.

  
dependency/blocks-others
Vistula dependency state: blocks other work.

  
dependency/cross-repo
Vistula dependency scope: cross-repository.

  
dependency/needs-confirmation
Vistula dependency state: needs confirmation.

  
domain:agents
Agent identity, delegation, subagents, routing, or workflows.

  
domain:ci
CI, checks, Actions, runners, or release automation.

  
domain:docs
Documentation, packets, practices, or source-of-truth text.

  
domain:forgejo
Forgejo issues, PRs, labels, repo settings, or identity.

  
domain:infra
Infrastructure, storage, backup, DNS, network, or host substrate.

  
domain:memory
Memory, recall, write gates, salience, or Honcho-adjacent behavior.

  
domain:runtime
Runtime services, deploys, daemons, timers, or live behavior.

  
domain:signal
Signal UX, delivery, context, or outbound behavior.

  
domain:ux
Product UX, operator experience, or conversation ergonomics.

  
flow/architecture
Vistula lifecycle: architecture phase in progress.

  
flow/blocked
Vistula lifecycle: blocked on dependency or decision.

  
flow/deployed
Vistula lifecycle: deployed to runtime where applicable.

  
flow/done
Vistula lifecycle: work merged or otherwise done.

  
flow/implementation
Vistula lifecycle: implementation phase in progress.

  
flow/intake
Vistula lifecycle: incoming signal not refined yet.

  
flow/maintained
Vistula lifecycle: maintained/steady state.

  
flow/observed
Vistula lifecycle: observed after delivery.

  
flow/ready
Vistula lifecycle: ready for architecture or implementation.

  
flow/refining
Vistula lifecycle: Hermes/spec refinement in progress.

  
flow/retired
Vistula lifecycle: retired or intentionally closed.

  
flow/review
Vistula lifecycle: review phase in progress.

  
iterating
Orchestrator/Codex actively amending in response to review — operator can ignore until resolved

  
judge/codex-candidate
Candidate for Codex implementation.

  
judge/hermes-candidate
Candidate for Hermes discovery/research.

  
judge/low-confidence
Judgment confidence is low.

  
judge/needs-refinement
Needs clearer evidence or scope.

  
judge/operator-needed
Needs Piotr decision or input.

  
judge/p0
Urgent, operator attention or unblock now.

  
judge/p1
High value, schedule soon.

  
judge/p2
Useful, normal queue.

  
judge/p3
Low priority, keep but do not chase.

  
judge/park
Parked from current attention.

  
judge/patchwarden-candidate
Needs Patchwarden merge-safety attention.

  
judge/stale-priority
Existing priority judgment appears stale.

  
kind/adr
Vistula work kind: architecture decision record.

  
kind/bug
Vistula work kind: bug fix.

  
kind/chore
Vistula work kind: chore.

  
kind/feature
Vistula work kind: feature.

  
kind/infra
Vistula work kind: infrastructure.

  
kind/ops
Vistula work kind: operations.

  
kind/refactor
Vistula work kind: refactor.

  
kind/research
Vistula work kind: research/discovery.

  
large-impact
Per charter §3 review-by-impact: large impact (≥300 LOC OR new module OR identity/secret change OR architectural pivot) — Oracle pre-review recommended

  
merge/auto
Vistula merge mode: automated merge.

  
merge/manual
Vistula merge mode: manual merge.

  
merge/manual-dependency-conflict
Manual merge reason: dependency conflict.

  
merge/manual-failing-tests
Manual merge reason: failing tests.

  
merge/manual-merge-conflict
Manual merge reason: merge conflict.

  
merge/manual-missing-review
Manual merge reason: missing review.

  
merge/manual-operator-preference
Manual merge reason: operator preference.

  
merge/manual-red-zone
Manual merge reason: red-zone risk.

  
merge/manual-security-sensitive
Manual merge reason: security-sensitive work.

  
merge/manual-unclear-scope
Manual merge reason: unclear scope.

  
merge/manual-unknown
Manual merge reason: unknown.

  
meta
meta-decomposition issue; first agent decomposes into atomic children

  
mode:operator-only
Apply step requires explicit operator approval.

  
mode:patchwarden-iskra-approved
Work eligible for Patchwarden/Iskra approval inside repo policy.

  
mode:safe-auto
Low-risk work eligible for lightweight autonomous handling.

  
needs-operator-decision
PR is blocked on operator yes/no decision — fresh-Claude/Codex won't make this call alone

  
needs-triage
decomposing agent has open questions / unknowns

  
not-ready
reviewed but blocked on a precondition

  
observed/erroring
Vistula observation: erroring.

  
observed/needs-followup
Vistula observation: needs follow-up.

  
observed/pending
Vistula observation: pending.

  
observed/retire-candidate
Vistula observation: retire candidate.

  
observed/unused
Vistula observation: unused.

  
observed/used
Vistula observation: used.

  
operator-emotional
operator-emotional importance (Iskra memory etc.)

  
owner-attention
owner must decide; blocks default path

  
phase/02
Phase 02 cataloging

  
phase/03
Phase 03 control plane (platformctl)

  
priority:p0
Immediate safety, uptime, data, or operator-blocking issue.

  
priority:p1
Important active work; should be pulled soon.

  
priority:p2
Useful normal-priority work.

  
priority:p3
Opportunistic cleanup, research, or backlog work.

  
proposed
auto-generated by meta-decomposition; awaiting human review

  
ready-for-agent
reviewed and pickable; agents may claim per cookbook

  
ready-for-operator
PR is ready for operator review/merge — orchestrator finished its part

  
recovery
disaster recovery / restore semantics relevant

  
review:claude-reviewed
Reviewed by Claude-family agent.

  
review:codex-reviewed
Reviewed by Codex-family agent.

  
review:dziadek-reviewed
Reviewed by Dziadek pinch-point reviewer.

  
review:needs-human
Needs human review before merge or apply.

  
risk/exposure
incorrectly public/private/tailnet/auth/routed

  
risk/process
workflow/review/orchestration may produce bad outcomes

  
risk/product
work may have lost owner/user value

  
risk/runtime
platform may not run, recover, validate, behave reproducibly

  
safety:external-write
May write to external systems, users, rooms, repos, or services.

  
safety:no-prod-mutation
Must not mutate production or live external state.

  
safety:prod-impact
May affect production/runtime behavior.

  
safety:secret-touch
Touches secrets, credentials, auth, or secret-adjacent config.

  
size/large
Vistula size: large.

  
size/medium
Vistula size: medium.

  
size/small
Vistula size: small.

  
size/tiny
Vistula size: tiny.

  
size/unknown
Vistula size: not classified yet.

  
source/adr
Vistula source: ADR.

  
source/agent-generated
Vistula source: agent generated.

  
source/manual
Vistula source: manual entry.

  
source/operator-chat
Vistula source: operator chat.

  
source/voice-note
Vistula source: voice note.

  
status:blocked
Blocked by missing dependency, evidence, access, or operator decision.

  
status:codex-ready
Ready for a Codex implementation pass.

  
status:merged:pending-evidence
Merged but waiting for live or artifact evidence before closure.

  
status:needs-evidence
Needs proof, logs, tests, or operator-visible evidence.

  
status:operator-needed
Requires explicit operator input before safe progress.

  
status:parked
Intentionally deferred; not active campaign work.

  
tier/full
Full review tier per ADR-0007

  
tier/lite
Lite review tier per ADR-0007

  
tier/stacked
Stacked PR (base != main) escape hatch per ADR-0017. Requires consolidator-PR plan in PR body.

  
tier:0-platform-substrate
Data, secrets, backup, storage, or critical platform substrate.

  
tier:1-iskra-value-layer
Iskra/OpenClaw behavior, memory, runtime, or value-layer work.

  
tier:2-tools-products-modules
Tools, products, modules, experiments, and lower-blast-radius work.

  
type:bug
Incorrect behavior or regression.

  
type:chore
Maintenance, cleanup, metadata, or operational task.

  
type:docs
Documentation-only work.

  
type:feat
New capability or product behavior.

  
type:policy
Governance, protocol, boundary, or decision-contract change.

  
type:research
Investigation, spike, or evidence-gathering task.

No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!330
No description provided.