fix(w6): explain platform approvals sender to Iskra #474

Merged
pdurlej merged 1 commit from codex/w6d-iskra-approval-request-context into main 2026-05-25 07:57:15 +02:00
Collaborator

Canary status: missing - narrow W6d approval request copy fix; rely on required Forgejo checks before merge

Summary

  • tells Iskra that @platform-approvals:pdurlej.com is the operator-approved W6d metadata-only sender
  • tells Iskra to attribute the sender as sourceActor.peerId=platform_approvals / peerRole=system, never Piotr/operator
  • adds deterministic escalation wording: use ISKRA_HOLD ... reason=operator_escalation_needed when Piotr judgement is needed

Why

The W6d dry-run for #470 passed deterministic readiness but Iskra replied ISKRA_HOLD ... reason=unauthorized_sender. The Matrix transport and runtime mapping are working; the request itself needs to carry the sender contract.

Tests

  • python3 -m pytest -q control-plane/platformctl/tests/test_iskra_matrix_approval.py

Runtime evidence

  • iskra-openclaw #362 merged and was deployed to VPS1000 runtime with backup.
  • openclaw-memory-sidecar.service and openclaw-gateway.service restarted and active.
  • Platform automerge dry-run API run 2699 failed closed with reason=unauthorized_sender after readiness succeeded.

Spec sources read

  • control-plane/platformctl/ci/iskra_matrix_approval.py - W6d Matrix request builder
  • control-plane/platformctl/tests/test_iskra_matrix_approval.py - metadata-only request contract

Out of scope

  • No change to deterministic eligibility rules.
  • No auto-merge execution change.
  • No secret, token, or Matrix room mutation.
Canary status: missing - narrow W6d approval request copy fix; rely on required Forgejo checks before merge ## Summary - tells Iskra that `@platform-approvals:pdurlej.com` is the operator-approved W6d metadata-only sender - tells Iskra to attribute the sender as `sourceActor.peerId=platform_approvals` / `peerRole=system`, never Piotr/operator - adds deterministic escalation wording: use `ISKRA_HOLD ... reason=operator_escalation_needed` when Piotr judgement is needed ## Why The W6d dry-run for #470 passed deterministic readiness but Iskra replied `ISKRA_HOLD ... reason=unauthorized_sender`. The Matrix transport and runtime mapping are working; the request itself needs to carry the sender contract. ## Tests - `python3 -m pytest -q control-plane/platformctl/tests/test_iskra_matrix_approval.py` ## Runtime evidence - `iskra-openclaw` #362 merged and was deployed to VPS1000 runtime with backup. - `openclaw-memory-sidecar.service` and `openclaw-gateway.service` restarted and active. - Platform automerge dry-run API run `2699` failed closed with `reason=unauthorized_sender` after readiness succeeded. ## Spec sources read - `control-plane/platformctl/ci/iskra_matrix_approval.py` - W6d Matrix request builder - `control-plane/platformctl/tests/test_iskra_matrix_approval.py` - metadata-only request contract ## Out of scope - No change to deterministic eligibility rules. - No auto-merge execution change. - No secret, token, or Matrix room mutation.
fix(w6): explain platform approvals sender to Iskra
All checks were successful
base-is-main / guard (pull_request) Successful in 2s
canary-required / collect-diff (pull_request) Successful in 5s
infra-docs-drift / docs-drift (pull_request) Successful in 5s
patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s
platformctl plan / auto-apply scope (pull_request) Successful in 21s
pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 18s
python-ci / Python 3.11 (pull_request) Successful in 41s
python-ci / Python 3.12 (pull_request) Successful in 43s
python-ci / Python 3.13 (pull_request) Successful in 42s
workflow-lint / lint (pull_request) Successful in 5s
canary-required / canary (pull_request) Successful in 14s
patchwarden-pr-sanity / sanity (pull_request) Successful in 21s
d4d6f53a44
Sign in to join this conversation.
No reviewers
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!474
No description provided.