feat(cutover): add RS2000 legacy dependency audit #573

Merged

pdurlej merged 1 commit from codex/m01-rs2000-audit into main

2026-05-28 23:13:09 +02:00

codex commented

2026-05-28 22:25:16 +02:00

Collaborator

Canary status: missing - fire canary 3+3 manually before merge

Summary

Adds a read-only platformctl cutover rs2000-legacy-audit command for M01. The audit finds remaining references to /opt/vps-home-platform-infra before we attempt quarantine or destructive cleanup.

This is intentionally metadata-only: it reports source path, surface, category, line number, legacy prefix, and severity. It does not emit matched line contents, env values, command output, tokens, or secret-looking payloads.

Canary Context Pack

Product story

M01 cleanup needs a hard evidence gate before any RS2000 legacy paths are tombstoned or deleted. The operator should be able to ask one command: “what still depends on the old root?” and get actionable blockers without leaking secrets into PRs or chat.

What changed

Added control-plane/platformctl/cutover/rs2000_legacy_audit.py.
Added platformctl cutover rs2000-legacy-audit CLI.
Added tests for blocker/review/allowed classification, symlink targets, Docker probe handling, host no-match behavior, and secret-safe output.
Documented usage in scripts/cutover/README.md.

Why it changed

Oracle’s gate sequence for RS2000 cleanup requires static reference inventory, runtime mount verification, host process checks, DR refresh, and quarantine before deletion. This PR implements the first reusable read-only audit tool for that chain.

Files touched

control-plane/platformctl/cli.py
control-plane/platformctl/cutover/__init__.py
control-plane/platformctl/cutover/rs2000_legacy_audit.py
control-plane/platformctl/tests/test_rs2000_legacy_audit.py
scripts/cutover/README.md

Relevant context

M01 milestone: RS2000 closeout and legacy cleanup
ADR-0020: post-soak legacy cleanup and platform modularization
scripts/cutover/README.md existing F3/backup helper context
Current night plan: M01 audit before migration/quarantine/destructive cleanup

Runtime evidence

No runtime mutation performed. No Docker/host probes were run against production in this PR. Repo-only audit was run locally and returned expected policy violation because live blockers remain:

counts: total=446 blockers=33 review=92 allowedReferences=321 unknown=0 commandErrors=0
exit: 4 (expected while blockers remain)

Known constraints

This PR does not move paths or change runtime topology.
Host probes are optional and read-only; running them on RS2000 is a later operator/Codex gate.
Historical docs are classified separately from likely live references to reduce noise.

Explicit out-of-scope

No deletion.
No quarantine/tombstone action.
No service restart.
No backup/restore execution.
No Infisical mutation.
No M09 upgrades.

Requested decision

Approve as the first M01 evidence tool. It should be merged before config/data migration PRs so later PRs can attach stable audit output.

Merge blockers

Any secret-bearing output path.
Any write/mutation behavior in the audit command.
False clean result when compose/runtime/symlink references exist.

Spec sources read

scripts/cutover/README.md - existing cutover helper conventions.
control-plane/platformctl/cli.py - command registration and exit codes.
control-plane/platformctl/update_report.py - local report-output style.
control-plane/platformctl/tests/test_update_report.py - platformctl test pattern.
decisions/0020-post-soak-legacy-cleanup-and-platform-modularization.md - cleanup boundary.
state/cutover/rs2000-live-data-config-migration.md - M01 path context.
state/cutover/rs2000-post-soak-legacy-cleanup.md - legacy cleanup context.
state/roadmap/current-platform-roadmap.md - milestone sequencing.

Validation

UV_CACHE_DIR=/private/tmp/platform-uv-cache uv run pytest platformctl/tests/test_rs2000_legacy_audit.py
=> 8 passed

UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json
=> exit 0

UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli cutover rs2000-legacy-audit --help
=> exit 0

UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli cutover rs2000-legacy-audit --json
=> exit 4, expected policy violation while blockers remain; no secrets or raw line contents emitted

Refs M01 RS2000 closeout.

Canary status: missing - fire canary 3+3 manually before merge ## Summary Adds a read-only `platformctl cutover rs2000-legacy-audit` command for M01. The audit finds remaining references to `/opt/vps-home-platform-infra` before we attempt quarantine or destructive cleanup. This is intentionally metadata-only: it reports source path, surface, category, line number, legacy prefix, and severity. It does not emit matched line contents, env values, command output, tokens, or secret-looking payloads. ## Canary Context Pack ### Product story M01 cleanup needs a hard evidence gate before any RS2000 legacy paths are tombstoned or deleted. The operator should be able to ask one command: “what still depends on the old root?” and get actionable blockers without leaking secrets into PRs or chat. ### What changed - Added `control-plane/platformctl/cutover/rs2000_legacy_audit.py`. - Added `platformctl cutover rs2000-legacy-audit` CLI. - Added tests for blocker/review/allowed classification, symlink targets, Docker probe handling, host no-match behavior, and secret-safe output. - Documented usage in `scripts/cutover/README.md`. ### Why it changed Oracle’s gate sequence for RS2000 cleanup requires static reference inventory, runtime mount verification, host process checks, DR refresh, and quarantine before deletion. This PR implements the first reusable read-only audit tool for that chain. ### Files touched - `control-plane/platformctl/cli.py` - `control-plane/platformctl/cutover/__init__.py` - `control-plane/platformctl/cutover/rs2000_legacy_audit.py` - `control-plane/platformctl/tests/test_rs2000_legacy_audit.py` - `scripts/cutover/README.md` ### Relevant context - M01 milestone: RS2000 closeout and legacy cleanup - ADR-0020: post-soak legacy cleanup and platform modularization - `scripts/cutover/README.md` existing F3/backup helper context - Current night plan: M01 audit before migration/quarantine/destructive cleanup ### Runtime evidence No runtime mutation performed. No Docker/host probes were run against production in this PR. Repo-only audit was run locally and returned expected policy violation because live blockers remain: ```text counts: total=446 blockers=33 review=92 allowedReferences=321 unknown=0 commandErrors=0 exit: 4 (expected while blockers remain) ``` ### Known constraints - This PR does not move paths or change runtime topology. - Host probes are optional and read-only; running them on RS2000 is a later operator/Codex gate. - Historical docs are classified separately from likely live references to reduce noise. ### Explicit out-of-scope - No deletion. - No quarantine/tombstone action. - No service restart. - No backup/restore execution. - No Infisical mutation. - No M09 upgrades. ### Requested decision Approve as the first M01 evidence tool. It should be merged before config/data migration PRs so later PRs can attach stable audit output. ### Merge blockers - Any secret-bearing output path. - Any write/mutation behavior in the audit command. - False clean result when compose/runtime/symlink references exist. ## Spec sources read - `scripts/cutover/README.md` - existing cutover helper conventions. - `control-plane/platformctl/cli.py` - command registration and exit codes. - `control-plane/platformctl/update_report.py` - local report-output style. - `control-plane/platformctl/tests/test_update_report.py` - platformctl test pattern. - `decisions/0020-post-soak-legacy-cleanup-and-platform-modularization.md` - cleanup boundary. - `state/cutover/rs2000-live-data-config-migration.md` - M01 path context. - `state/cutover/rs2000-post-soak-legacy-cleanup.md` - legacy cleanup context. - `state/roadmap/current-platform-roadmap.md` - milestone sequencing. ## Validation ```text UV_CACHE_DIR=/private/tmp/platform-uv-cache uv run pytest platformctl/tests/test_rs2000_legacy_audit.py => 8 passed UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json => exit 0 UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli cutover rs2000-legacy-audit --help => exit 0 UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli cutover rs2000-legacy-audit --json => exit 4, expected policy violation while blockers remain; no secrets or raw line contents emitted ``` Refs M01 RS2000 closeout.

codex added this to the 01 - RS2000 closeout and legacy cleanup milestone

2026-05-28 22:25:16 +02:00

codex added the

labels

2026-05-28 22:25:16 +02:00