fix(cutover): support legacy import without rsync #582

Merged

pdurlej merged 1 commit from codex/m01-legacy-import-tar-fallback into main

2026-05-28 23:50:00 +02:00

codex commented

2026-05-28 23:33:38 +02:00

Collaborator

Canary status: missing - fire canary 3+3 manually before merge

Summary

Fixes the M01 legacy-import helper after the first RS2000 dry-run found that rsync is not installed on the host.

The helper now prefers rsync when available and falls back to tar otherwise. The fallback preserves ownership, modes, symlinks, and timestamps, but does not claim ACL/xattr parity.

Evidence

Read-only/dry-run on RS2000 before this fix failed with:

rsync: command not found

Running the patched helper over SSH in dry-run mode for config/ntfy/server.yml succeeded with tool=tar and emitted only metadata:

DRY-RUN config/ntfy/server.yml tool=tar
Source apparent size: 4.0K

No file contents or secret values were printed.

What changed

Added copy tool detection: rsync first, tar fallback.
Added tar dry-run metadata mode that avoids file listing.
Added tar apply mode for hosts without rsync.
Documented the fallback behavior.

Safety

Still dry-run by default.
Still requires --yes for writes.
Still no delete, rename, restart, chmod sweep, or secret printing.
Tar fallback does not use verbose/list mode.
Roots remain hard-gated to M01 source/target paths.

Validation

bash -n scripts/cutover/prepare-legacy-import.sh => pass
Local dry-run for missing config/ntfy/server.yml => safe SKIP
RS2000 dry-run via SSH for config/ntfy/server.yml using patched script => pass, tool=tar
UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json => exit 0
git diff --check => pass

Non-goals

Does not run live copy.
Does not update Compose mounts.
Does not restart services.
Does not delete or quarantine legacy paths.

Canary status: missing - fire canary 3+3 manually before merge ## Summary Fixes the M01 legacy-import helper after the first RS2000 dry-run found that `rsync` is not installed on the host. The helper now prefers `rsync` when available and falls back to `tar` otherwise. The fallback preserves ownership, modes, symlinks, and timestamps, but does not claim ACL/xattr parity. ## Evidence Read-only/dry-run on RS2000 before this fix failed with: ```text rsync: command not found ``` Running the patched helper over SSH in dry-run mode for `config/ntfy/server.yml` succeeded with `tool=tar` and emitted only metadata: ```text DRY-RUN config/ntfy/server.yml tool=tar Source apparent size: 4.0K ``` No file contents or secret values were printed. ## What changed - Added copy tool detection: `rsync` first, `tar` fallback. - Added tar dry-run metadata mode that avoids file listing. - Added tar apply mode for hosts without `rsync`. - Documented the fallback behavior. ## Safety - Still dry-run by default. - Still requires `--yes` for writes. - Still no delete, rename, restart, chmod sweep, or secret printing. - Tar fallback does not use verbose/list mode. - Roots remain hard-gated to M01 source/target paths. ## Validation - `bash -n scripts/cutover/prepare-legacy-import.sh` => pass - Local dry-run for missing `config/ntfy/server.yml` => safe SKIP - RS2000 dry-run via SSH for `config/ntfy/server.yml` using patched script => pass, `tool=tar` - `UV_CACHE_DIR=/private/tmp/platform-uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json` => exit 0 - `git diff --check` => pass ## Non-goals - Does not run live copy. - Does not update Compose mounts. - Does not restart services. - Does not delete or quarantine legacy paths.

codex added this to the 01 - RS2000 closeout and legacy cleanup milestone

2026-05-28 23:33:38 +02:00

codex added the

cutover-gate

phase/03

class/security-sensitive

labels