chore(sprint): clean local tooling artifacts #633

Merged

pdurlej merged 1 commit from codex/sprint-local-cleanup into main

2026-05-30 10:25:58 +02:00

codex commented

2026-05-30 10:22:43 +02:00

Collaborator

Summary

Sprint-prep cleanup before the next quieter Shape Up-style cycle.

Ignores local agent/tool artifacts that were making the working tree look dirty: .codegraph/, .serena/, .understand-anything/, local platform state/cache, and generated control-plane/uv.lock.
Preserves the Memory Control Plane strategy note as tracked M07 context under state/strategy/ instead of leaving it as local untracked state.
Locally removed stale generated/untracked artifacts, including the closed Understand Anything spike scratch directory for #404.

Safety

No runtime changes.
No secrets or raw env values included.
No RS2000/VPS1000 mutation.
Closed UA scratch state was local-only and issue #404 is already closed.

Validation

UV_CACHE_DIR=/private/tmp/uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json passed.

## Summary Sprint-prep cleanup before the next quieter Shape Up-style cycle. - Ignores local agent/tool artifacts that were making the working tree look dirty: `.codegraph/`, `.serena/`, `.understand-anything/`, local platform state/cache, and generated `control-plane/uv.lock`. - Preserves the Memory Control Plane strategy note as tracked M07 context under `state/strategy/` instead of leaving it as local untracked state. - Locally removed stale generated/untracked artifacts, including the closed Understand Anything spike scratch directory for #404. ## Safety - No runtime changes. - No secrets or raw env values included. - No RS2000/VPS1000 mutation. - Closed UA scratch state was local-only and issue #404 is already closed. ## Validation - `UV_CACHE_DIR=/private/tmp/uv-cache PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json` passed.

codex added 1 commit

2026-05-30 10:22:43 +02:00

chore(sprint): clean local tooling artifacts

base-is-main / guard (pull_request) Successful in 2s

Details

canary-required / collect-diff (pull_request) Successful in 5s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 5s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 5s

Details

canary-required / canary (pull_request) Has been skipped

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 26s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 1m52s

Details

b63499bf10

codex commented

2026-05-30 10:25:20 +02:00

Author

Collaborator

Patchwarden PR sanity

Status: advisory_findings
PR: 633
Commit: b63499bf1002615063d308c10cb3658db13c6b89
Security-sensitive label: missing
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: OK
medium control-plane/uv.lock ignored may break reproducibility
- Evidence: Diff adds 'control-plane/uv.lock' to .gitignore. Lock files are typically committed to ensure deterministic dependency resolution across environments. The PR description calls it 'generated' but uv.lock serves the same purpose as package-lo
- Next: Verify this is intentional. If control-plane is a separate project with its own uv.lock that should be shared across developers/CI, it should be tracked, not ignored. If it's truly local-only (e.g., a development-only artifact), document this decision in a comment in .gitignore or an ADR.

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: OK
low Ignoring control-plane/uv.lock may break deterministic builds
- Evidence: .gitignore now includes control-plane/uv.lock. If this lock file was previously tracked or is expected for reproducible environments, ignoring it could lead to non-deterministic dependency resolution across machines.
- Next: Verify whether control-plane/uv.lock is required for deterministic builds. If so, remove it from .gitignore and ensure it remains tracked. If it is truly a generated artifact that should not be committed, confirm that no CI or developer workflow depends on it.

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: NOT_OK
medium control-plane/uv.lock ignored — reproducibility footgun
- Evidence: .gitignore diff adds +control-plane/uv.lock; PR validation runs uv run --project control-plane python -m platformctl.cli validate all --json confirming this is an application with a CLI, not a library
- Next: Remove control-plane/uv.lock from .gitignore, run uv lock in control-plane/, and commit the lockfile so CI and deployments have deterministic, reproducible dependency resolution

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `advisory_findings` - PR: `633` - Commit: `b63499bf1002615063d308c10cb3658db13c6b89` - Security-sensitive label: `missing` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - **`medium`** control-plane/uv.lock ignored may break reproducibility - Evidence: `Diff adds 'control-plane/uv.lock' to .gitignore. Lock files are typically committed to ensure deterministic dependency resolution across environments. The PR description calls it 'generated' but uv.lock serves the same purpose as package-lo` - Next: Verify this is intentional. If control-plane is a separate project with its own uv.lock that should be shared across developers/CI, it should be tracked, not ignored. If it's truly local-only (e.g., a development-only artifact), document this decision in a comment in .gitignore or an ADR. ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - **`low`** Ignoring control-plane/uv.lock may break deterministic builds - Evidence: `.gitignore now includes `control-plane/uv.lock`. If this lock file was previously tracked or is expected for reproducible environments, ignoring it could lead to non-deterministic dependency resolution across machines.` - Next: Verify whether `control-plane/uv.lock` is required for deterministic builds. If so, remove it from .gitignore and ensure it remains tracked. If it is truly a generated artifact that should not be committed, confirm that no CI or developer workflow depends on it. ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `NOT_OK` - **`medium`** control-plane/uv.lock ignored — reproducibility footgun - Evidence: `.gitignore diff adds `+control-plane/uv.lock`; PR validation runs `uv run --project control-plane python -m platformctl.cli validate all --json` confirming this is an application with a CLI, not a library` - Next: Remove `control-plane/uv.lock` from .gitignore, run `uv lock` in control-plane/, and commit the lockfile so CI and deployments have deterministic, reproducible dependency resolution ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.