pdurlej/platform

Fork 0

fix(platformctl): restrict apply target hosts #644

Merged

pdurlej merged 1 commit from codex/m06-apply-host-allowlist into main

2026-05-30 16:24:47 +02:00

codex commented

2026-05-30 16:11:21 +02:00

Collaborator

Canary status: missing - fire canary 3+3 manually before merge

Canary Context Pack

Product story

Make platformctl apply refuse to SSH into non-production hosts even if a manifest shape is otherwise valid.

What changed

Added an explicit apply-host allowlist for rs2000 and vps1000.
Rejects non-allowed runtime hosts before transport setup or SSH.
Added a regression test using mac, which schema permits but production apply must not target.

Why it changed

Issue #198 called out that manifest.host flowed directly into transport. Schema catches unknown hosts, but apply still needed a production-target gate.

Files touched

control-plane/platformctl/apply.py
control-plane/platformctl/tests/test_apply_phase3.py

Relevant context

#198 HOST-ALLOWLIST-01
M06 apply-pipeline runtime safety hardening

Runtime evidence

No runtime mutation. Local validation only.

Known constraints

This allowlist is intentionally stricter than manifest schema: mac may exist as a descriptive runtime host, but platformctl apply is production-host-only.

Explicit out-of-scope

No SSH calls.
No runtime apply.
No manifest schema changes.
No host-map or Tailnet address changes.

Requested decision

Approve and merge if checks stay green.

Merge blockers

Tests fail.
Apply can still reach transport for a non-allowed host.
Patchwarden flags a safety regression.

Spec sources read

control-plane/platformctl/apply.py - apply host flow and runtime gates.
control-plane/platformctl/tests/test_apply_phase3.py - existing apply tests and fake transport.
control-plane/platformctl/transport/tailscale.py - transport host resolution and run signature.
Forgejo issue #198 - acceptance criteria.

Validation

PYTHONPATH=control-plane control-plane/.venv/bin/python -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py - 100 passed
PYTHONPATH=control-plane control-plane/.venv/bin/python -m platformctl.cli validate all --json - pass

Closes #198

Canary status: missing - fire canary 3+3 manually before merge ## Canary Context Pack ### Product story Make `platformctl apply` refuse to SSH into non-production hosts even if a manifest shape is otherwise valid. ### What changed - Added an explicit apply-host allowlist for `rs2000` and `vps1000`. - Rejects non-allowed runtime hosts before transport setup or SSH. - Added a regression test using `mac`, which schema permits but production apply must not target. ### Why it changed Issue #198 called out that `manifest.host` flowed directly into transport. Schema catches unknown hosts, but apply still needed a production-target gate. ### Files touched - `control-plane/platformctl/apply.py` - `control-plane/platformctl/tests/test_apply_phase3.py` ### Relevant context - #198 HOST-ALLOWLIST-01 - M06 apply-pipeline runtime safety hardening ### Runtime evidence No runtime mutation. Local validation only. ### Known constraints This allowlist is intentionally stricter than manifest schema: `mac` may exist as a descriptive runtime host, but `platformctl apply` is production-host-only. ### Explicit out-of-scope - No SSH calls. - No runtime apply. - No manifest schema changes. - No host-map or Tailnet address changes. ### Requested decision Approve and merge if checks stay green. ### Merge blockers - Tests fail. - Apply can still reach transport for a non-allowed host. - Patchwarden flags a safety regression. ## Spec sources read - `control-plane/platformctl/apply.py` - apply host flow and runtime gates. - `control-plane/platformctl/tests/test_apply_phase3.py` - existing apply tests and fake transport. - `control-plane/platformctl/transport/tailscale.py` - transport host resolution and run signature. - Forgejo issue #198 - acceptance criteria. ## Validation - `PYTHONPATH=control-plane control-plane/.venv/bin/python -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py` - 100 passed - `PYTHONPATH=control-plane control-plane/.venv/bin/python -m platformctl.cli validate all --json` - pass Closes #198

codex added 1 commit

2026-05-30 16:11:21 +02:00

fix(platformctl): restrict apply target hosts

python-ci / Python 3.11 (pull_request) Successful in 44s

Details

canary-required / canary (pull_request) Successful in 15s

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 25s

Details

canary-required / collect-diff (pull_request) Successful in 5s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 5s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 25s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 22s

Details

python-ci / Python 3.12 (pull_request) Successful in 46s

Details

python-ci / Python 3.13 (pull_request) Successful in 45s

Details

base-is-main / guard (pull_request) Successful in 1s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 3m57s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

f03215ddfd

codex added the

class/security-sensitive

label

2026-05-30 16:11:22 +02:00

codex commented

2026-05-30 16:17:37 +02:00

Author

Collaborator

Patchwarden PR sanity

Status: eligible_sanity_clean
PR: 644
Commit: f03215ddfd75f7d40e0d5b0d55d08a4fcdb40f81
Security-sensitive label: present
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

info sensitive-path-touched Sensitive path touched — control-plane/platformctl/apply.py
- Evidence: control-plane/platformctl/apply.py
- Next: Route through the existing 3+3/risk-tier process; model review remains advisory.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: OK
Findings: none

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: OK
Findings: none

`redteam` / `kimi-k2.6:cloud`

Status: error
Verdict: -
Note: ReadTimeout: The read operation timed out
Findings: none

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `644` - Commit: `f03215ddfd75f7d40e0d5b0d55d08a4fcdb40f81` - Security-sensitive label: `present` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings - **`info` `sensitive-path-touched`** Sensitive path touched — `control-plane/platformctl/apply.py` - Evidence: `control-plane/platformctl/apply.py` - Next: Route through the existing 3+3/risk-tier process; model review remains advisory. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `redteam` / `kimi-k2.6:cloud` - Status: `error` - Verdict: `-` - Note: ReadTimeout: The read operation timed out - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.