pdurlej/platform

Fork 0

fix(platformctl): verify post-apply container state #648

Merged

pdurlej merged 1 commit from codex/m06-post-apply-smoke into main

2026-05-30 17:08:37 +02:00

codex commented

2026-05-30 16:50:25 +02:00

Collaborator

Canary status: missing - fire canary 3+3 manually before merge

Canary Context Pack

Product story

Do not report platformctl apply as successful merely because Docker accepted compose up -d; verify the target container reaches its expected steady state first.

What changed

Added a read-only post-apply docker inspect ... State smoke command.
applied is reported only after the container state matches the module's expected state.
Failed or malformed smoke evidence returns smoke-failed and writes the status artifact without marking the module applied.
Remote smoke command text is redacted in results/status artifacts like other remote commands.

Why it changed

Issue #201 called out that docker compose up -d only proves daemon acceptance, not runtime health.

Files touched

control-plane/platformctl/apply.py
control-plane/platformctl/tests/test_apply_phase3.py

Relevant context

#201 SMOKE-POST-APPLY-01
#202 explicit transport timeout
#198 apply host allowlist
M06 apply-pipeline runtime safety hardening

Runtime evidence

No runtime mutation. Local validation only.

Known constraints

This smoke is intentionally minimal and read-only: container state only. It does not add HTTP/service-specific probes.

Explicit out-of-scope

No SSH calls.
No runtime apply.
No service-specific health endpoint checks.
No rollback implementation beyond the existing rollback stub signal.

Requested decision

Approve and merge if checks stay green.

Merge blockers

Tests fail.
Apply reports success before post-apply smoke passes.
Smoke command or output leaks unredacted remote command/secrets.
Patchwarden flags a safety regression.

Spec sources read

control-plane/platformctl/apply.py - apply flow, status artifact, remote command redaction.
control-plane/platformctl/plan.py - container_name and expected_container_state helpers.
control-plane/platformctl/tests/test_apply_phase3.py - apply behavior tests and fake transport.
Forgejo issue #201 - acceptance criteria.

Validation

PYTHONPATH=control-plane control-plane/.venv/bin/python -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py - 102 passed
PYTHONPATH=control-plane control-plane/.venv/bin/python -m platformctl.cli validate all --json - pass

Closes #201

Canary status: missing - fire canary 3+3 manually before merge ## Canary Context Pack ### Product story Do not report `platformctl apply` as successful merely because Docker accepted `compose up -d`; verify the target container reaches its expected steady state first. ### What changed - Added a read-only post-apply `docker inspect ... State` smoke command. - `applied` is reported only after the container state matches the module's expected state. - Failed or malformed smoke evidence returns `smoke-failed` and writes the status artifact without marking the module applied. - Remote smoke command text is redacted in results/status artifacts like other remote commands. ### Why it changed Issue #201 called out that `docker compose up -d` only proves daemon acceptance, not runtime health. ### Files touched - `control-plane/platformctl/apply.py` - `control-plane/platformctl/tests/test_apply_phase3.py` ### Relevant context - #201 SMOKE-POST-APPLY-01 - #202 explicit transport timeout - #198 apply host allowlist - M06 apply-pipeline runtime safety hardening ### Runtime evidence No runtime mutation. Local validation only. ### Known constraints This smoke is intentionally minimal and read-only: container state only. It does not add HTTP/service-specific probes. ### Explicit out-of-scope - No SSH calls. - No runtime apply. - No service-specific health endpoint checks. - No rollback implementation beyond the existing rollback stub signal. ### Requested decision Approve and merge if checks stay green. ### Merge blockers - Tests fail. - Apply reports success before post-apply smoke passes. - Smoke command or output leaks unredacted remote command/secrets. - Patchwarden flags a safety regression. ## Spec sources read - `control-plane/platformctl/apply.py` - apply flow, status artifact, remote command redaction. - `control-plane/platformctl/plan.py` - `container_name` and `expected_container_state` helpers. - `control-plane/platformctl/tests/test_apply_phase3.py` - apply behavior tests and fake transport. - Forgejo issue #201 - acceptance criteria. ## Validation - `PYTHONPATH=control-plane control-plane/.venv/bin/python -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py` - 102 passed - `PYTHONPATH=control-plane control-plane/.venv/bin/python -m platformctl.cli validate all --json` - pass Closes #201

codex added 1 commit

2026-05-30 16:50:25 +02:00

fix(platformctl): verify post-apply container state

canary-required / collect-diff (pull_request) Successful in 5s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 5s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 26s

Details

python-ci / Python 3.11 (pull_request) Successful in 43s

Details

python-ci / Python 3.12 (pull_request) Successful in 46s

Details

canary-required / canary (pull_request) Successful in 15s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 6m47s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 23s

Details

python-ci / Python 3.13 (pull_request) Successful in 49s

Details

base-is-main / guard (pull_request) Successful in 2s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 5s

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 24s

Details

e87f1f2b6d

codex added the

class/security-sensitive

label

2026-05-30 16:50:26 +02:00

codex commented

2026-05-30 16:58:58 +02:00

Author

Collaborator

Patchwarden PR sanity

Status: eligible_sanity_clean
PR: 648
Commit: e87f1f2b6d57425b7b0ff3dafc29a404a16d2330
Security-sensitive label: present
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

info sensitive-path-touched Sensitive path touched — control-plane/platformctl/apply.py
- Evidence: control-plane/platformctl/apply.py
- Next: Route through the existing 3+3/risk-tier process; model review remains advisory.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: ABSTAIN
medium reviewer output unparseable
- Evidence: no valid JSON object found in response
- Next: investigate provider response; possibly increase max_tokens or retry

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: error
Verdict: -
Note: ReadTimeout: The read operation timed out
Findings: none

`redteam` / `kimi-k2.6:cloud`

Status: error
Verdict: -
Note: ReadTimeout: The read operation timed out
Findings: none

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `648` - Commit: `e87f1f2b6d57425b7b0ff3dafc29a404a16d2330` - Security-sensitive label: `present` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings - **`info` `sensitive-path-touched`** Sensitive path touched — `control-plane/platformctl/apply.py` - Evidence: `control-plane/platformctl/apply.py` - Next: Route through the existing 3+3/risk-tier process; model review remains advisory. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `ABSTAIN` - **`medium`** reviewer output unparseable - Evidence: `no valid JSON object found in response` - Next: investigate provider response; possibly increase max_tokens or retry ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `error` - Verdict: `-` - Note: ReadTimeout: The read operation timed out - Findings: none ### `redteam` / `kimi-k2.6:cloud` - Status: `error` - Verdict: `-` - Note: ReadTimeout: The read operation timed out - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.