pdurlej/platform

Fork 0

feat(memory): register lifecycle hooks #681

Merged

pdurlej merged 1 commit from codex/662-memory-lifecycle-hooks into main

2026-06-02 08:03:32 +02:00

codex commented

2026-06-02 07:50:13 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Summary

Adds the Memory Control Plane lifecycle hook registration layer for #662.

What changed

Adds platformctl memory hook register for explicit settings files.
Registers SessionStart, PreCompact, PostCompact, and PreToolUse commands additively.
Preserves existing hook entries such as RTK PreToolUse and codexbar SessionStart.
Makes pre-compact usable by lifecycle hooks without hand-fed task metadata by adding safe task/objective defaults.
Lets pre-tool-use read common harness JSON payloads from stdin, including tool_name=Write style payloads.
Updates hook documentation and regression tests.

Canary Context Pack

Product story

Memory Control Plane hooks should be executable by harnesses instead of relying on agents remembering lifecycle instructions. This PR gives Claude/Codex surfaces a deterministic, repo-owned way to register those hooks without clobbering existing harness controls.

What changed

A small hook registration helper and CLI command were added under platformctl. Existing hook endpoints were made safer for automatic lifecycle execution.

Why it changed

Issue #662 requires hook registration for claude and codex surfaces, preserving existing hooks including RTK PreToolUse and codexbar SessionStart.

Files touched

control-plane/platformctl/cli.py
control-plane/platformctl/memory.py
control-plane/platformctl/memory_hooks.py
control-plane/platformctl/tests/test_memory_control_plane.py
state/memory/hooks/README.md

Relevant context

decisions/0025-memory-control-plane.md §4
state/memory/hooks/README.md
Forgejo issue #662

Runtime evidence

No runtime config was changed. No live Claude/Codex $HOME settings were edited. No live Postgres migration was applied.

Validation run locally:

python3 -m py_compile control-plane/platformctl/memory.py control-plane/platformctl/memory_hooks.py control-plane/platformctl/cli.py
cd control-plane && uv run pytest platformctl/tests/test_memory_control_plane.py
PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json

Results:

py_compile: pass
test_memory_control_plane.py: 16 passed
platformctl validate all --json: exitCode 0

Known constraints

memory hook register only mutates the explicit --settings file when --write is passed. It does not discover live harness config paths.

Explicit out-of-scope

No live DB/table apply.
No live Claude/Codex config mutation.
No runtime apply.
No closure of #460/#461; those remain docs/spec verification items.

Requested decision

Review and merge if the additive registration contract and tests look correct.

Merge blockers

Any evidence that registration clobbers existing hooks.
Any secret leakage in hook payload handling or test fixtures.
Any hidden live runtime mutation.

Spec sources read

decisions/0025-memory-control-plane.md — ADR lifecycle hook contract.
state/memory/hooks/README.md — existing hook endpoint docs.
control-plane/platformctl/memory.py — existing memory helpers and hook endpoints.
control-plane/platformctl/cli.py — existing platformctl command conventions.
control-plane/platformctl/tests/test_memory_control_plane.py — local regression test conventions.
Forgejo issue #662 — task packet and done criteria.

Closes #662

Canary status: missing — fire canary 3+3 manually before merge ## Summary Adds the Memory Control Plane lifecycle hook registration layer for #662. ## What changed - Adds `platformctl memory hook register` for explicit settings files. - Registers `SessionStart`, `PreCompact`, `PostCompact`, and `PreToolUse` commands additively. - Preserves existing hook entries such as RTK `PreToolUse` and codexbar `SessionStart`. - Makes `pre-compact` usable by lifecycle hooks without hand-fed task metadata by adding safe task/objective defaults. - Lets `pre-tool-use` read common harness JSON payloads from stdin, including `tool_name=Write` style payloads. - Updates hook documentation and regression tests. ## Canary Context Pack ### Product story Memory Control Plane hooks should be executable by harnesses instead of relying on agents remembering lifecycle instructions. This PR gives Claude/Codex surfaces a deterministic, repo-owned way to register those hooks without clobbering existing harness controls. ### What changed A small hook registration helper and CLI command were added under `platformctl`. Existing hook endpoints were made safer for automatic lifecycle execution. ### Why it changed Issue #662 requires hook registration for `claude` and `codex` surfaces, preserving existing hooks including RTK `PreToolUse` and codexbar `SessionStart`. ### Files touched - `control-plane/platformctl/cli.py` - `control-plane/platformctl/memory.py` - `control-plane/platformctl/memory_hooks.py` - `control-plane/platformctl/tests/test_memory_control_plane.py` - `state/memory/hooks/README.md` ### Relevant context - `decisions/0025-memory-control-plane.md` §4 - `state/memory/hooks/README.md` - Forgejo issue #662 ### Runtime evidence No runtime config was changed. No live Claude/Codex `$HOME` settings were edited. No live Postgres migration was applied. Validation run locally: ```bash python3 -m py_compile control-plane/platformctl/memory.py control-plane/platformctl/memory_hooks.py control-plane/platformctl/cli.py cd control-plane && uv run pytest platformctl/tests/test_memory_control_plane.py PYTHONPATH=control-plane uv run --project control-plane python -m platformctl.cli validate all --json ``` Results: - `py_compile`: pass - `test_memory_control_plane.py`: 16 passed - `platformctl validate all --json`: exitCode 0 ### Known constraints `memory hook register` only mutates the explicit `--settings` file when `--write` is passed. It does not discover live harness config paths. ### Explicit out-of-scope - No live DB/table apply. - No live Claude/Codex config mutation. - No runtime apply. - No closure of #460/#461; those remain docs/spec verification items. ### Requested decision Review and merge if the additive registration contract and tests look correct. ### Merge blockers - Any evidence that registration clobbers existing hooks. - Any secret leakage in hook payload handling or test fixtures. - Any hidden live runtime mutation. ## Spec sources read - `decisions/0025-memory-control-plane.md` — ADR lifecycle hook contract. - `state/memory/hooks/README.md` — existing hook endpoint docs. - `control-plane/platformctl/memory.py` — existing memory helpers and hook endpoints. - `control-plane/platformctl/cli.py` — existing platformctl command conventions. - `control-plane/platformctl/tests/test_memory_control_plane.py` — local regression test conventions. - Forgejo issue #662 — task packet and done criteria. Closes #662

codex added 1 commit

2026-06-02 07:50:13 +02:00

feat(memory): register lifecycle hooks

canary-required / collect-diff (pull_request) Successful in 4s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 18s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 16s

Details

python-ci / Python 3.11 (pull_request) Successful in 38s

Details

python-ci / Python 3.12 (pull_request) Successful in 40s

Details

python-ci / Python 3.13 (pull_request) Successful in 38s

Details

canary-required / canary (pull_request) Successful in 12s

Details

base-is-main / guard (pull_request) Successful in 1s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 16s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 3s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 2m33s

Details

9c0cd952c4

codex added the

class/security-sensitive

tier/full

labels

2026-06-02 07:50:55 +02:00

codex added this to the 07 - Honcho memory v2 milestone

2026-06-02 07:51:16 +02:00

codex commented

2026-06-02 07:54:34 +02:00

Author

Collaborator

Patchwarden PR sanity

Status: advisory_findings
PR: 681
Commit: 9c0cd952c49eb9b8e0f4bac60a70bdeece2cf37c
Security-sensitive label: present
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: OK
medium stdin read will hang if pre-tool-use called without piped input
- Evidence: control-plane/platformctl/cli.py lines 618-626: raw = click.get_text_stream('stdin').read() blocks indefinitely on TTY stdin when neither --operation nor --path is provided
- Next: Consider adding a timeout or checking sys.stdin.isatty() to provide a clear error message instead of hanging. Document this behavior prominently if intentional.
low Same-day default task_id collisions possible
- Evidence: control-plane/platformctl/memory.py lines 51-54: default_task_id()returnstask_YYYY_MM_DD_session_lifecycle - multiple sessions on the same day share the same task_id
- Next: Consider appending a short timestamp or session identifier if checkpoint overwrites are a concern. Current behavior may be acceptable for lifecycle hooks.

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: NOT_OK
high pre_tool_guard_from_payload defaults to permissive operation/path when payload keys are missing
- Evidence: control-plane/platformctl/memory.py: new function pre_tool_guard_from_payload defaults operation to 'read' and path to '.' if no recognizable keys are present in the harness payload. This means a harness that sends an unexpected payload for
- Next: Change the default to a safe blocked state (e.g., operation='write', path='~/.ssh/id_ed25519' or raise an error) when the payload cannot be parsed, or at minimum log a warning and block. Add a test for a payload with no recognizable fields to verify the guard fails closed.
low pre-tool-use command may hang if invoked without arguments and without stdin
- Evidence: control-plane/platformctl/cli.py: cmd_memory_hook_pre_tool_use now reads from stdin when --operation/--path are omitted. If the command is run interactively without piping input, it will block waiting for stdin, which could cause harness ti
- Next: Add a timeout or a check for a terminal stdin, and print a usage message instead of blocking. Alternatively, require explicit --operation/--path when not in a pipe.

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: NOT_OK
high pre-tool-use guard bypass via empty string arguments
- Evidence: control-plane/platformctl/cli.py cmd_memory_hook_pre_tool_use: @click.option("--operation", default=None)and@click.option("--path", default=None)allow empty strings. The branchif operation and target_path:treats""as falsy,
- Next: Use explicit is not None checks (and reject empty strings) so that partial or empty explicit arguments raise an error instead of falling back to stdin defaults.

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `advisory_findings` - PR: `681` - Commit: `9c0cd952c49eb9b8e0f4bac60a70bdeece2cf37c` - Security-sensitive label: `present` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - **`medium`** stdin read will hang if pre-tool-use called without piped input - Evidence: `control-plane/platformctl/cli.py lines 618-626: `raw = click.get_text_stream('stdin').read()` blocks indefinitely on TTY stdin when neither --operation nor --path is provided` - Next: Consider adding a timeout or checking `sys.stdin.isatty()` to provide a clear error message instead of hanging. Document this behavior prominently if intentional. - **`low`** Same-day default task_id collisions possible - Evidence: `control-plane/platformctl/memory.py lines 51-54: `default_task_id()` returns `task_YYYY_MM_DD_session_lifecycle` - multiple sessions on the same day share the same task_id` - Next: Consider appending a short timestamp or session identifier if checkpoint overwrites are a concern. Current behavior may be acceptable for lifecycle hooks. ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `NOT_OK` - **`high`** pre_tool_guard_from_payload defaults to permissive operation/path when payload keys are missing - Evidence: `control-plane/platformctl/memory.py: new function pre_tool_guard_from_payload defaults operation to 'read' and path to '.' if no recognizable keys are present in the harness payload. This means a harness that sends an unexpected payload for` - Next: Change the default to a safe blocked state (e.g., operation='write', path='~/.ssh/id_ed25519' or raise an error) when the payload cannot be parsed, or at minimum log a warning and block. Add a test for a payload with no recognizable fields to verify the guard fails closed. - **`low`** pre-tool-use command may hang if invoked without arguments and without stdin - Evidence: `control-plane/platformctl/cli.py: cmd_memory_hook_pre_tool_use now reads from stdin when --operation/--path are omitted. If the command is run interactively without piping input, it will block waiting for stdin, which could cause harness ti` - Next: Add a timeout or a check for a terminal stdin, and print a usage message instead of blocking. Alternatively, require explicit --operation/--path when not in a pipe. ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `NOT_OK` - **`high`** pre-tool-use guard bypass via empty string arguments - Evidence: `control-plane/platformctl/cli.py `cmd_memory_hook_pre_tool_use`: `@click.option("--operation", default=None)` and `@click.option("--path", default=None)` allow empty strings. The branch `if operation and target_path:` treats `""` as falsy, ` - Next: Use explicit `is not None` checks (and reject empty strings) so that partial or empty explicit arguments raise an error instead of falling back to stdin defaults. ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.