fix(ci): make patchwarden comment identity explicit #721

Merged
pdurlej merged 1 commit from codex/issues/711-patchwarden-guard-resolution into main 2026-06-05 01:41:26 +02:00
Collaborator

Summary

  • makes Patchwarden PR comments use explicit actor tokens: FORGEJO_TOKEN_PATCHWARDEN first, then FORGEJO_TOKEN_CODEX, then legacy generic token only with explicit actor
  • adds a metadata-only --patchwarden-readiness verifier that suppresses secret values, lengths, prefixes, suffixes, and fingerprints
  • records the guard resolution: Patchwarden is a bot/safety actor, not a human-login account

Scope

Code/docs only. No Infisical writes, no runner env changes, no token rotation, no credential recovery.

Tests

python3 -m pytest control-plane/platformctl/tests/test_pr_sanity.py tests/test_secret_recovery_verify.py
python3 -m ruff check control-plane/platformctl/ci/pr_sanity.py control-plane/platformctl/tests/test_pr_sanity.py scripts/security/secret_recovery_verify.py tests/test_secret_recovery_verify.py

Smoke

python3 scripts/security/secret_recovery_verify.py --repo-root . --patchwarden-readiness --format json
python3 scripts/security/secret_recovery_verify.py --repo-root . --infisical --infisical-token-file "$HOME/.platformctl-runtime/infisical/claude-client-secret" --recovery-secret-key codex-kan-secret-recovery-2026-06-04 --identity-checks --runtime-host rs2000 --patchwarden-readiness --format json

Observed current state: secret present, identity check returns identity_error with HTTP 403, runtime Docker consumers empty. No secret values or lengths emitted.

Rollback

Revert this PR. That restores the previous comment-token fallback behavior and removes the dedicated Patchwarden readiness report.

Owner gates

Credential recovery remains gated. This PR does not generate, rotate, revoke, store, or map a Patchwarden PAT.

Refs #711

## Summary - makes Patchwarden PR comments use explicit actor tokens: `FORGEJO_TOKEN_PATCHWARDEN` first, then `FORGEJO_TOKEN_CODEX`, then legacy generic token only with explicit actor - adds a metadata-only `--patchwarden-readiness` verifier that suppresses secret values, lengths, prefixes, suffixes, and fingerprints - records the guard resolution: Patchwarden is a bot/safety actor, not a human-login account ## Scope Code/docs only. No Infisical writes, no runner env changes, no token rotation, no credential recovery. ## Tests ```bash python3 -m pytest control-plane/platformctl/tests/test_pr_sanity.py tests/test_secret_recovery_verify.py python3 -m ruff check control-plane/platformctl/ci/pr_sanity.py control-plane/platformctl/tests/test_pr_sanity.py scripts/security/secret_recovery_verify.py tests/test_secret_recovery_verify.py ``` ## Smoke ```bash python3 scripts/security/secret_recovery_verify.py --repo-root . --patchwarden-readiness --format json python3 scripts/security/secret_recovery_verify.py --repo-root . --infisical --infisical-token-file "$HOME/.platformctl-runtime/infisical/claude-client-secret" --recovery-secret-key codex-kan-secret-recovery-2026-06-04 --identity-checks --runtime-host rs2000 --patchwarden-readiness --format json ``` Observed current state: secret present, identity check returns `identity_error` with HTTP 403, runtime Docker consumers empty. No secret values or lengths emitted. ## Rollback Revert this PR. That restores the previous comment-token fallback behavior and removes the dedicated Patchwarden readiness report. ## Owner gates Credential recovery remains gated. This PR does not generate, rotate, revoke, store, or map a Patchwarden PAT. Refs #711
fix(ci): make patchwarden comment identity explicit
Some checks failed
patchwarden-client-dry-run / collect-diff (pull_request) Successful in 4s
platformctl plan / auto-apply scope (pull_request) Successful in 19s
base-is-main / guard (pull_request) Successful in 1s
canary-required / collect-diff (pull_request) Successful in 5s
infra-docs-drift / docs-drift (pull_request) Successful in 5s
patchwarden-pr-sanity / collect-diff (pull_request) Successful in 3s
pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 18s
python-ci / Python 3.11 (pull_request) Successful in 43s
python-ci / Python 3.12 (pull_request) Successful in 44s
patchwarden-client-dry-run / dry-run (pull_request) Successful in 18s
python-ci / Python 3.13 (pull_request) Successful in 45s
workflow-lint / lint (pull_request) Successful in 5s
canary-required / canary (pull_request) Successful in 13s
patchwarden-pr-sanity / sanity (pull_request) Failing after 4m24s
f213a26d80
pdurlej deleted branch codex/issues/711-patchwarden-guard-resolution 2026-06-05 01:41:26 +02:00
Sign in to join this conversation.
No reviewers
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!721
No description provided.