pdurlej/platform

Fork 0

chore(platformctl): remove dead agent access types #779

Merged

pdurlej merged 1 commit from codex/issues/769-agent-access-dead-types into main

2026-06-10 23:53:37 +02:00

codex commented

2026-06-10 23:21:58 +02:00

Collaborator

Canary status: missing - fire canary 3+3 manually before merge

Canary Context Pack

Product story

Reduce misleading platformctl surface so agents do not infer that the autonomy capability catalog is runtime-wired when it is still a design target.

What changed

Removed unused control-plane/platformctl/agent_access/_types.py.
Added a short design-target comment above the real DEFAULT_POLICY in control-plane/platformctl/autonomy.py.

Why it changed

Issue #769 identifies _types.py as imported nowhere and potentially misleading until #733 decides whether to wire or demote the broader capability catalog.

Files touched

control-plane/platformctl/agent_access/_types.py
control-plane/platformctl/autonomy.py

Relevant context

#769 scope and acceptance criteria.
#733 remains the architectural decision for wire vs demote.

Runtime evidence

Not applicable; repo-only cleanup.

Known constraints

This PR does not delete policies/agent-capabilities.yaml and does not make the #733 architectural decision.

Explicit out-of-scope

Capability catalog wiring.
Autonomy router behavior changes.
Runtime credential delivery.

Requested decision

Approve merge if reviewers agree the deleted module is unused and the comment is sufficient.

Merge blockers

Any remaining import/reference to agent_access._types or any unintended runtime behavior change.

Spec sources read

control-plane/platformctl/agent_access/_types.py - deleted dead module.
control-plane/platformctl/autonomy.py - real DEFAULT_POLICY location.
Issue #769 body - scope and acceptance.

Verification

rg -n "agent_access\._types|from .*agent_access import .*_types|import .*_types" control-plane/platformctl control-plane/platformctl/tests - no matches.
git diff --check - passed.
UV_CACHE_DIR=/Users/pd/Developer/platform/.uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests/test_autonomy_router.py -q - 21 passed.
UV_CACHE_DIR=/Users/pd/Developer/platform/.uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests -q - 727 passed.

Closes #769

Canary status: missing - fire canary 3+3 manually before merge ## Canary Context Pack ### Product story Reduce misleading platformctl surface so agents do not infer that the autonomy capability catalog is runtime-wired when it is still a design target. ### What changed - Removed unused `control-plane/platformctl/agent_access/_types.py`. - Added a short design-target comment above the real `DEFAULT_POLICY` in `control-plane/platformctl/autonomy.py`. ### Why it changed Issue #769 identifies `_types.py` as imported nowhere and potentially misleading until #733 decides whether to wire or demote the broader capability catalog. ### Files touched - `control-plane/platformctl/agent_access/_types.py` - `control-plane/platformctl/autonomy.py` ### Relevant context - #769 scope and acceptance criteria. - #733 remains the architectural decision for wire vs demote. ### Runtime evidence Not applicable; repo-only cleanup. ### Known constraints This PR does not delete `policies/agent-capabilities.yaml` and does not make the #733 architectural decision. ### Explicit out-of-scope - Capability catalog wiring. - Autonomy router behavior changes. - Runtime credential delivery. ### Requested decision Approve merge if reviewers agree the deleted module is unused and the comment is sufficient. ### Merge blockers Any remaining import/reference to `agent_access._types` or any unintended runtime behavior change. ## Spec sources read - `control-plane/platformctl/agent_access/_types.py` - deleted dead module. - `control-plane/platformctl/autonomy.py` - real `DEFAULT_POLICY` location. - Issue #769 body - scope and acceptance. ## Verification - `rg -n "agent_access\._types|from .*agent_access import .*_types|import .*_types" control-plane/platformctl control-plane/platformctl/tests` - no matches. - `git diff --check` - passed. - `UV_CACHE_DIR=/Users/pd/Developer/platform/.uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests/test_autonomy_router.py -q` - 21 passed. - `UV_CACHE_DIR=/Users/pd/Developer/platform/.uv-cache PYTHONPATH=control-plane uv run --project control-plane --extra dev pytest control-plane/platformctl/tests -q` - 727 passed. Closes #769

codex added 1 commit

2026-06-10 23:21:58 +02:00

chore(platformctl): remove dead agent access types

base-is-main / guard (pull_request) Successful in 2s

Details

canary-required / collect-diff (pull_request) Successful in 5s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 19s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 17s

Details

python-ci / Python 3.11 (pull_request) Successful in 55s

Details

python-ci / Python 3.12 (pull_request) Successful in 41s

Details

python-ci / Python 3.13 (pull_request) Successful in 41s

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 19s

Details

canary-required / canary (pull_request) Successful in 15s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 1m7s

Details

c399b251ac

patchwarden commented

2026-06-10 23:47:35 +02:00

First-time contributor

Patchwarden PR sanity

Status: eligible_sanity_clean
PR: 779
Commit: c399b251acab51127a710e1d4f1cdd9b8c35eb28
Security-sensitive label: missing
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: OK
Findings: none

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: OK
Findings: none

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: OK
Findings: none

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `779` - Commit: `c399b251acab51127a710e1d4f1cdd9b8c35eb28` - Security-sensitive label: `missing` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.