pdurlej/platform

Fork 0

docs(agent-readiness): clean stale ADR references #787

Merged

pdurlej merged 3 commits from codex/issues/stale-adr-reference-cleanup into main

2026-06-17 23:05:53 +02:00

codex commented

2026-06-11 00:14:03 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Canary Context Pack

Product story

Future cousins should not follow stale ADR numbers or historical green checkmarks that current repo and Forgejo state do not support. This keeps agent-facing docs aligned with the actual decision inventory before platformctl lint --cross-refs becomes part of the normal workflow.

What changed

Replaced references to missing future ADR numbers with unnumbered future ADR/schema references.
Corrected Iskra family-assistant spec references from the old cousin-taxonomy number to ADR-0010.
Removed false claims that the M10 Wake Bus and hardware-consent ADRs were produced/complete; added a dated evidence note.
Updated companion prompts so future Codex work does not target nonexistent ADR files.

Why it changed

The pending cross-reference lint PR exposed ADR_REFERENCE_MISSING findings. Creating placeholder ADR files would hide the signal without making a real decision, so this PR corrects the agent-facing references instead.

Files touched

docs/specs/iskra-family-assistant-tier-v0/*
docs/specs/hermes-voice-clone-spike-v0/README.md
prompts/codex-iskra-family-assistant-tier.md
prompts/codex-hermes-voice-clone-spike.md
state/strategy/m10-closure-plan-2026-05-30.md

Relevant context

ADR-0010 is the accepted cousin role taxonomy.
No durable job-bundle ADR exists in decisions/ on main.
Read-only Forgejo checks on 2026-06-11 showed #132, #134, #180, #181, and #567 still open or parked.

Runtime evidence

No runtime access, deploy, or host mutation. Verification is repo-local/read-only only.

Known constraints

ADR sequence gaps remain warnings. This PR intentionally does not create stub ADRs, renumber existing ADRs, or rewrite historical issue state.

Explicit out-of-scope

Creating Wake Bus or hardware-consent ADRs.
Changing Forgejo issue labels/state/comments.
Resolving the openclaw-mail-gateway INDEX drift already covered by PR #786.
Runtime, secret, auth, or network changes.

Requested decision

Approve this docs-only cleanup if the references now describe future work without pretending missing ADRs exist.

Merge blockers

Any remaining ADR_REFERENCE_MISSING caused by these files.
Any text that implies #132/#134/#180/#181/#567 are closed/resolved when Forgejo says they are open or parked.

Spec sources read

decisions/ listing and decisions/0010-cousin-role-taxonomy.md — confirm accepted ADR inventory and taxonomy number.
docs/specs/iskra-family-assistant-tier-v0/* — stale ADR references and future schema design.
docs/specs/hermes-voice-clone-spike-v0/README.md — stale Phase 07 ADR reference.
prompts/codex-iskra-family-assistant-tier.md and prompts/codex-hermes-voice-clone-spike.md — keep execution prompts aligned.
state/strategy/m10-closure-plan-2026-05-30.md — stale M10 completion claims.
Forgejo issue API for #132, #134, #180, #181, #567 — read-only state check only.

No closing keyword; this is cleanup discovered while validating PR #783.

Canary status: missing — fire canary 3+3 manually before merge ## Canary Context Pack ### Product story Future cousins should not follow stale ADR numbers or historical green checkmarks that current repo and Forgejo state do not support. This keeps agent-facing docs aligned with the actual decision inventory before `platformctl lint --cross-refs` becomes part of the normal workflow. ### What changed - Replaced references to missing future ADR numbers with unnumbered future ADR/schema references. - Corrected Iskra family-assistant spec references from the old cousin-taxonomy number to ADR-0010. - Removed false claims that the M10 Wake Bus and hardware-consent ADRs were produced/complete; added a dated evidence note. - Updated companion prompts so future Codex work does not target nonexistent ADR files. ### Why it changed The pending cross-reference lint PR exposed `ADR_REFERENCE_MISSING` findings. Creating placeholder ADR files would hide the signal without making a real decision, so this PR corrects the agent-facing references instead. ### Files touched - `docs/specs/iskra-family-assistant-tier-v0/*` - `docs/specs/hermes-voice-clone-spike-v0/README.md` - `prompts/codex-iskra-family-assistant-tier.md` - `prompts/codex-hermes-voice-clone-spike.md` - `state/strategy/m10-closure-plan-2026-05-30.md` ### Relevant context - ADR-0010 is the accepted cousin role taxonomy. - No durable job-bundle ADR exists in `decisions/` on `main`. - Read-only Forgejo checks on 2026-06-11 showed #132, #134, #180, #181, and #567 still open or parked. ### Runtime evidence No runtime access, deploy, or host mutation. Verification is repo-local/read-only only. ### Known constraints ADR sequence gaps remain warnings. This PR intentionally does not create stub ADRs, renumber existing ADRs, or rewrite historical issue state. ### Explicit out-of-scope - Creating Wake Bus or hardware-consent ADRs. - Changing Forgejo issue labels/state/comments. - Resolving the `openclaw-mail-gateway` INDEX drift already covered by PR #786. - Runtime, secret, auth, or network changes. ### Requested decision Approve this docs-only cleanup if the references now describe future work without pretending missing ADRs exist. ### Merge blockers - Any remaining `ADR_REFERENCE_MISSING` caused by these files. - Any text that implies #132/#134/#180/#181/#567 are closed/resolved when Forgejo says they are open or parked. ## Spec sources read - `decisions/` listing and `decisions/0010-cousin-role-taxonomy.md` — confirm accepted ADR inventory and taxonomy number. - `docs/specs/iskra-family-assistant-tier-v0/*` — stale ADR references and future schema design. - `docs/specs/hermes-voice-clone-spike-v0/README.md` — stale Phase 07 ADR reference. - `prompts/codex-iskra-family-assistant-tier.md` and `prompts/codex-hermes-voice-clone-spike.md` — keep execution prompts aligned. - `state/strategy/m10-closure-plan-2026-05-30.md` — stale M10 completion claims. - Forgejo issue API for #132, #134, #180, #181, #567 — read-only state check only. No closing keyword; this is cleanup discovered while validating PR #783.

codex added 1 commit

2026-06-11 00:14:03 +02:00

docs: clean stale ADR references

base-is-main / guard (pull_request) Successful in 1s

Details

canary-required / collect-diff (pull_request) Successful in 4s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

canary-required / canary (pull_request) Successful in 13s

Details

patchwarden-client-dry-run / dry-run (pull_request) Failing after 18s

Details

patchwarden-pr-sanity / sanity (pull_request) Has been cancelled

Details

00aada0f69

ollama added 1 commit

2026-06-11 00:29:20 +02:00

docs: split prompt ADR cleanup from spec docs

canary-required / collect-diff (pull_request) Successful in 4s

Details

canary-required / canary (pull_request) Has been skipped

Details

base-is-main / guard (pull_request) Successful in 1s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

patchwarden-client-dry-run / dry-run (pull_request) Failing after 17s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 3s

Details

patchwarden-pr-sanity / sanity (pull_request) Failing after 1m55s

Details

f70e506b97

patchwarden commented

2026-06-11 00:44:51 +02:00

First-time contributor

Patchwarden PR sanity

Status: eligible_sanity_clean
PR: 787
Commit: d2837420b83c6c5dc402abcef821999d62c4bd13
Security-sensitive label: missing
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: ABSTAIN
high Cannot verify merge blocker conditions without diff
- Evidence: Diff section is empty - no hunks or changed files visible to verify claims that ADR_REFERENCE_MISSING findings are resolved and no false claims about Forgejo issue states remain
- Next: Provide actual diff content so reviewer can confirm: (1) no remaining ADR_REFERENCE_MISSING in touched files, (2) no text implying #132/#134/#180/#181/#567 are closed when Forgejo shows them open/parked

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: ABSTAIN
high No diff provided for review
- Evidence: The PR diff is empty; no changed files or hunks are available to verify the described documentation cleanup.
- Next: Ensure the actual diff is included in the review request so that ADR reference corrections, removal of false claims, and alignment with Forgejo state can be validated.

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: OK
Findings: none

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `787` - Commit: `d2837420b83c6c5dc402abcef821999d62c4bd13` - Security-sensitive label: `missing` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `ABSTAIN` - **`high`** Cannot verify merge blocker conditions without diff - Evidence: `Diff section is empty - no hunks or changed files visible to verify claims that ADR_REFERENCE_MISSING findings are resolved and no false claims about Forgejo issue states remain` - Next: Provide actual diff content so reviewer can confirm: (1) no remaining ADR_REFERENCE_MISSING in touched files, (2) no text implying #132/#134/#180/#181/#567 are closed when Forgejo shows them open/parked ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `ABSTAIN` - **`high`** No diff provided for review - Evidence: `The PR diff is empty; no changed files or hunks are available to verify the described documentation cleanup.` - Next: Ensure the actual diff is included in the review request so that ADR reference corrections, removal of false claims, and alignment with Forgejo state can be validated. ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.

codex referenced this pull request

2026-06-11 00:52:42 +02:00

ci(patchwarden): soft-fail advisory review failures #789

codex added the

labels

2026-06-11 08:14:44 +02:00

ollama added 1 commit

2026-06-17 23:04:56 +02:00

docs: finish stale ADR reference cleanup

canary-required / collect-diff (pull_request) Waiting to run

Details

canary-required / canary (pull_request) Blocked by required conditions

Details

base-is-main / guard (pull_request) Successful in 1s

Details

python-ci / Python 3.13 (pull_request) Successful in 40s

Details

workflow-lint / lint (pull_request) Successful in 5s

Details

infra-docs-drift / docs-drift (pull_request) Successful in 4s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 17s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 14s

Details

python-ci / Python 3.11 (pull_request) Successful in 37s

Details

python-ci / Python 3.12 (pull_request) Successful in 39s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 6m8s

Details

patchwarden-client-dry-run / dry-run (pull_request) Failing after 15s

Details

b970caf3a1

codex commented

2026-06-17 23:05:06 +02:00

Author

Collaborator

Role: executor

PR-zero verification/update before merge:

Found remaining stale references in branch names and one example path; pushed follow-up commit b970caf to finish the cleanup.
Checked touched spec/status files for stale ADR-0006, ADR-0008, ADR-0012, decisions/0006, decisions/0008, and old slice branch names -> no matches.
git diff --check -> clean.

Docs/spec cleanup only; no runtime mutation.

**Role:** executor PR-zero verification/update before merge: - Found remaining stale references in branch names and one example path; pushed follow-up commit `b970caf` to finish the cleanup. - Checked touched spec/status files for stale `ADR-0006`, `ADR-0008`, `ADR-0012`, `decisions/0006`, `decisions/0008`, and old slice branch names -> no matches. - `git diff --check` -> clean. Docs/spec cleanup only; no runtime mutation.

ollama force-pushed codex/issues/stale-adr-reference-cleanup from b970caf3a1

canary-required / collect-diff (pull_request) Waiting to run

Details

canary-required / canary (pull_request) Blocked by required conditions

Details

base-is-main / guard (pull_request) Successful in 1s

Details

python-ci / Python 3.13 (pull_request) Successful in 40s

Details

workflow-lint / lint (pull_request) Successful in 5s

Details

infra-docs-drift / docs-drift (pull_request) Successful in 4s