pdurlej/platform

Fork 0

chore(actions): inventory Forgejo task volumes #805

Merged

pdurlej merged 1 commit from codex/issues/801-actions-task-volume-ttl into main

2026-06-18 00:05:01 +02:00

codex commented

2026-06-17 23:56:23 +02:00

Collaborator

Canary status: missing — fire canary 3+3 manually before merge

Canary Context Pack

Product story

RS2000 disk hygiene should distinguish rebuildable CI temp volume cleanup candidates from persistent app data. The operator needs a dry-run inventory that names only Forgejo Actions task volumes, shows age/size/reason, and keeps deletion behind a separate explicit approval.

What changed

Added forgejo-actions-volumes to scripts/host-ops/docker_disk_policy.py.
The command lists strict FORGEJO-ACTIONS-TASK-<n>_WORKFLOW-<workflow>_JOB-<job> matches with age, Docker-reported size, eligibility, and reason.
--execute is accepted but refuses with exit code 7; no live deletion path is implemented.
Added unit tests for selector safety, size parsing, dry-run inventory, and execute refusal.
Updated RS2000 disk hygiene and Forgejo Actions runner runbooks.

Why it changed

#801 came from the RS2000 reclaimables classification: Forgejo Actions task volumes are plausible CI-temp reclaimables, but broad docker volume prune is unsafe because Docker volumes include persistent app data and rollback material.

Files touched

scripts/host-ops/docker_disk_policy.py
tests/test_host_ops_docker_disk_policy.py
runbooks/rs2000-disk-hygiene.md
runbooks/forgejo-actions-runner.md

Relevant context

state/reports/rs2000-docker-reclaimables-classification-2026-06-17.md
runbooks/rs2000-disk-hygiene.md
runbooks/forgejo-actions-runner.md

Runtime evidence

Read-only live dry-run on RS2000, without installing the file:

ssh rs2000 'python3 - forgejo-actions-volumes --ttl-hours 168 --json' < scripts/host-ops/docker_disk_policy.py | jq '{candidate_count, matching_count, ignored_count, errors, volumes: [.volumes[] | {name, age_hours, size, eligible, reason}]}'

Result summary: candidate_count=2, matching_count=4, ignored_count=88, errors=[]. Two old FORGEJO-ACTIONS-TASK-1613... volumes were eligible by TTL; two current FORGEJO-ACTIONS-TASK-9770... volumes were too new. No deletion was executed.

Known constraints

Docker volume contents are not read.
Persistent app volumes, BuildKit state volumes, anonymous volumes, backups, and rollback material are out of selector scope.
docker volume prune remains prohibited.

Explicit out-of-scope

No live deletion.
No systemd timer or automated volume cleanup.
No changes to runner config, Forgejo secrets, Docker daemon settings, or runtime containers.

Requested decision

Approve the dry-run inventory and runbook policy. Future deletion remains a separate operator-approved runtime action.

Merge blockers

Any selector that can match persistent app volumes.
Any live deletion path without explicit approval.
Any use of docker volume prune.

Spec sources read

state/reports/rs2000-docker-reclaimables-classification-2026-06-17.md
runbooks/rs2000-disk-hygiene.md
runbooks/forgejo-actions-runner.md
scripts/host-ops/docker_disk_policy.py — implementation target
tests/test_host_ops_docker_disk_policy.py — existing test target

Verification

python3 -m pytest tests/test_host_ops_docker_disk_policy.py -q
python3 scripts/host-ops/docker_disk_policy.py forgejo-actions-volumes --ttl-hours 168 --execute --json; echo exit=$?
git diff --check

Results: host-ops tests 14 passed; execute refusal emitted refused=true and exited 7; git diff --check passed.

Closes #801

Canary status: missing — fire canary 3+3 manually before merge ## Canary Context Pack ### Product story RS2000 disk hygiene should distinguish rebuildable CI temp volume cleanup candidates from persistent app data. The operator needs a dry-run inventory that names only Forgejo Actions task volumes, shows age/size/reason, and keeps deletion behind a separate explicit approval. ### What changed - Added `forgejo-actions-volumes` to `scripts/host-ops/docker_disk_policy.py`. - The command lists strict `FORGEJO-ACTIONS-TASK-<n>_WORKFLOW-<workflow>_JOB-<job>` matches with age, Docker-reported size, eligibility, and reason. - `--execute` is accepted but refuses with exit code 7; no live deletion path is implemented. - Added unit tests for selector safety, size parsing, dry-run inventory, and execute refusal. - Updated RS2000 disk hygiene and Forgejo Actions runner runbooks. ### Why it changed #801 came from the RS2000 reclaimables classification: Forgejo Actions task volumes are plausible CI-temp reclaimables, but broad `docker volume prune` is unsafe because Docker volumes include persistent app data and rollback material. ### Files touched - `scripts/host-ops/docker_disk_policy.py` - `tests/test_host_ops_docker_disk_policy.py` - `runbooks/rs2000-disk-hygiene.md` - `runbooks/forgejo-actions-runner.md` ### Relevant context - `state/reports/rs2000-docker-reclaimables-classification-2026-06-17.md` - `runbooks/rs2000-disk-hygiene.md` - `runbooks/forgejo-actions-runner.md` ### Runtime evidence Read-only live dry-run on RS2000, without installing the file: ```bash ssh rs2000 'python3 - forgejo-actions-volumes --ttl-hours 168 --json' < scripts/host-ops/docker_disk_policy.py | jq '{candidate_count, matching_count, ignored_count, errors, volumes: [.volumes[] | {name, age_hours, size, eligible, reason}]}' ``` Result summary: `candidate_count=2`, `matching_count=4`, `ignored_count=88`, `errors=[]`. Two old `FORGEJO-ACTIONS-TASK-1613...` volumes were eligible by TTL; two current `FORGEJO-ACTIONS-TASK-9770...` volumes were too new. No deletion was executed. ### Known constraints - Docker volume contents are not read. - Persistent app volumes, BuildKit state volumes, anonymous volumes, backups, and rollback material are out of selector scope. - `docker volume prune` remains prohibited. ### Explicit out-of-scope - No live deletion. - No systemd timer or automated volume cleanup. - No changes to runner config, Forgejo secrets, Docker daemon settings, or runtime containers. ### Requested decision Approve the dry-run inventory and runbook policy. Future deletion remains a separate operator-approved runtime action. ### Merge blockers - Any selector that can match persistent app volumes. - Any live deletion path without explicit approval. - Any use of `docker volume prune`. ## Spec sources read - `state/reports/rs2000-docker-reclaimables-classification-2026-06-17.md` - `runbooks/rs2000-disk-hygiene.md` - `runbooks/forgejo-actions-runner.md` - `scripts/host-ops/docker_disk_policy.py` — implementation target - `tests/test_host_ops_docker_disk_policy.py` — existing test target ## Verification ```bash python3 -m pytest tests/test_host_ops_docker_disk_policy.py -q python3 scripts/host-ops/docker_disk_policy.py forgejo-actions-volumes --ttl-hours 168 --execute --json; echo exit=$? git diff --check ``` Results: host-ops tests `14 passed`; execute refusal emitted `refused=true` and exited `7`; `git diff --check` passed. Closes #801

codex added the

labels

2026-06-17 23:56:23 +02:00

codex added 1 commit

2026-06-17 23:56:23 +02:00

chore(actions): inventory Forgejo task volumes

python-ci / Python 3.13 (pull_request) Successful in 38s

Details

workflow-lint / lint (pull_request) Successful in 5s

Details

base-is-main / guard (pull_request) Successful in 1s

Details

canary-required / collect-diff (pull_request) Successful in 4s

Details

infra-docs-drift / docs-drift (pull_request) Successful in 5s

Details

python-ci / Python 3.11 (pull_request) Successful in 36s

Details

python-ci / Python 3.12 (pull_request) Successful in 38s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

canary-required / canary (pull_request) Has been skipped

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 14s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 47s

Details

d36a141b4b

pdurlej commented

2026-06-18 00:05:00 +02:00

Owner

Merge evidence note before operator-authorized self-merge:

Local verification passed: python3 -m pytest tests/test_host_ops_docker_disk_policy.py -q -> 14 passed.
Safety smoke passed: forgejo-actions-volumes --execute --json refuses deletion with exit 7 and refused=true.
git diff --check passed.
Live read-only RS2000 dry-run passed without installing the file: candidate_count=2, matching_count=4, ignored_count=88, errors=[]; no deletion executed and persistent volumes were outside the selector.
Forgejo checks for this PR are still Waiting to run because the shared Docker runner is currently processing pdurlej/fallow-py tasks, not because this PR has failing checks.

This merge does not perform runtime mutation. Future live deletion of any listed volume remains a separate explicit operator approval.

Merge evidence note before operator-authorized self-merge: - Local verification passed: `python3 -m pytest tests/test_host_ops_docker_disk_policy.py -q` -> `14 passed`. - Safety smoke passed: `forgejo-actions-volumes --execute --json` refuses deletion with exit `7` and `refused=true`. - `git diff --check` passed. - Live read-only RS2000 dry-run passed without installing the file: `candidate_count=2`, `matching_count=4`, `ignored_count=88`, `errors=[]`; no deletion executed and persistent volumes were outside the selector. - Forgejo checks for this PR are still `Waiting to run` because the shared Docker runner is currently processing `pdurlej/fallow-py` tasks, not because this PR has failing checks. This merge does not perform runtime mutation. Future live deletion of any listed volume remains a separate explicit operator approval.

pdurlej merged commit 3a1dbb436f into main

2026-06-18 00:05:01 +02:00

pdurlej referenced this pull request from a commit

2026-06-18 00:05:02 +02:00

Merge pull request #805 from codex/issues/801-actions-task-volume-ttl

pdurlej referenced this pull request

2026-06-18 00:06:36 +02:00

[meta] DeepSeek audit 2026-06-08 — atomic Gemini-ready task batch #766

patchwarden commented

2026-06-18 00:30:37 +02:00

First-time contributor

Patchwarden PR sanity

Status: eligible_sanity_clean
PR: 805
Commit: d36a141b4b6a481d37963b1c8c19cd02054ed4cc
Security-sensitive label: missing
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: OK
Findings: none

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: ABSTAIN
blocker Missing diff prevents review of changed files
- Evidence: The diff section in the review request is empty; no code changes are visible for the four files listed in the PR description.
- Next: Provide the actual diff content for scripts/host-ops/docker_disk_policy.py, tests/test_host_ops_docker_disk_policy.py, runbooks/rs2000-disk-hygiene.md, and runbooks/forgejo-actions-runner.md so that the reviewer can verify selector safety, execute refusal, and runbook accuracy.

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: OK
Findings: none

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `805` - Commit: `d36a141b4b6a481d37963b1c8c19cd02054ed4cc` - Security-sensitive label: `missing` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `ABSTAIN` - **`blocker`** Missing diff prevents review of changed files - Evidence: `The diff section in the review request is empty; no code changes are visible for the four files listed in the PR description.` - Next: Provide the actual diff content for scripts/host-ops/docker_disk_policy.py, tests/test_host_ops_docker_disk_policy.py, runbooks/rs2000-disk-hygiene.md, and runbooks/forgejo-actions-runner.md so that the reviewer can verify selector safety, execute refusal, and runbook accuracy. ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.