fix: make PR sanity comment actionable #829

Merged
pdurlej merged 1 commit from codex/patchwarden-pr-sanity-clawsweeper-comment into main 2026-06-25 23:21:07 +02:00
Collaborator

Follow-up for pdurlej/patchwarden#237.

This makes the Patchwarden PR sanity comment behave more like a ClawSweeper-style sentinel: short verdict first, explicit next action, checked surface, required fixes, reviewer details folded below, and hidden machine-readable metadata for future automation.

What changed:

  • updates the PR sanity model route to glm-5.2:cloud, deepseek-v4-pro:cloud, and kimi-k2.7:cloud red-team;
  • removes the stale 3+3 canary: still alive; this does not replace it UX;
  • adds modelHealth to the JSON report so eligible_sanity_clean no longer hides skipped/error reviewer lanes;
  • renders the sticky comment with verdict, next step, reviewer health, model mix, and a hidden patchwarden.pr_sanity.v1 marker;
  • updates runner/operations docs to match the live workflow.

Verification:

  • python3 -m pytest control-plane/platformctl/tests/test_pr_sanity.py control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py
Follow-up for pdurlej/patchwarden#237. This makes the Patchwarden PR sanity comment behave more like a ClawSweeper-style sentinel: short verdict first, explicit next action, checked surface, required fixes, reviewer details folded below, and hidden machine-readable metadata for future automation. What changed: - updates the PR sanity model route to `glm-5.2:cloud`, `deepseek-v4-pro:cloud`, and `kimi-k2.7:cloud` red-team; - removes the stale `3+3 canary: still alive; this does not replace it` UX; - adds `modelHealth` to the JSON report so `eligible_sanity_clean` no longer hides skipped/error reviewer lanes; - renders the sticky comment with verdict, next step, reviewer health, model mix, and a hidden `patchwarden.pr_sanity.v1` marker; - updates runner/operations docs to match the live workflow. Verification: - `python3 -m pytest control-plane/platformctl/tests/test_pr_sanity.py control-plane/platformctl/tests/test_forgejo_ci_scripts_contract.py`
fix: make pr sanity comment actionable
All checks were successful
platformctl plan / auto-apply scope (pull_request) Successful in 18s
python-ci / Python 3.12 (pull_request) Successful in 42s
workflow-lint / lint (pull_request) Successful in 4s
canary-required / collect-diff (pull_request) Successful in 4s
infra-docs-drift / docs-drift (pull_request) Successful in 4s
pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 16s
python-ci / Python 3.11 (pull_request) Successful in 41s
python-ci / Python 3.13 (pull_request) Successful in 42s
canary-required / canary (pull_request) Successful in 16s
base-is-main / guard (pull_request) Successful in 1s
patchwarden-client-dry-run / collect-diff (pull_request) Successful in 4s
patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s
patchwarden-client-dry-run / dry-run (pull_request) Successful in 19s
patchwarden-pr-sanity / sanity (pull_request) Successful in 40s
8fd2a88c42
First-time contributor

Patchwarden PR sanity

  • Status: eligible_sanity_clean
  • PR: 829
  • Commit: 8fd2a88c42d497193db90ffb31ac58a844b4da28
  • Security-sensitive label: present
  • Authority: advisory model review plus deterministic blockers only
  • 3+3 canary: still alive; this does not replace it

Deterministic findings

  • info sensitive-path-touched Sensitive path touched — .forgejo/workflows/patchwarden-pr-sanity.yml
    • Evidence: .forgejo/workflows/patchwarden-pr-sanity.yml
    • Next: Route through the existing 3+3/risk-tier process; model review remains advisory.

Model reviewers

global-glm / glm-5.2:cloud

  • Status: ok
  • Verdict: OK
  • Findings: none

global-deepseek / deepseek-v4-pro:cloud

  • Status: ok
  • Verdict: OK
  • Findings: none

redteam / kimi-k2.7:cloud

  • Status: error

  • Verdict: -

  • Note: Ollama HTTP 404: {"error": "model 'kimi-k2.7:cloud' not found"}

  • Findings: none

Policy notes

  • GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
  • Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
  • Auto-merge is not enabled here.
<!-- patchwarden-pr-sanity:pdurlej/platform:PR-829 --> # Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `829` - Commit: `8fd2a88c42d497193db90ffb31ac58a844b4da28` - Security-sensitive label: `present` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings - **`info` `sensitive-path-touched`** Sensitive path touched — `.forgejo/workflows/patchwarden-pr-sanity.yml` - Evidence: `.forgejo/workflows/patchwarden-pr-sanity.yml` - Next: Route through the existing 3+3/risk-tier process; model review remains advisory. ## Model reviewers ### `global-glm` / `glm-5.2:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `redteam` / `kimi-k2.7:cloud` - Status: `error` - Verdict: `-` - Note: Ollama HTTP 404: {"error": "model 'kimi-k2.7:cloud' not found"} - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.
pdurlej approved these changes 2026-06-25 23:21:07 +02:00
pdurlej left a comment

Approved by operator-delegated Codex after scoped review, security-sensitive label, and green CI for Patchwarden PR sanity UX follow-up.

Approved by operator-delegated Codex after scoped review, security-sensitive label, and green CI for Patchwarden PR sanity UX follow-up.
pdurlej referenced this pull request from a commit 2026-06-25 23:21:08 +02:00
Sign in to join this conversation.
No reviewers
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!829
No description provided.