pdurlej/fallow-ts

Fork 0

feat(format): show findings in default text output #110

Open

gemini wants to merge 1 commit from gemini/g47-show-findings-text into main

gemini commented

2026-05-28 17:14:45 +02:00

First-time contributor

Issue: Closes #47

What changed

Modified formatText inside src/format.ts to iterate over and list each finding if result.findings.length > 0.
Each finding line includes rule name, severity, confidence, path, line number, and finding message in a clean list format.
Added a dedicated unit test in tests/analyze.test.mjs verifying that formatText formats findings properly.

Why safe

The clean report is unchanged because clean projects (0 findings) do not print the findings section, keeping backward compatibility and clean output compact.
The unit and doc integration tests compiled and passed cleanly.

Verification

npm run build
npm test
git diff --check

Explicit out-of-scope

Showing classification counts in text format (covered in issue #48).
Keeping clean text output compact logic verification under empty error sections (covered in issue #50).

## Issue: Closes #47 ### What changed - Modified `formatText` inside `src/format.ts` to iterate over and list each finding if `result.findings.length > 0`. - Each finding line includes rule name, severity, confidence, path, line number, and finding message in a clean list format. - Added a dedicated unit test in `tests/analyze.test.mjs` verifying that `formatText` formats findings properly. ### Why safe - The clean report is unchanged because clean projects (0 findings) do not print the findings section, keeping backward compatibility and clean output compact. - The unit and doc integration tests compiled and passed cleanly. ### Verification - `npm run build` - `npm test` - `git diff --check` ### Explicit out-of-scope - Showing classification counts in text format (covered in issue #48). - Keeping clean text output compact logic verification under empty error sections (covered in issue #50).

gemini added 1 commit

2026-05-28 17:14:45 +02:00

feat(format): show findings in default text output

CI / Node.js 20 (push) Successful in 16s

Details

CI / Node.js 22 (push) Successful in 14s

Details

CI / test (push) Successful in 27s

Details

CI / test (pull_request) Successful in 27s

Details

CI / Node.js 20 (pull_request) Successful in 15s

Details

CI / Node.js 22 (pull_request) Successful in 15s

Details

02a0db6744

CI / Node.js 20 (push) Successful in 16s

Details

CI / Node.js 22 (push) Successful in 14s

Details

CI / test (push) Successful in 27s

Details

CI / test (pull_request) Successful in 27s

Details

CI / Node.js 20 (pull_request) Successful in 15s

Details

CI / Node.js 22 (pull_request) Successful in 15s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin gemini/g47-show-findings-text:gemini/g47-show-findings-text

git switch gemini/g47-show-findings-text

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff gemini/g47-show-findings-text

git switch gemini/g47-show-findings-text

git rebase main

git switch main

git merge --ff-only gemini/g47-show-findings-text

git switch gemini/g47-show-findings-text

git rebase main

git switch main

git merge --no-ff gemini/g47-show-findings-text

git switch main

git merge --squash gemini/g47-show-findings-text