pdurlej/fallow-ts

Fork 0

feat(format): keep clean text output compact with Findings: 0 #112

Open

gemini wants to merge 1 commit from gemini/g50-clean-text-compact into main

gemini commented

2026-05-28 21:21:10 +02:00

First-time contributor

Issue: Closes #50

What changed

Modified formatText in src/format.ts to output Findings: ${result.findings.length} in the default text output, even if there are 0 findings.
Updated the basic-report.txt golden snapshot file to reflect this new Findings: 0 line.
Added a dedicated unit test in tests/analyze.test.mjs to assert that formatText stays clean and compact when findings are empty.

Why safe

Verified all unit and integration tests compile and pass successfully.
Does not list empty findings or empty errors lists when they are zero, keeping output compact.

Verification

npm run build
npm test
git diff --check

Explicit out-of-scope

Displaying classification counts inside text output when findings exist (covered in issue #48).
Listing individual detailed finding rows (covered in issue #47).

## Issue: Closes #50 ### What changed - Modified `formatText` in `src/format.ts` to output `Findings: ${result.findings.length}` in the default text output, even if there are 0 findings. - Updated the `basic-report.txt` golden snapshot file to reflect this new `Findings: 0` line. - Added a dedicated unit test in `tests/analyze.test.mjs` to assert that `formatText` stays clean and compact when findings are empty. ### Why safe - Verified all unit and integration tests compile and pass successfully. - Does not list empty findings or empty errors lists when they are zero, keeping output compact. ### Verification - `npm run build` - `npm test` - `git diff --check` ### Explicit out-of-scope - Displaying classification counts inside text output when findings exist (covered in issue #48). - Listing individual detailed finding rows (covered in issue #47).

gemini added 1 commit

2026-05-28 21:21:10 +02:00

feat(format): keep clean text output compact with Findings: 0

CI / Node.js 22 (push) Successful in 16s

Details

CI / test (pull_request) Successful in 29s

Details

CI / Node.js 22 (pull_request) Successful in 16s

Details

CI / test (push) Successful in 29s

Details

CI / Node.js 20 (push) Successful in 17s

Details

CI / Node.js 20 (pull_request) Successful in 14s

Details

75cf5d655e

CI / Node.js 22 (push) Successful in 16s

Details

CI / test (pull_request) Successful in 29s

Details

CI / Node.js 22 (pull_request) Successful in 16s

Details

CI / test (push) Successful in 29s

Details

CI / Node.js 20 (push) Successful in 17s

Details

CI / Node.js 20 (pull_request) Successful in 14s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin gemini/g50-clean-text-compact:gemini/g50-clean-text-compact

git switch gemini/g50-clean-text-compact

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff gemini/g50-clean-text-compact

git switch gemini/g50-clean-text-compact

git rebase main

git switch main

git merge --ff-only gemini/g50-clean-text-compact

git switch gemini/g50-clean-text-compact

git rebase main

git switch main

git merge --no-ff gemini/g50-clean-text-compact

git switch main

git merge --squash gemini/g50-clean-text-compact